From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 06/10] audio: Free consumed default audio devices
Date: Fri, 24 Nov 2023 16:24:04 +0100 [thread overview]
Message-ID: <20231124152408.140936-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20231124152408.140936-1-pbonzini@redhat.com>
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Failed default audio devices were removed from the list but not freed,
and that made LeakSanitizer sad. Free default audio devices as they are
consumed.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20231120112804.9736-1-akihiko.odaki@daynix.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
audio/audio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/audio/audio.c b/audio/audio.c
index f91e05b72c9..8d1e4ad9227 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1758,12 +1758,15 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
goto out;
}
s->dev = dev = e->dev;
+ QSIMPLEQ_REMOVE_HEAD(&default_audiodevs, next);
+ g_free(e);
drvname = AudiodevDriver_str(dev->driver);
driver = audio_driver_lookup(drvname);
if (!audio_driver_init(s, driver, dev, NULL)) {
break;
}
- QSIMPLEQ_REMOVE_HEAD(&default_audiodevs, next);
+ qapi_free_Audiodev(dev);
+ s->dev = NULL;
}
}
--
2.43.0
next prev parent reply other threads:[~2023-11-24 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 15:23 [PULL 00/10] Misc bug fixes for QEMU 8.2.0-rc2 Paolo Bonzini
2023-11-24 15:23 ` [PULL 01/10] coverity: physmem: use simple assertions instead of modelling Paolo Bonzini
2023-11-24 15:24 ` [PULL 02/10] tests: respect --enable/--disable-download for Avocado Paolo Bonzini
2023-11-24 15:24 ` [PULL 03/10] docs: document what configure does with virtual environments Paolo Bonzini
2023-11-24 15:24 ` [PULL 04/10] buildsys: Bump known good meson version to v1.2.3 Paolo Bonzini
2023-11-24 15:24 ` [PULL 05/10] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma) Paolo Bonzini
2023-11-24 15:24 ` Paolo Bonzini [this message]
2023-11-24 15:24 ` [PULL 07/10] disas/cris: Pass buffer size to format_dec() to avoid overflow warning Paolo Bonzini
2023-11-24 15:24 ` [PULL 08/10] system: Use &error_abort in memory_region_init_ram_[device_]ptr() Paolo Bonzini
2023-11-24 15:24 ` [PULL 09/10] configure: Make only once with pseudo-"in source tree" builds Paolo Bonzini
2023-11-24 15:24 ` [PULL 10/10] scripts: adjust url to Coverity tools Paolo Bonzini
2023-11-28 13:01 ` [PULL 00/10] Misc bug fixes for QEMU 8.2.0-rc2 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124152408.140936-7-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).