From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors
Date: Fri, 24 Nov 2023 13:14:30 -0300 [thread overview]
Message-ID: <20231124161432.3515-6-farosas@suse.de> (raw)
In-Reply-To: <20231124161432.3515-1-farosas@suse.de>
We're currently just asserting when incoming migration fails. Let's
print the error message from QMP as well.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
tests/qtest/migration-helpers.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index 24fb7b3525..f1106128a9 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest/migration-helpers.c
@@ -118,6 +118,12 @@ void migrate_incoming_qmp(QTestState *to, const char *uri, const char *fmt, ...)
rsp = qtest_qmp(to, "{ 'execute': 'migrate-incoming', 'arguments': %p}",
args);
+
+ if (!qdict_haskey(rsp, "return")) {
+ g_autoptr(GString) s = qobject_to_json_pretty(QOBJECT(rsp), true);
+ g_test_message("%s", s->str);
+ }
+
g_assert(qdict_haskey(rsp, "return"));
qobject_unref(rsp);
--
2.35.3
next prev parent reply other threads:[~2023-11-24 16:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 16:14 [PATCH v1 0/7] migration cleanups and testing improvements Fabiano Rosas
2023-11-24 16:14 ` [PATCH v1 1/7] migration/multifd: Remove MultiFDPages_t::packet_num Fabiano Rosas
2023-11-27 14:42 ` Peter Xu
2023-11-24 16:14 ` [PATCH v1 2/7] migration/multifd: Remove QEMUFile from where it is not needed Fabiano Rosas
2023-11-27 14:44 ` Peter Xu
2023-11-24 16:14 ` [PATCH v1 3/7] migration/multifd: Change multifd_pages_init argument Fabiano Rosas
2023-11-27 14:45 ` Peter Xu
2023-11-24 16:14 ` [PATCH v1 4/7] migration: Report error in incoming migration Fabiano Rosas
2023-11-27 14:46 ` Peter Xu
2023-11-24 16:14 ` Fabiano Rosas [this message]
2023-11-27 14:50 ` [PATCH v1 5/7] tests/qtest/migration: Print migration incoming errors Peter Xu
2023-11-27 15:52 ` Fabiano Rosas
2023-11-27 20:23 ` Peter Xu
2023-11-27 20:32 ` Fabiano Rosas
2023-11-27 20:52 ` Peter Xu
2023-11-24 16:14 ` [PATCH v1 6/7] tests/qtest/migration: Add a wrapper to print test names Fabiano Rosas
2023-11-27 14:54 ` Peter Xu
2023-11-27 15:44 ` Fabiano Rosas
2023-11-27 15:56 ` Peter Xu
2023-11-24 16:14 ` [PATCH v1 7/7] tests/qtest/migration: Use the new migration_test_add Fabiano Rosas
2023-11-27 14:55 ` Peter Xu
2024-01-04 4:56 ` [PATCH v1 0/7] migration cleanups and testing improvements Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124161432.3515-6-farosas@suse.de \
--to=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).