From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 235BCC4167B for ; Sun, 26 Nov 2023 10:02:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7Bxe-0002J9-Mu; Sun, 26 Nov 2023 05:01:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7Bxc-0002Gu-0W for qemu-devel@nongnu.org; Sun, 26 Nov 2023 05:01:57 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7BxZ-0007dq-Uz for qemu-devel@nongnu.org; Sun, 26 Nov 2023 05:01:55 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-332eeb16e39so876079f8f.1 for ; Sun, 26 Nov 2023 02:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1700992911; x=1701597711; darn=nongnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=sWamtikRUf1sDqGW+Z56O+5DFooywPqde+YI6Lz5I54=; b=mlCZHMLtWQPizcgbR/lkP2xA1aLQ8oDKrid5ihLej5tSntaqN3z0hsim+LvqbJ51oK hetTCV/lvDfSCPEVl/8SculEGG//2b+mDAibPd03YFwVdJv9S85sTiobquf5jC3BOj6u y1pZWe6ei8avv5IQKJnkGFH0ewa5dPqSS4AV5+sIqF7HqePvgUC7/UXrUw0fKQFWfoBj nlFCYAPWbTVCyIfMHcgIhwBDMq/Htj92AZIMB6jxrAS2P+st6MOaIAHPu0WwdkdDGDPq 4nlmup19Qalg4a8VL+al8ErU7udaxqMy3hBSjY/U6j7yDTi2ab0nGkhcdLXHBvUOiTWj q3yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700992911; x=1701597711; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sWamtikRUf1sDqGW+Z56O+5DFooywPqde+YI6Lz5I54=; b=iuzOCqQgq/CIGCTngLaBdgY0YoCzqawYkhiB6mrAlpJ6sa4OpwHD7BmEGTOtgM0KWo zVD6YHmadLcLhw9eKkuRtUoZ8A3YDlnPE9vF+XiQKWGsiJEj2CiERWYZ8m++C/N5R6C6 JeroPrE9q3ysuPugwpW9OzeN8XVNTcBIW0w+8fjxkL8EtIlr0KlHY4bhPQKByLVhdjV4 nFpNPGMygbR685gmMg3MtRB3zJNehPTluF+zeOlfhkIbXAwoub72+9xycIe6ek4RDP4x 4q4+1YyWM54H/vm4u+5+eTsFGDBZD+FLFwdxdM5PH8/zCwSHcOrrVvmdzko4hGlhaO/H QEbg== X-Gm-Message-State: AOJu0Yxqv/pivzPWrVbQxz1PmxaA9Yiyu0qvp7mSjDWUsb/uprUPA8Fb 1O/KgK/IiNtBlz11VGzVNbEmNQ== X-Google-Smtp-Source: AGHT+IHZzkyWKfg8Pd3elx0pBvu0sF7/fkjTjGCJMQ69hkt9KVgXj9clvKEGu8ueKatkB3RrvnJzKw== X-Received: by 2002:adf:f5c1:0:b0:332:f895:f599 with SMTP id k1-20020adff5c1000000b00332f895f599mr1734940wrp.29.1700992911365; Sun, 26 Nov 2023 02:01:51 -0800 (PST) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id 2-20020a5d47a2000000b00332ff137c29sm606226wrb.79.2023.11.26.02.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 02:01:50 -0800 (PST) Date: Sun, 26 Nov 2023 11:01:50 +0100 From: Andrew Jones To: Christoph =?utf-8?Q?M=C3=BCllner?= Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , Palmer Dabbelt , Richard Henderson , Laurent Vivier Subject: Re: [PATCH v2] linux-user/riscv: Add Zicboz extensions to hwprobe Message-ID: <20231126-fbb9c420dec7ea31141cb367@orel> References: <20231123181300.2140622-1-christoph.muellner@vrull.eu> <20231124-b892dc7ca5a5f9ff4cceda6e@orel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=ajones@ventanamicro.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Nov 24, 2023 at 06:41:25PM +0100, Christoph Müllner wrote: > On Fri, Nov 24, 2023 at 5:59 PM Andrew Jones wrote: > > > > On Thu, Nov 23, 2023 at 07:12:59PM +0100, Christoph Muellner wrote: > > > From: Christoph Müllner > > > > > > Upstream Linux recently added RISC-V Zicboz support to the hwprobe API. > > > This patch introduces this for QEMU's user space emulator. > > > > > > Signed-off-by: Christoph Müllner > > > --- > > > linux-user/syscall.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > > > index 65ac3ac796..2f9a1c5279 100644 > > > --- a/linux-user/syscall.c > > > +++ b/linux-user/syscall.c > > > @@ -8799,6 +8799,7 @@ static int do_getdents64(abi_long dirfd, abi_long arg2, abi_long count) > > > #define RISCV_HWPROBE_EXT_ZBA (1 << 3) > > > #define RISCV_HWPROBE_EXT_ZBB (1 << 4) > > > #define RISCV_HWPROBE_EXT_ZBS (1 << 5) > > > +#define RISCV_HWPROBE_EXT_ZICBOZ (1 << 6) > > > > > > #define RISCV_HWPROBE_KEY_CPUPERF_0 5 > > > #define RISCV_HWPROBE_MISALIGNED_UNKNOWN (0 << 0) > > > @@ -8855,6 +8856,8 @@ static void risc_hwprobe_fill_pairs(CPURISCVState *env, > > > RISCV_HWPROBE_EXT_ZBB : 0; > > > value |= cfg->ext_zbs ? > > > RISCV_HWPROBE_EXT_ZBS : 0; > > > + value |= cfg->ext_zicboz ? > > > + RISCV_HWPROBE_EXT_ZICBOZ : 0; > > > __put_user(value, &pair->value); > > > break; > > > case RISCV_HWPROBE_KEY_CPUPERF_0: > > > -- > > > 2.41.0 > > > > > > > > > > We should also add support for getting the block size with > > RISCV_HWPROBE_KEY_ZICBOZ_BLOCK_SIZE. > > Hi Andrew, this is already upstream, just the EXT_ZICBOZ is missing: Oh, thanks. In that case, Reviewed-by: Andrew Jones drew