From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
peter.maydell@linaro.org, imammedo@redhat.com,
richard.henderson@linaro.org, quic_llindhol@quicinc.com,
b.galvani@gmail.com, strahinja.p.jankovic@gmail.com,
kfting@nuvoton.com, wuhaotsh@google.com,
nieklinnenbank@gmail.com, rad@semihalf.com,
marcin.juszkiewicz@linaro.org, eduardo@habkost.net,
marcel.apfelbaum@gmail.com, philmd@linaro.org,
wangyanan55@huawei.com, vijai@behindbytes.com,
palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, liwei1518@gmail.com,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
shan.gavin@gmail.com
Subject: [PATCH v7 8/8] hw/riscv/shakti_c: Check CPU type in machine_run_board_init()
Date: Mon, 27 Nov 2023 09:12:10 +1000 [thread overview]
Message-ID: <20231126231210.112820-9-gshan@redhat.com> (raw)
In-Reply-To: <20231126231210.112820-1-gshan@redhat.com>
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/riscv/shakti_c.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c
index 12ea74b032..3888034c2b 100644
--- a/hw/riscv/shakti_c.c
+++ b/hw/riscv/shakti_c.c
@@ -28,7 +28,6 @@
#include "exec/address-spaces.h"
#include "hw/riscv/boot.h"
-
static const struct MemmapEntry {
hwaddr base;
hwaddr size;
@@ -47,12 +46,6 @@ static void shakti_c_machine_state_init(MachineState *mstate)
ShaktiCMachineState *sms = RISCV_SHAKTI_MACHINE(mstate);
MemoryRegion *system_memory = get_system_memory();
- /* Allow only Shakti C CPU for this platform */
- if (strcmp(mstate->cpu_type, TYPE_RISCV_CPU_SHAKTI_C) != 0) {
- error_report("This board can only be used with Shakti C CPU");
- exit(1);
- }
-
/* Initialize SoC */
object_initialize_child(OBJECT(mstate), "soc", &sms->soc,
TYPE_RISCV_SHAKTI_SOC);
@@ -82,9 +75,15 @@ static void shakti_c_machine_instance_init(Object *obj)
static void shakti_c_machine_class_init(ObjectClass *klass, void *data)
{
MachineClass *mc = MACHINE_CLASS(klass);
+ static const char * const valid_cpu_types[] = {
+ RISCV_CPU_TYPE_NAME("shakti-c"),
+ NULL
+ };
+
mc->desc = "RISC-V Board compatible with Shakti SDK";
mc->init = shakti_c_machine_state_init;
mc->default_cpu_type = TYPE_RISCV_CPU_SHAKTI_C;
+ mc->valid_cpu_types = valid_cpu_types;
mc->default_ram_id = "riscv.shakti.c.ram";
}
--
2.42.0
next prev parent reply other threads:[~2023-11-26 23:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 23:12 [PATCH v7 0/8] Unified CPU type check Gavin Shan
2023-11-26 23:12 ` [PATCH v7 1/8] machine: Use error handling when CPU type is checked Gavin Shan
2023-11-28 9:43 ` Philippe Mathieu-Daudé
2023-11-28 22:47 ` Gavin Shan
2023-11-26 23:12 ` [PATCH v7 2/8] machine: Introduce helper is_cpu_type_supported() Gavin Shan
2023-11-28 9:38 ` Philippe Mathieu-Daudé
2023-11-28 22:55 ` Gavin Shan
2023-11-26 23:12 ` [PATCH v7 3/8] machine: Print CPU model name instead of CPU type Gavin Shan
2023-11-28 9:55 ` Philippe Mathieu-Daudé
2023-11-29 3:53 ` Gavin Shan
2023-11-26 23:12 ` [PATCH v7 4/8] hw/arm/virt: Hide host CPU model for tcg Gavin Shan
2023-11-28 9:29 ` Philippe Mathieu-Daudé
2023-11-26 23:12 ` [PATCH v7 5/8] hw/arm/virt: Check CPU type in machine_run_board_init() Gavin Shan
2023-11-27 10:13 ` Marcin Juszkiewicz
2023-11-27 10:42 ` Gavin Shan
2023-11-26 23:12 ` [PATCH v7 6/8] hw/arm/sbsa-ref: " Gavin Shan
2023-11-26 23:12 ` [PATCH v7 7/8] hw/arm: " Gavin Shan
2023-11-28 9:31 ` Philippe Mathieu-Daudé
2023-11-26 23:12 ` Gavin Shan [this message]
2023-11-27 10:10 ` [PATCH v7 0/8] Unified CPU type check Marcin Juszkiewicz
2023-11-27 10:15 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126231210.112820-9-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=b.galvani@gmail.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=kfting@nuvoton.com \
--cc=liwei1518@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=nieklinnenbank@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=strahinja.p.jankovic@gmail.com \
--cc=vijai@behindbytes.com \
--cc=wangyanan55@huawei.com \
--cc=wuhaotsh@google.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).