From: Ninad Palsule <ninad@linux.ibm.com>
To: qemu-devel@nongnu.org, clg@kaod.org, peter.maydell@linaro.org,
andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com,
marcandre.lureau@redhat.com, berrange@redhat.com,
thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com
Cc: Ninad Palsule <ninad@linux.ibm.com>,
qemu-arm@nongnu.org, Andrew Jeffery <andrew@aj.id.au>
Subject: [PATCH v8 04/10] hw/fsi: IBM's On-chip Peripheral Bus
Date: Tue, 28 Nov 2023 17:56:54 -0600 [thread overview]
Message-ID: <20231128235700.599584-5-ninad@linux.ibm.com> (raw)
In-Reply-To: <20231128235700.599584-1-ninad@linux.ibm.com>
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The On-Chip Peripheral Bus (OPB): A low-speed bus typically found in
POWER processors. This now makes an appearance in the ASPEED SoC due
to tight integration of the FSI master IP with the OPB, mainly the
existence of an MMIO-mapping of the CFAM address straight onto a
sub-region of the OPB address space.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
[ clg: - removed FSIMasterState object and fsi_opb_realize()
- simplified OPBus ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
include/hw/fsi/opb.h | 25 +++++++++++++++++++++++++
hw/fsi/opb.c | 36 ++++++++++++++++++++++++++++++++++++
hw/fsi/Kconfig | 4 ++++
hw/fsi/meson.build | 1 +
4 files changed, 66 insertions(+)
create mode 100644 include/hw/fsi/opb.h
create mode 100644 hw/fsi/opb.c
diff --git a/include/hw/fsi/opb.h b/include/hw/fsi/opb.h
new file mode 100644
index 0000000000..c112206f9e
--- /dev/null
+++ b/include/hw/fsi/opb.h
@@ -0,0 +1,25 @@
+/*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ * Copyright (C) 2023 IBM Corp.
+ *
+ * IBM On-Chip Peripheral Bus
+ */
+#ifndef FSI_OPB_H
+#define FSI_OPB_H
+
+#include "exec/memory.h"
+#include "hw/fsi/fsi-master.h"
+
+#define TYPE_OP_BUS "opb"
+OBJECT_DECLARE_SIMPLE_TYPE(OPBus, OP_BUS)
+
+typedef struct OPBus {
+ /*< private >*/
+ BusState bus;
+
+ /*< public >*/
+ MemoryRegion mr;
+ AddressSpace as;
+} OPBus;
+
+#endif /* FSI_OPB_H */
diff --git a/hw/fsi/opb.c b/hw/fsi/opb.c
new file mode 100644
index 0000000000..6474754890
--- /dev/null
+++ b/hw/fsi/opb.c
@@ -0,0 +1,36 @@
+/*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ * Copyright (C) 2023 IBM Corp.
+ *
+ * IBM On-chip Peripheral Bus
+ */
+
+#include "qemu/osdep.h"
+
+#include "qapi/error.h"
+#include "qemu/log.h"
+
+#include "hw/fsi/opb.h"
+
+static void fsi_opb_init(Object *o)
+{
+ OPBus *opb = OP_BUS(o);
+
+ memory_region_init_io(&opb->mr, OBJECT(opb), NULL, opb,
+ NULL, UINT32_MAX);
+ address_space_init(&opb->as, &opb->mr, "opb");
+}
+
+static const TypeInfo opb_info = {
+ .name = TYPE_OP_BUS,
+ .parent = TYPE_BUS,
+ .instance_init = fsi_opb_init,
+ .instance_size = sizeof(OPBus),
+};
+
+static void fsi_opb_register_types(void)
+{
+ type_register_static(&opb_info);
+}
+
+type_init(fsi_opb_register_types);
diff --git a/hw/fsi/Kconfig b/hw/fsi/Kconfig
index de1594a335..9755baa8cc 100644
--- a/hw/fsi/Kconfig
+++ b/hw/fsi/Kconfig
@@ -1,3 +1,7 @@
+config FSI_OPB
+ bool
+ select FSI_CFAM
+
config FSI_CFAM
bool
select FSI
diff --git a/hw/fsi/meson.build b/hw/fsi/meson.build
index cafd009c6d..ba92881370 100644
--- a/hw/fsi/meson.build
+++ b/hw/fsi/meson.build
@@ -1,3 +1,4 @@
system_ss.add(when: 'CONFIG_FSI_LBUS', if_true: files('lbus.c'))
system_ss.add(when: 'CONFIG_FSI_CFAM', if_true: files('cfam.c'))
system_ss.add(when: 'CONFIG_FSI', if_true: files('fsi.c','fsi-slave.c'))
+system_ss.add(when: 'CONFIG_FSI_OPB', if_true: files('opb.c'))
--
2.39.2
next prev parent reply other threads:[~2023-11-29 0:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 23:56 [PATCH v8 00/10] Introduce model for IBM's FSI Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 01/10] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2023-12-12 14:46 ` Cédric Le Goater
2024-01-09 19:23 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 02/10] hw/fsi: Introduce IBM's FSI Bus Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave,scratchpad Ninad Palsule
2023-12-12 14:48 ` Cédric Le Goater
2024-01-09 22:08 ` Ninad Palsule
2023-11-28 23:56 ` Ninad Palsule [this message]
2023-12-12 14:48 ` [PATCH v8 04/10] hw/fsi: IBM's On-chip Peripheral Bus Cédric Le Goater
2024-01-08 22:49 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 05/10] hw/fsi: Introduce IBM's FSI master Ninad Palsule
2023-12-12 14:49 ` Cédric Le Goater
2024-01-09 20:12 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 06/10] hw/fsi: Aspeed APB2OPB interface Ninad Palsule
2023-12-12 14:49 ` Cédric Le Goater
2024-01-08 22:39 ` Ninad Palsule
2024-01-09 7:38 ` Cédric Le Goater
2024-01-09 20:30 ` Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 07/10] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2023-12-12 14:49 ` Cédric Le Goater
2023-11-28 23:56 ` [PATCH v8 08/10] hw/fsi: Added qtest Ninad Palsule
2023-11-28 23:56 ` [PATCH v8 09/10] hw/fsi: Added FSI documentation Ninad Palsule
2023-11-28 23:57 ` [PATCH v8 10/10] hw/fsi: Update MAINTAINER list Ninad Palsule
2024-01-10 7:44 ` [PATCH v8 00/10] Introduce model for IBM's FSI Cédric Le Goater
2024-01-10 23:17 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128235700.599584-5-ninad@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).