From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
peter.maydell@linaro.org, imammedo@redhat.com,
b.galvani@gmail.com, strahinja.p.jankovic@gmail.com,
sundeep.lkml@gmail.com, kfting@nuvoton.com, wuhaotsh@google.com,
nieklinnenbank@gmail.com, rad@semihalf.com,
quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org,
eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com, vijai@behindbytes.com,
palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, liwei1518@gmail.com,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
shan.gavin@gmail.com
Subject: [PATCH v8 4/9] machine: Print CPU model name instead of CPU type
Date: Wed, 29 Nov 2023 14:20:07 +1000 [thread overview]
Message-ID: <20231129042012.277831-5-gshan@redhat.com> (raw)
In-Reply-To: <20231129042012.277831-1-gshan@redhat.com>
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages to print CPU model names instead of CPU
type names.
Signed-off-by: Gavin Shan <gshan@redhat.com>
---
v8: Use g_autofree (Phil)
Relace 'type' with 'model' in error messages (Gavin)
---
hw/core/machine.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index c58c84abf5..946875930c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1408,15 +1408,19 @@ static bool is_cpu_type_supported(const MachineState *machine, Error **errp)
/* The user specified CPU type isn't valid */
if (!mc->valid_cpu_types[i]) {
- error_setg(errp, "Invalid CPU type: %s", machine->cpu_type);
+ g_autofree char *requested = cpu_model_from_type(machine->cpu_type);
+ error_setg(errp, "Invalid CPU model: %s", requested);
if (!mc->valid_cpu_types[1]) {
- error_append_hint(errp, "The only valid type is: %s\n",
- mc->valid_cpu_types[0]);
+ g_autofree char *model = cpu_model_from_type(
+ mc->valid_cpu_types[0]);
+ error_append_hint(errp, "The only valid type is: %s\n", model);
} else {
- error_append_hint(errp, "The valid types are: ");
+ error_append_hint(errp, "The valid models are: ");
for (i = 0; mc->valid_cpu_types[i]; i++) {
+ g_autofree char *model = cpu_model_from_type(
+ mc->valid_cpu_types[i]);
error_append_hint(errp, "%s%s",
- mc->valid_cpu_types[i],
+ model,
mc->valid_cpu_types[i + 1] ? ", " : "");
}
error_append_hint(errp, "\n");
--
2.42.0
next prev parent reply other threads:[~2023-11-29 4:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 4:20 [PATCH v8 0/9] Unified CPU type check Gavin Shan
2023-11-29 4:20 ` [PATCH v8 1/9] machine: Use error handling when CPU type is checked Gavin Shan
2023-11-29 8:20 ` Markus Armbruster
2023-12-01 3:33 ` Gavin Shan
2023-11-29 4:20 ` [PATCH v8 2/9] machine: Introduce helper is_cpu_type_supported() Gavin Shan
2023-12-01 10:53 ` Philippe Mathieu-Daudé
2023-12-03 23:13 ` Gavin Shan
2024-01-05 11:10 ` Philippe Mathieu-Daudé
2023-11-29 4:20 ` [PATCH v8 3/9] machine: Improve is_cpu_type_supported() Gavin Shan
2023-12-01 10:57 ` Philippe Mathieu-Daudé
2023-12-03 23:20 ` Gavin Shan
2023-12-03 23:30 ` Gavin Shan
2023-11-29 4:20 ` Gavin Shan [this message]
2023-12-01 10:58 ` [PATCH v8 4/9] machine: Print CPU model name instead of CPU type Philippe Mathieu-Daudé
2023-11-29 4:20 ` [PATCH v8 5/9] hw/arm/virt: Hide host CPU model for tcg Gavin Shan
2023-11-29 4:20 ` [PATCH v8 6/9] hw/arm/virt: Check CPU type in machine_run_board_init() Gavin Shan
2023-11-29 4:20 ` [PATCH v8 7/9] hw/arm/sbsa-ref: " Gavin Shan
2023-11-29 4:20 ` [PATCH v8 8/9] hw/arm: " Gavin Shan
2023-11-29 4:20 ` [PATCH v8 9/9] hw/riscv/shakti_c: " Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129042012.277831-5-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=b.galvani@gmail.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=kfting@nuvoton.com \
--cc=liwei1518@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=nieklinnenbank@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=shan.gavin@gmail.com \
--cc=strahinja.p.jankovic@gmail.com \
--cc=sundeep.lkml@gmail.com \
--cc=vijai@behindbytes.com \
--cc=wangyanan55@huawei.com \
--cc=wuhaotsh@google.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).