qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Zhao Liu <zhao1.liu@linux.intel.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Ani Sinha <anisinha@redhat.com>,
	qemu-devel@nongnu.org, Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
Date: Wed, 29 Nov 2023 11:09:10 +0100	[thread overview]
Message-ID: <20231129110910.34df85a2@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20231127160202.1037290-1-zhao1.liu@linux.intel.com>

On Tue, 28 Nov 2023 00:02:02 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:

> From: Zhao Liu <zhao1.liu@intel.com>
> 
> In fact, type4-count, core-count, core-count2, thread-count and
> thread-count2 are tested with KVM not TCG.
> 
> Rename these test functions to reflect KVM base instead of TCG.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 71af5cf69fc5..9a7e459e8ffb 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1003,7 +1003,7 @@ static void test_acpi_q35_tcg(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_type4_count(void)
> +static void test_acpi_q35_kvm_type4_count(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1019,7 +1019,7 @@ static void test_acpi_q35_tcg_type4_count(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_core_count(void)
> +static void test_acpi_q35_kvm_core_count(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1036,7 +1036,7 @@ static void test_acpi_q35_tcg_core_count(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_core_count2(void)
> +static void test_acpi_q35_kvm_core_count2(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1053,7 +1053,7 @@ static void test_acpi_q35_tcg_core_count2(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_thread_count(void)
> +static void test_acpi_q35_kvm_thread_count(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -1070,7 +1070,7 @@ static void test_acpi_q35_tcg_thread_count(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_q35_tcg_thread_count2(void)
> +static void test_acpi_q35_kvm_thread_count2(void)
>  {
>      test_data data = {
>          .machine = MACHINE_Q35,
> @@ -2250,15 +2250,15 @@ int main(int argc, char *argv[])
>                  qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
>                  qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
>                  qtest_add_func("acpi/q35/type4-count",
> -                               test_acpi_q35_tcg_type4_count);
> +                               test_acpi_q35_kvm_type4_count);
>                  qtest_add_func("acpi/q35/core-count",
> -                               test_acpi_q35_tcg_core_count);
> +                               test_acpi_q35_kvm_core_count);
>                  qtest_add_func("acpi/q35/core-count2",
> -                               test_acpi_q35_tcg_core_count2);
> +                               test_acpi_q35_kvm_core_count2);
>                  qtest_add_func("acpi/q35/thread-count",
> -                               test_acpi_q35_tcg_thread_count);
> +                               test_acpi_q35_kvm_thread_count);
>                  qtest_add_func("acpi/q35/thread-count2",
> -                               test_acpi_q35_tcg_thread_count2);
> +                               test_acpi_q35_kvm_thread_count2);
>              }
>              if (qtest_has_device("virtio-iommu-pci")) {
>                  qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);



      parent reply	other threads:[~2023-11-29 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 16:02 [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions Zhao Liu
2023-11-27 19:15 ` Philippe Mathieu-Daudé
2023-11-29 10:09 ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129110910.34df85a2@imammedo.users.ipa.redhat.com \
    --to=imammedo@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhao1.liu@intel.com \
    --cc=zhao1.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).