* [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
@ 2023-11-27 16:02 Zhao Liu
2023-11-27 19:15 ` Philippe Mathieu-Daudé
2023-11-29 10:09 ` Igor Mammedov
0 siblings, 2 replies; 3+ messages in thread
From: Zhao Liu @ 2023-11-27 16:02 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, qemu-devel; +Cc: Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
In fact, type4-count, core-count, core-count2, thread-count and
thread-count2 are tested with KVM not TCG.
Rename these test functions to reflect KVM base instead of TCG.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 71af5cf69fc5..9a7e459e8ffb 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1003,7 +1003,7 @@ static void test_acpi_q35_tcg(void)
free_test_data(&data);
}
-static void test_acpi_q35_tcg_type4_count(void)
+static void test_acpi_q35_kvm_type4_count(void)
{
test_data data = {
.machine = MACHINE_Q35,
@@ -1019,7 +1019,7 @@ static void test_acpi_q35_tcg_type4_count(void)
free_test_data(&data);
}
-static void test_acpi_q35_tcg_core_count(void)
+static void test_acpi_q35_kvm_core_count(void)
{
test_data data = {
.machine = MACHINE_Q35,
@@ -1036,7 +1036,7 @@ static void test_acpi_q35_tcg_core_count(void)
free_test_data(&data);
}
-static void test_acpi_q35_tcg_core_count2(void)
+static void test_acpi_q35_kvm_core_count2(void)
{
test_data data = {
.machine = MACHINE_Q35,
@@ -1053,7 +1053,7 @@ static void test_acpi_q35_tcg_core_count2(void)
free_test_data(&data);
}
-static void test_acpi_q35_tcg_thread_count(void)
+static void test_acpi_q35_kvm_thread_count(void)
{
test_data data = {
.machine = MACHINE_Q35,
@@ -1070,7 +1070,7 @@ static void test_acpi_q35_tcg_thread_count(void)
free_test_data(&data);
}
-static void test_acpi_q35_tcg_thread_count2(void)
+static void test_acpi_q35_kvm_thread_count2(void)
{
test_data data = {
.machine = MACHINE_Q35,
@@ -2250,15 +2250,15 @@ int main(int argc, char *argv[])
qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
qtest_add_func("acpi/q35/type4-count",
- test_acpi_q35_tcg_type4_count);
+ test_acpi_q35_kvm_type4_count);
qtest_add_func("acpi/q35/core-count",
- test_acpi_q35_tcg_core_count);
+ test_acpi_q35_kvm_core_count);
qtest_add_func("acpi/q35/core-count2",
- test_acpi_q35_tcg_core_count2);
+ test_acpi_q35_kvm_core_count2);
qtest_add_func("acpi/q35/thread-count",
- test_acpi_q35_tcg_thread_count);
+ test_acpi_q35_kvm_thread_count);
qtest_add_func("acpi/q35/thread-count2",
- test_acpi_q35_tcg_thread_count2);
+ test_acpi_q35_kvm_thread_count2);
}
if (qtest_has_device("virtio-iommu-pci")) {
qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
2023-11-27 16:02 [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions Zhao Liu
@ 2023-11-27 19:15 ` Philippe Mathieu-Daudé
2023-11-29 10:09 ` Igor Mammedov
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-11-27 19:15 UTC (permalink / raw)
To: Zhao Liu, Michael S . Tsirkin, Igor Mammedov, Ani Sinha,
qemu-devel
Cc: Zhao Liu
On 27/11/23 17:02, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> In fact, type4-count, core-count, core-count2, thread-count and
> thread-count2 are tested with KVM not TCG.
>
> Rename these test functions to reflect KVM base instead of TCG.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> tests/qtest/bios-tables-test.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions
2023-11-27 16:02 [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions Zhao Liu
2023-11-27 19:15 ` Philippe Mathieu-Daudé
@ 2023-11-29 10:09 ` Igor Mammedov
1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2023-11-29 10:09 UTC (permalink / raw)
To: Zhao Liu; +Cc: Michael S . Tsirkin, Ani Sinha, qemu-devel, Zhao Liu
On Tue, 28 Nov 2023 00:02:02 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> In fact, type4-count, core-count, core-count2, thread-count and
> thread-count2 are tested with KVM not TCG.
>
> Rename these test functions to reflect KVM base instead of TCG.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 71af5cf69fc5..9a7e459e8ffb 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1003,7 +1003,7 @@ static void test_acpi_q35_tcg(void)
> free_test_data(&data);
> }
>
> -static void test_acpi_q35_tcg_type4_count(void)
> +static void test_acpi_q35_kvm_type4_count(void)
> {
> test_data data = {
> .machine = MACHINE_Q35,
> @@ -1019,7 +1019,7 @@ static void test_acpi_q35_tcg_type4_count(void)
> free_test_data(&data);
> }
>
> -static void test_acpi_q35_tcg_core_count(void)
> +static void test_acpi_q35_kvm_core_count(void)
> {
> test_data data = {
> .machine = MACHINE_Q35,
> @@ -1036,7 +1036,7 @@ static void test_acpi_q35_tcg_core_count(void)
> free_test_data(&data);
> }
>
> -static void test_acpi_q35_tcg_core_count2(void)
> +static void test_acpi_q35_kvm_core_count2(void)
> {
> test_data data = {
> .machine = MACHINE_Q35,
> @@ -1053,7 +1053,7 @@ static void test_acpi_q35_tcg_core_count2(void)
> free_test_data(&data);
> }
>
> -static void test_acpi_q35_tcg_thread_count(void)
> +static void test_acpi_q35_kvm_thread_count(void)
> {
> test_data data = {
> .machine = MACHINE_Q35,
> @@ -1070,7 +1070,7 @@ static void test_acpi_q35_tcg_thread_count(void)
> free_test_data(&data);
> }
>
> -static void test_acpi_q35_tcg_thread_count2(void)
> +static void test_acpi_q35_kvm_thread_count2(void)
> {
> test_data data = {
> .machine = MACHINE_Q35,
> @@ -2250,15 +2250,15 @@ int main(int argc, char *argv[])
> qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
> qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
> qtest_add_func("acpi/q35/type4-count",
> - test_acpi_q35_tcg_type4_count);
> + test_acpi_q35_kvm_type4_count);
> qtest_add_func("acpi/q35/core-count",
> - test_acpi_q35_tcg_core_count);
> + test_acpi_q35_kvm_core_count);
> qtest_add_func("acpi/q35/core-count2",
> - test_acpi_q35_tcg_core_count2);
> + test_acpi_q35_kvm_core_count2);
> qtest_add_func("acpi/q35/thread-count",
> - test_acpi_q35_tcg_thread_count);
> + test_acpi_q35_kvm_thread_count);
> qtest_add_func("acpi/q35/thread-count2",
> - test_acpi_q35_tcg_thread_count2);
> + test_acpi_q35_kvm_thread_count2);
> }
> if (qtest_has_device("virtio-iommu-pci")) {
> qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-29 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-27 16:02 [PATCH] tests: bios-tables-test: Rename smbios type 4 related test functions Zhao Liu
2023-11-27 19:15 ` Philippe Mathieu-Daudé
2023-11-29 10:09 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).