qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: fam@euphon.net, jasowang@redhat.com, mst@redhat.com,
	sgarzare@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/2] vhost-scsi: Support worker ioctls
Date: Wed, 29 Nov 2023 08:43:23 -0500	[thread overview]
Message-ID: <20231129134323.GA774040@fedora> (raw)
In-Reply-To: <20231127002834.8670-1-michael.christie@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

On Sun, Nov 26, 2023 at 06:28:32PM -0600, Mike Christie wrote:
> The following patches allow users to configure the vhost worker threads
> for vhost-scsi. With vhost-net we get a worker thread per rx/tx virtqueue
> pair, but for vhost-scsi we get one worker for all workqueues. This
> becomes a bottlneck after 2 queues are used.
> 
> In the upstream linux kernel commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/vhost/vhost.c?id=c1ecd8e9500797748ae4f79657971955d452d69d
> 
> we enabled the vhost layer to be able to create a worker thread and
> attach it to a virtqueue.
> 
> This patchset adds support to vhost-scsi to use these ioctls so we are
> no longer limited to the single worker.
> 
> v2:
> - Make config option a bool instead of an int.
> 
> 

Aside from Stefano's comment asking for a warning when the kernel
doesn't support the vhost worker ioctl:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2023-11-29 13:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27  0:28 [PATCH v2 0/2] vhost-scsi: Support worker ioctls Mike Christie
2023-11-27  0:28 ` [PATCH v2 1/2] vhost: Add worker backend callouts Mike Christie
2023-11-29  9:26   ` Stefano Garzarella
2023-11-27  0:28 ` [PATCH v2 2/2] vhost-scsi: Add support for a worker thread per virtqueue Mike Christie
2023-11-29  9:30   ` Stefano Garzarella
2023-11-29 17:40     ` Mike Christie
2023-11-29 13:43 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129134323.GA774040@fedora \
    --to=stefanha@redhat.com \
    --cc=fam@euphon.net \
    --cc=jasowang@redhat.com \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).