From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 821B7C4167B for ; Thu, 30 Nov 2023 20:38:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8nn0-0001Ui-6V; Thu, 30 Nov 2023 15:37:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8nmv-0001ME-7x for qemu-devel@nongnu.org; Thu, 30 Nov 2023 15:37:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8nms-0007Up-53 for qemu-devel@nongnu.org; Thu, 30 Nov 2023 15:37:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701376649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+iKxVT3Aoxm2ETYbHgSKpvUXyQ0XJ8rFvA2vgboplHU=; b=hW6GsID15gGACN9CVU77siWFGuwahUR66MCO0GWqLMsF8Tz6sYppPnvfWBCorajj4LmYpJ oHQ04JiIgAxqyJ749Q7FdY0pDcTvPZS0KxC08BLRf5afUkJ+RtxVBh/VUp+sOA2066xvLs yXnrlw59dHt33hdieQm7DlHMA4d11Qk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-EGzAGfmtP1Gfd_b9MrP_Pw-1; Thu, 30 Nov 2023 15:37:25 -0500 X-MC-Unique: EGzAGfmtP1Gfd_b9MrP_Pw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D6F62802292; Thu, 30 Nov 2023 20:37:21 +0000 (UTC) Received: from localhost (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDF641C060BD; Thu, 30 Nov 2023 20:37:19 +0000 (UTC) Date: Thu, 30 Nov 2023 15:37:18 -0500 From: Stefan Hajnoczi To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Jean-Christophe Dubois , Fabiano Rosas , qemu-s390x@nongnu.org, Song Gao , Marcel Apfelbaum , Thomas Huth , Hyman Huang , Marcelo Tosatti , David Woodhouse , Andrey Smirnov , Peter Maydell , Kevin Wolf , Ilya Leoshkevich , Artyom Tarasenko , Mark Cave-Ayland , Max Filippov , Alistair Francis , Paul Durrant , Jagannathan Raman , Juan Quintela , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-arm@nongnu.org, Jason Wang , Gerd Hoffmann , Hanna Reitz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , BALATON Zoltan , Daniel Henrique Barboza , Elena Ufimtseva , Aurelien Jarno , Hailiang Zhang , Roman Bolshakov , Huacai Chen , Fam Zheng , Eric Blake , Jiri Slaby , Alexander Graf , Liu Zhiwei , Weiwei Li , Eric Farman , Stafford Horne , David Hildenbrand , Markus Armbruster , Reinoud Zandijk , Palmer Dabbelt , Cameron Esfahani , xen-devel@lists.xenproject.org, Pavel Dovgalyuk , qemu-riscv@nongnu.org, Aleksandar Rikalo , John Snow , Sunil Muthuswamy , Michael Roth , David Gibson , "Michael S. Tsirkin" , Richard Henderson , Bin Meng , Stefano Stabellini , kvm@vger.kernel.org, qemu-block@nongnu.org, Halil Pasic , Peter Xu , Anthony Perard , Harsh Prateek Bora , Alex =?iso-8859-1?Q?Benn=E9e?= , Eduardo Habkost , Paolo Bonzini , Vladimir Sementsov-Ogievskiy , =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, Christian Borntraeger , Akihiko Odaki , Leonardo Bras , Nicholas Piggin , Jiaxun Yang Subject: Re: [PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs Message-ID: <20231130203718.GD1184658@fedora> References: <20231129212625.1051502-1-stefanha@redhat.com> <20231129212625.1051502-7-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rAX955JzN10OrQ/Q" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --rAX955JzN10OrQ/Q Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 30, 2023 at 02:49:48PM +0100, Philippe Mathieu-Daud=E9 wrote: > On 29/11/23 22:26, Stefan Hajnoczi wrote: > > The term "QEMU global mutex" is identical to the more widely used Big > > QEMU Lock ("BQL"). Update the code comments and documentation to use > > "BQL" instead of "QEMU global mutex". > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > docs/devel/multi-thread-tcg.rst | 7 +++---- > > docs/devel/qapi-code-gen.rst | 2 +- > > docs/devel/replay.rst | 2 +- > > docs/devel/multiple-iothreads.txt | 16 ++++++++-------- > > include/block/blockjob.h | 6 +++--- > > include/io/task.h | 2 +- > > include/qemu/coroutine-core.h | 2 +- > > include/qemu/coroutine.h | 2 +- > > hw/block/dataplane/virtio-blk.c | 8 ++++---- > > hw/block/virtio-blk.c | 2 +- > > hw/scsi/virtio-scsi-dataplane.c | 6 +++--- > > net/tap.c | 2 +- > > 12 files changed, 28 insertions(+), 29 deletions(-) >=20 >=20 > > diff --git a/include/block/blockjob.h b/include/block/blockjob.h > > index e594c10d23..b2bc7c04d6 100644 > > --- a/include/block/blockjob.h > > +++ b/include/block/blockjob.h > > @@ -54,7 +54,7 @@ typedef struct BlockJob { > > /** > > * Speed that was set with @block_job_set_speed. > > - * Always modified and read under QEMU global mutex (GLOBAL_STATE_= CODE). > > + * Always modified and read under BQL (GLOBAL_STATE_CODE). >=20 > "under the BQL" >=20 > > */ > > int64_t speed; > > @@ -66,7 +66,7 @@ typedef struct BlockJob { > > /** > > * Block other operations when block job is running. > > - * Always modified and read under QEMU global mutex (GLOBAL_STATE_= CODE). > > + * Always modified and read under BQL (GLOBAL_STATE_CODE). >=20 > Ditto, >=20 > > */ > > Error *blocker; > > @@ -89,7 +89,7 @@ typedef struct BlockJob { > > /** > > * BlockDriverStates that are involved in this block job. > > - * Always modified and read under QEMU global mutex (GLOBAL_STATE_= CODE). > > + * Always modified and read under BQL (GLOBAL_STATE_CODE). >=20 > Ditto. >=20 > > */ > > GSList *nodes; > > } BlockJob; Will fix in v2. Stefan --rAX955JzN10OrQ/Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmVo8n4ACgkQnKSrs4Gr c8hqqggAtuleOhegca1BHCQqICnBO4Olum6obo9K4B6RhmNaK9kIfqeO3kNFY9K0 xy7SGfNACel07j3Lttl6p+xHJOe1zaE7IV2o9jKqMK0J09vpTZSXq06ssaTJrYZn p2hGeneWnTJU5O3qUpotRsBp19PdMJLL3o2V7fJ+FRmE+0bc1KTCfzaIDC0IWFQD rc5d8Et49WwA+aKWhDsn3GeRlvfxIxk/TFHsfdkLSdpU/LVU9lP/ExNVLqwYTNl9 OChcXKr+5mvuONgflXwub4uzX8FbIS/HoPIIC7uBG5xE+gao+EYmNRXVFFHRC+CP /rjI7iW5qJHCSKa8tj2XY0KwbTSlcQ== =hoap -----END PGP SIGNATURE----- --rAX955JzN10OrQ/Q--