From: Akinobu Mita <akinobu.mita@gmail.com>
To: qemu-devel@nongnu.org
Cc: akinobu.mita@gmail.com, jeuk20.kim@samsung.com
Subject: [PATCH] hw/ufs: avoid generating the same ID string for different LU devices
Date: Tue, 5 Dec 2023 00:05:43 +0900 [thread overview]
Message-ID: <20231204150543.48252-1-akinobu.mita@gmail.com> (raw)
QEMU would not start when trying to create two UFS host controllers and
a UFS logical unit for each with the following options:
-device ufs,id=bus0 \
-device ufs-lu,drive=drive1,bus=bus0,lun=0 \
-device ufs,id=bus1 \
-device ufs-lu,drive=drive2,bus=bus1,lun=0 \
This is because the same ID string ("0:0:0/scsi-disk") is generated
for both UFS logical units.
To fix this issue, prepend the parent pci device's path to make
the ID string unique.
("0000:00:03.0/0:0:0/scsi-disk" and "0000:00:04.0/0:0:0/scsi-disk")
Fixes: 096434fea13a ("hw/ufs: Modify lu.c to share codes with SCSI subsystem")
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
hw/ufs/ufs.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index 68c5f1f6c9..eccdb852a0 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
@@ -1323,9 +1323,17 @@ static bool ufs_bus_check_address(BusState *qbus, DeviceState *qdev,
return true;
}
+static char *ufs_bus_get_dev_path(DeviceState *dev)
+{
+ BusState *bus = qdev_get_parent_bus(dev);
+
+ return qdev_get_dev_path(bus->parent);
+}
+
static void ufs_bus_class_init(ObjectClass *class, void *data)
{
BusClass *bc = BUS_CLASS(class);
+ bc->get_dev_path = ufs_bus_get_dev_path;
bc->check_address = ufs_bus_check_address;
}
--
2.34.1
next reply other threads:[~2023-12-04 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 15:05 Akinobu Mita [this message]
2023-12-04 16:50 ` [PATCH-for-8.2?] hw/ufs: avoid generating the same ID string for different LU devices Philippe Mathieu-Daudé
2023-12-04 19:21 ` Philippe Mathieu-Daudé
[not found] ` <CGME20231204192120epcas2p3e10bef4174d3ff1e7a6caaa55ed5a7ab@epcms2p8>
2023-12-05 5:18 ` Jeuk Kim
[not found] ` <CGME20231204165101epcas2p3ed3c9102682beb57ceed403189b33ef5@epcms2p8>
2023-12-05 4:33 ` Jeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204150543.48252-1-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=jeuk20.kim@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).