From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Cleber Rosa" <crosa@redhat.com>,
"Xie Changlong" <xiechanglong.d@gmail.com>,
"Paul Durrant" <paul@xen.org>, "Ari Sundholm" <ari@tuxera.com>,
"Jason Wang" <jasowang@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Wen Congyang" <wencongyang2@huawei.com>,
"Alberto Garcia" <berto@igalia.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
qemu-block@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Coiby Xu" <Coiby.Xu@gmail.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Hanna Reitz" <hreitz@redhat.com>,
"Zhang Chen" <chen.zhang@intel.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Peter Xu" <peterx@redhat.com>,
"Emanuele Giuseppe Esposito" <eesposit@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Leonardo Bras" <leobras@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Li Zhijian" <lizhijian@fujitsu.com>,
xen-devel@lists.xenproject.org
Subject: [PATCH v2 07/14] block: remove bdrv_co_lock()
Date: Tue, 5 Dec 2023 13:20:04 -0500 [thread overview]
Message-ID: <20231205182011.1976568-8-stefanha@redhat.com> (raw)
In-Reply-To: <20231205182011.1976568-1-stefanha@redhat.com>
The bdrv_co_lock() and bdrv_co_unlock() functions are already no-ops.
Remove them.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/block/block-global-state.h | 14 --------------
block.c | 10 ----------
blockdev.c | 4 ----
3 files changed, 28 deletions(-)
diff --git a/include/block/block-global-state.h b/include/block/block-global-state.h
index 0327f1c605..4ec0b217f0 100644
--- a/include/block/block-global-state.h
+++ b/include/block/block-global-state.h
@@ -267,20 +267,6 @@ int bdrv_debug_remove_breakpoint(BlockDriverState *bs, const char *tag);
int bdrv_debug_resume(BlockDriverState *bs, const char *tag);
bool bdrv_debug_is_suspended(BlockDriverState *bs, const char *tag);
-/**
- * Locks the AioContext of @bs if it's not the current AioContext. This avoids
- * double locking which could lead to deadlocks: This is a coroutine_fn, so we
- * know we already own the lock of the current AioContext.
- *
- * May only be called in the main thread.
- */
-void coroutine_fn bdrv_co_lock(BlockDriverState *bs);
-
-/**
- * Unlocks the AioContext of @bs if it's not the current AioContext.
- */
-void coroutine_fn bdrv_co_unlock(BlockDriverState *bs);
-
bool bdrv_child_change_aio_context(BdrvChild *c, AioContext *ctx,
GHashTable *visited, Transaction *tran,
Error **errp);
diff --git a/block.c b/block.c
index 91ace5d2d5..434b7f4d72 100644
--- a/block.c
+++ b/block.c
@@ -7431,16 +7431,6 @@ void coroutine_fn bdrv_co_leave(BlockDriverState *bs, AioContext *old_ctx)
bdrv_dec_in_flight(bs);
}
-void coroutine_fn bdrv_co_lock(BlockDriverState *bs)
-{
- /* TODO removed in next patch */
-}
-
-void coroutine_fn bdrv_co_unlock(BlockDriverState *bs)
-{
- /* TODO removed in next patch */
-}
-
static void bdrv_do_remove_aio_context_notifier(BdrvAioNotifier *ban)
{
GLOBAL_STATE_CODE();
diff --git a/blockdev.c b/blockdev.c
index 8a1b28f830..3a5e7222ec 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2264,18 +2264,14 @@ void coroutine_fn qmp_block_resize(const char *device, const char *node_name,
return;
}
- bdrv_co_lock(bs);
bdrv_drained_begin(bs);
- bdrv_co_unlock(bs);
old_ctx = bdrv_co_enter(bs);
blk_co_truncate(blk, size, false, PREALLOC_MODE_OFF, 0, errp);
bdrv_co_leave(bs, old_ctx);
- bdrv_co_lock(bs);
bdrv_drained_end(bs);
blk_co_unref(blk);
- bdrv_co_unlock(bs);
}
void qmp_block_stream(const char *job_id, const char *device,
--
2.43.0
next prev parent reply other threads:[~2023-12-05 18:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 18:19 [PATCH v2 00/14] aio: remove AioContext lock Stefan Hajnoczi
2023-12-05 18:19 ` [PATCH v2 01/14] virtio-scsi: replace AioContext lock with tmf_bh_lock Stefan Hajnoczi
2023-12-05 18:19 ` [PATCH v2 02/14] scsi: assert that callbacks run in the correct AioContext Stefan Hajnoczi
2023-12-18 15:35 ` Kevin Wolf
2023-12-05 18:20 ` [PATCH v2 03/14] tests: remove aio_context_acquire() tests Stefan Hajnoczi
2023-12-05 18:20 ` [PATCH v2 04/14] aio: make aio_context_acquire()/aio_context_release() a no-op Stefan Hajnoczi
2023-12-19 15:28 ` Kevin Wolf
2023-12-19 18:19 ` Kevin Wolf
2023-12-19 21:23 ` Stefan Hajnoczi
2023-12-20 9:32 ` Kevin Wolf
2023-12-20 13:40 ` Stefan Hajnoczi
2023-12-21 0:30 ` Stefan Hajnoczi
2023-12-05 18:20 ` [PATCH v2 05/14] graph-lock: remove AioContext locking Stefan Hajnoczi
2023-12-05 18:20 ` [PATCH v2 06/14] block: " Stefan Hajnoczi
2023-12-19 15:58 ` Kevin Wolf
2023-12-19 20:04 ` Stefan Hajnoczi
2023-12-20 9:19 ` Kevin Wolf
2023-12-05 18:20 ` Stefan Hajnoczi [this message]
2023-12-18 15:35 ` [PATCH v2 07/14] block: remove bdrv_co_lock() Kevin Wolf
2023-12-05 18:20 ` [PATCH v2 08/14] scsi: remove AioContext locking Stefan Hajnoczi
2023-12-18 15:35 ` Kevin Wolf
2023-12-05 18:20 ` [PATCH v2 09/14] aio-wait: draw equivalence between AIO_WAIT_WHILE() and AIO_WAIT_WHILE_UNLOCKED() Stefan Hajnoczi
2023-12-18 15:35 ` Kevin Wolf
2023-12-05 18:20 ` [PATCH v2 10/14] aio: remove aio_context_acquire()/aio_context_release() API Stefan Hajnoczi
2023-12-18 15:36 ` Kevin Wolf
2023-12-05 18:20 ` [PATCH v2 11/14] docs: remove AioContext lock from IOThread docs Stefan Hajnoczi
2023-12-05 18:20 ` [PATCH v2 12/14] scsi: remove outdated AioContext lock comment Stefan Hajnoczi
2023-12-05 18:20 ` [PATCH v2 13/14] job: remove outdated AioContext locking comments Stefan Hajnoczi
2023-12-05 18:20 ` [PATCH v2 14/14] block: " Stefan Hajnoczi
2023-12-19 12:11 ` Kevin Wolf
2023-12-19 13:03 ` [PATCH v2 00/14] aio: remove AioContext lock Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205182011.1976568-8-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=ari@tuxera.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=chen.zhang@intel.com \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=eesposit@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sstabellini@kernel.org \
--cc=vsementsov@yandex-team.ru \
--cc=wencongyang2@huawei.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).