From: Francisco Iglesias <frasse.iglesias@gmail.com>
To: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
qemu-block@nongnu.org, Alistair Francis <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Kevin Wolf <kwolf@redhat.com>,
saipavanboddu@gmail.com
Subject: Re: [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac
Date: Tue, 5 Dec 2023 20:58:51 +0100 [thread overview]
Message-ID: <20231205195850.GA9927@fralle-msi> (raw)
In-Reply-To: <20231205094802.2683581-2-sai.pavan.boddu@amd.com>
On [2023 Dec 05] Tue 15:18:02, Sai Pavan Boddu wrote:
> The OSPI DMA reads flash data through the OSPI linear address space (the
> iomem_dac region), because of this the reentrancy guard introduced in
> commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for
> the memory region.
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Tested-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> ---
> hw/ssi/xlnx-versal-ospi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c
> index 1a61679c2f..5123e7dde7 100644
> --- a/hw/ssi/xlnx-versal-ospi.c
> +++ b/hw/ssi/xlnx-versal-ospi.c
> @@ -1772,6 +1772,7 @@ static void xlnx_versal_ospi_init(Object *obj)
> memory_region_init_io(&s->iomem_dac, obj, &ospi_dac_ops, s,
> TYPE_XILINX_VERSAL_OSPI "-dac", 0x20000000);
> sysbus_init_mmio(sbd, &s->iomem_dac);
> + s->iomem_dac.disable_reentrancy_guard = true;
>
> sysbus_init_irq(sbd, &s->irq);
>
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2023-12-05 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 9:48 [PATCH 0/1] versal-ospi fix Sai Pavan Boddu
2023-12-05 9:48 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
2023-12-05 19:58 ` Francisco Iglesias [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-05 10:08 [PATCH 0/1] versal-ospi fix Sai Pavan Boddu
2023-12-05 10:08 ` [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac Sai Pavan Boddu
2023-12-12 16:42 ` Peter Maydell
2023-12-14 5:34 ` Boddu, Sai Pavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205195850.GA9927@fralle-msi \
--to=frasse.iglesias@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@amd.com \
--cc=saipavanboddu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).