From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Paul Durrant" <paul@xen.org>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvm@vger.kernel.org, qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>,
"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>
Subject: [PATCH 07/10] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset
Date: Fri, 8 Dec 2023 14:09:08 -0500 [thread overview]
Message-ID: <20231208190911.102879-8-crosa@redhat.com> (raw)
In-Reply-To: <20231208190911.102879-1-crosa@redhat.com>
The asset used in the mentioned test gets truncated before it's used
in the test. This means that the file gets modified, and thus the
asset's expected hash doesn't match anymore. This causes cache misses
and re-downloads every time the test is re-run.
Let's make a copy of the asset so that the one in the cache is
preserved and the cache sees a hit on re-runs.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/avocado/boot_linux_console.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
index f5c5d647a4..e2e928e703 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -414,14 +414,16 @@ def test_arm_emcraft_sf2(self):
'fe371d32e50ca682391e1e70ab98c2942aeffb01/spi.bin')
spi_hash = '65523a1835949b6f4553be96dec1b6a38fb05501'
spi_path = self.fetch_asset(spi_url, asset_hash=spi_hash)
+ spi_path_rw = os.path.join(self.workdir, os.path.basename(spi_path))
+ shutil.copy(spi_path, spi_path_rw)
- file_truncate(spi_path, 16 << 20) # Spansion S25FL128SDPBHICO is 16 MiB
+ file_truncate(spi_path_rw, 16 << 20) # Spansion S25FL128SDPBHICO is 16 MiB
self.vm.set_console()
kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE
self.vm.add_args('-kernel', uboot_path,
'-append', kernel_command_line,
- '-drive', 'file=' + spi_path + ',if=mtd,format=raw',
+ '-drive', 'file=' + spi_path_rw + ',if=mtd,format=raw',
'-no-reboot')
self.vm.launch()
self.wait_for_console_pattern('Enter \'help\' for a list')
--
2.43.0
next prev parent reply other threads:[~2023-12-08 19:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 19:09 [PATCH 00/10] for-8.3 tests/avocado: prep for Avocado 103.0 LTS Cleber Rosa
2023-12-08 19:09 ` [PATCH 01/10] tests/avocado: mips: fallback to HTTP given certificate expiration Cleber Rosa
2023-12-11 16:51 ` Alex Bennée
2023-12-08 19:09 ` [PATCH 02/10] tests/avocado: mips: add hint for fetchasset plugin Cleber Rosa
2023-12-10 4:11 ` Akihiko Odaki
2023-12-13 19:39 ` Cleber Rosa
2023-12-08 19:09 ` [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout Cleber Rosa
2023-12-11 17:01 ` Alex Bennée
2023-12-12 8:18 ` Akihiko Odaki
2023-12-12 11:27 ` Alex Bennée
2023-12-13 20:08 ` Cleber Rosa
2023-12-14 7:24 ` Eric Auger
2023-12-14 9:41 ` Alex Bennée
2023-12-14 13:26 ` Eric Auger
2023-12-14 9:41 ` Philippe Mathieu-Daudé
2023-12-08 19:09 ` [PATCH 04/10] tests/avocado: machine aarch64: standardize location and RO/RW access Cleber Rosa
2023-12-08 20:03 ` Marcin Juszkiewicz
2023-12-13 21:01 ` Cleber Rosa
2023-12-14 10:30 ` Alex Bennée
2023-12-11 17:47 ` Alex Bennée
2023-12-13 21:14 ` Cleber Rosa
2023-12-14 10:34 ` Alex Bennée
2023-12-08 19:09 ` [PATCH 05/10] tests/avocado: use more distinct names for assets Cleber Rosa
2023-12-11 16:30 ` Philippe Mathieu-Daudé
2023-12-08 19:09 ` [PATCH 06/10] tests/avocado/kvm_xen_guest.py: cope with asset RW requirements Cleber Rosa
2023-12-11 16:32 ` Philippe Mathieu-Daudé
2024-08-01 3:30 ` Cleber Rosa
2024-08-01 12:57 ` Philippe Mathieu-Daudé
2024-08-01 15:17 ` Cleber Rosa
2024-08-02 13:14 ` Philippe Mathieu-Daudé
2023-12-08 19:09 ` Cleber Rosa [this message]
2023-12-11 16:36 ` [PATCH 07/10] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset Philippe Mathieu-Daudé
2023-12-12 8:13 ` Akihiko Odaki
2023-12-08 19:09 ` [PATCH 08/10] tests/avocado/boot_xen.py: merge base classes Cleber Rosa
2023-12-08 19:09 ` [PATCH 09/10] tests/avocado/boot_xen.py: unify tags Cleber Rosa
2023-12-11 16:37 ` Philippe Mathieu-Daudé
2023-12-08 19:09 ` [PATCH 10/10] tests/avocado/boot_xen.py: use class attribute Cleber Rosa
2023-12-11 16:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208190911.102879-8-crosa@redhat.com \
--to=crosa@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kvm@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=sriram.yagnaraman@est.tech \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).