From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jason Wang <jasowang@redhat.com>,
Dmitry Fleytman <dmitry.fleytman@gmail.com>,
Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
"Michael S. Tsirkin" <mst@redhat.com>,
Luigi Rizzo <rizzo@iet.unipi.it>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Vincenzo Maffione <v.maffione@gmail.com>,
Andrew Melnychenko <andrew@daynix.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>,
"Zhang, Chen" <chen.zhang@intel.com>,
Michael Tokarev <mjt@tls.msk.ru>
Subject: [PATCH v8 00/19] virtio-net RSS/hash report fixes and improvements
Date: Sun, 10 Dec 2023 14:29:38 +0900 [thread overview]
Message-ID: <20231210-rss-v8-0-9553ee714d38@daynix.com> (raw)
This series contains fixes and improvements for virtio-net RSS and hash
reporting feature.
V7 -> V8:
Reset author email addresses.
Rebased.
V6 -> V7:
Dropped patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT".
Dropped the changes to remove packet flags.
Re-introduced tap_receive() and changed it to call tap_receive_iov().
Removed tap_get_vnet_hdr_len().
Fixed tap initialization not to call tap_fd_set_vnet_hdr_len() for tap
without virtio-net header.
Changed to call error_report() instead of warn_report() for
programming errors.
V5 -> V6:
Corrected the message for patch "virtio-net: Return an error when vhost
cannot enable RSS".
Removed changes to introduce asserts from "virtio-net: Return an error
when vhost cannot enable RSS".
Reorganized patches "virtio-net: Return an error when vhost cannot
enable RSS" and "virtio-net: Do not clear VIRTIO_NET_F_RSS". This
version now contains patches "virtio-net: Return an error when vhost
cannot enable RSS" and "virtio-net: Enable software RSS".
Rebased.
V4 -> V5:
Added patch "virtio-net: Do not write hashes to peer buffer".
V3 -> V4:
Extract patches "tap: Remove tap_receive()" and "net: Remove flag
propagation" from "net: Remove receive_raw()".
Added patch "virtio-net: Always set populate_hash".
Added patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT".
Added patch "ebpf: Use standard section name".
Added patch "ebpf: Simplify error handling".
Added patch "ebpf: Return 0 when configuration fails".
Added patch "ebpf: Refactor tun_rss_steering_prog()".
Added patch "ebpf: Add a separate target for skeleton".
V2 -> V3:
Added patch "tap: Remove tap_probe_vnet_hdr_len()".
Added patch "tap: Remove qemu_using_vnet_hdr()".
Added patch "net: Move virtio-net header length assertion".
Added patch "net: Remove receive_raw()".
Added patch "tap: Shrink zeroed virtio-net header".
Dropped patch "tap: Fix virtio-net header buffer size".
V1 -> V2:
Added patch "ebpf: Fix RSS error handling".
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (19):
tap: Remove tap_probe_vnet_hdr_len()
tap: Remove qemu_using_vnet_hdr()
net: Move virtio-net header length assertion
net: Remove receive_raw()
tap: Call tap_receive_iov() from tap_receive()
tap: Shrink zeroed virtio-net header
virtio-net: Copy header only when necessary
virtio-net: Disable RSS on reset
virtio-net: Unify the logic to update NIC state for RSS
virtio-net: Return an error when vhost cannot enable RSS
virtio-net: Report RSS warning at device realization
virtio-net: Always set populate_hash
virtio-net: Do not write hashes to peer buffer
ebpf: Fix RSS error handling
ebpf: Use standard section name
ebpf: Simplify error handling
ebpf: Return 0 when configuration fails
ebpf: Refactor tun_rss_steering_prog()
ebpf: Add a separate target for skeleton
ebpf/rss.bpf.skeleton.h | 1557 +++++++++++++++++++++++-----------------------
include/net/net.h | 8 -
net/tap_int.h | 1 -
ebpf/ebpf_rss.c | 12 +-
hw/net/e1000e.c | 1 -
hw/net/igb.c | 1 -
hw/net/net_tx_pkt.c | 4 +-
hw/net/virtio-net.c | 308 +++++----
hw/net/vmxnet3.c | 2 -
net/dump.c | 4 +-
net/net.c | 47 +-
net/netmap.c | 5 -
net/tap-bsd.c | 5 -
net/tap-linux.c | 20 -
net/tap-solaris.c | 5 -
net/tap-stub.c | 5 -
net/tap.c | 77 +--
tools/ebpf/rss.bpf.c | 46 +-
tools/ebpf/Makefile.ebpf | 15 +-
19 files changed, 986 insertions(+), 1137 deletions(-)
---
base-commit: 9c74490bff6c8886a922008d0c9ce6cae70dd17e
change-id: 20231210-rss-e7c98e722253
Best regards,
--
Akihiko Odaki <akihiko.odaki@daynix.com>
next reply other threads:[~2023-12-10 5:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 5:29 Akihiko Odaki [this message]
2023-12-10 5:29 ` [PATCH v8 01/19] tap: Remove tap_probe_vnet_hdr_len() Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 02/19] tap: Remove qemu_using_vnet_hdr() Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 03/19] net: Move virtio-net header length assertion Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 04/19] net: Remove receive_raw() Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 05/19] tap: Call tap_receive_iov() from tap_receive() Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 06/19] tap: Shrink zeroed virtio-net header Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 07/19] virtio-net: Copy header only when necessary Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 08/19] virtio-net: Disable RSS on reset Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 09/19] virtio-net: Unify the logic to update NIC state for RSS Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 10/19] virtio-net: Return an error when vhost cannot enable RSS Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 11/19] virtio-net: Report RSS warning at device realization Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 12/19] virtio-net: Always set populate_hash Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 13/19] virtio-net: Do not write hashes to peer buffer Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 14/19] ebpf: Fix RSS error handling Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 15/19] ebpf: Use standard section name Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 16/19] ebpf: Simplify error handling Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 17/19] ebpf: Return 0 when configuration fails Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 18/19] ebpf: Refactor tun_rss_steering_prog() Akihiko Odaki
2023-12-10 5:29 ` [PATCH v8 19/19] ebpf: Add a separate target for skeleton Akihiko Odaki
2023-12-11 11:54 ` [PATCH v8 00/19] virtio-net RSS/hash report fixes and improvements Yuri Benditovich
2023-12-11 12:01 ` Akihiko Odaki
2023-12-11 12:34 ` Yuri Benditovich
2023-12-11 15:43 ` Michael S. Tsirkin
2023-12-11 19:51 ` Yuri Benditovich
2023-12-11 19:52 ` Yuri Benditovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231210-rss-v8-0-9553ee714d38@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=chen.zhang@intel.com \
--cc=dmitry.fleytman@gmail.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=sriram.yagnaraman@est.tech \
--cc=v.maffione@gmail.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).