From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Paul Durrant" <paul@xen.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Peter Xu" <peterx@redhat.com>,
"Hyman Huang" <yong.huang@smartx.com>,
"Fam Zheng" <fam@euphon.net>, "Song Gao" <gaosong@loongson.cn>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Leonardo Bras" <leobras@redhat.com>,
"Jiri Slaby" <jslaby@suse.cz>,
"Eric Farman" <farman@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Cameron Esfahani" <dirty@apple.com>,
qemu-ppc@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Weiwei Li" <liwei1518@gmail.com>,
"Hanna Reitz" <hreitz@redhat.com>,
qemu-s390x@nongnu.org, qemu-block@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-riscv@nongnu.org,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Stafford Horne" <shorne@gmail.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Juan Quintela" <quintela@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-arm@nongnu.org, "Jason Wang" <jasowang@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Eric Blake" <eblake@redhat.com>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
xen-devel@lists.xenproject.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 0/5] Make Big QEMU Lock naming consistent
Date: Tue, 12 Dec 2023 10:38:59 -0500 [thread overview]
Message-ID: <20231212153905.631119-1-stefanha@redhat.com> (raw)
v2:
- Rename APIs bql_*() [PeterX]
- Spell out "Big QEMU Lock (BQL)" in doc comments [PeterX]
- Rename "iolock" variables in hw/remote/mpqemu-link.c [Harsh]
- Fix bql_auto_lock() indentation in Patch 2 [Ilya]
- "with BQL taken" -> "with the BQL taken" [Philippe]
- "under BQL" -> "under the BQL" [Philippe]
The Big QEMU Lock ("BQL") has two other names: "iothread lock" and "QEMU global
mutex". The term "iothread lock" is easily confused with the unrelated --object
iothread (iothread.c).
This series updates the code and documentation to consistently use "BQL". This
makes the code easier to understand.
Stefan Hajnoczi (5):
system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()
qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to BQL_LOCK_GUARD
qemu/main-loop: rename qemu_cond_wait_iothread() to
qemu_cond_wait_bql()
Replace "iothread lock" with "BQL" in comments
Rename "QEMU global mutex" to "BQL" in comments and docs
docs/devel/multi-thread-tcg.rst | 7 +-
docs/devel/qapi-code-gen.rst | 2 +-
docs/devel/replay.rst | 2 +-
docs/devel/reset.rst | 2 +-
docs/devel/multiple-iothreads.txt | 16 ++--
hw/display/qxl.h | 2 +-
include/block/aio-wait.h | 2 +-
include/block/blockjob.h | 6 +-
include/exec/cpu-common.h | 2 +-
include/exec/memory.h | 4 +-
include/exec/ramblock.h | 2 +-
include/io/task.h | 2 +-
include/migration/register.h | 8 +-
include/qemu/coroutine-core.h | 2 +-
include/qemu/coroutine.h | 2 +-
include/qemu/main-loop.h | 69 ++++++++--------
include/qemu/thread.h | 2 +-
target/arm/internals.h | 4 +-
accel/accel-blocker.c | 10 +--
accel/dummy-cpus.c | 8 +-
accel/hvf/hvf-accel-ops.c | 4 +-
accel/kvm/kvm-accel-ops.c | 4 +-
accel/kvm/kvm-all.c | 22 ++---
accel/tcg/cpu-exec.c | 26 +++---
accel/tcg/cputlb.c | 20 ++---
accel/tcg/tcg-accel-ops-icount.c | 6 +-
accel/tcg/tcg-accel-ops-mttcg.c | 12 +--
accel/tcg/tcg-accel-ops-rr.c | 18 ++--
accel/tcg/tcg-accel-ops.c | 2 +-
accel/tcg/translate-all.c | 2 +-
cpu-common.c | 4 +-
dump/dump.c | 4 +-
hw/block/dataplane/virtio-blk.c | 8 +-
hw/block/virtio-blk.c | 2 +-
hw/core/cpu-common.c | 6 +-
hw/display/virtio-gpu.c | 2 +-
hw/i386/intel_iommu.c | 6 +-
hw/i386/kvm/xen_evtchn.c | 30 +++----
hw/i386/kvm/xen_gnttab.c | 2 +-
hw/i386/kvm/xen_overlay.c | 2 +-
hw/i386/kvm/xen_xenstore.c | 2 +-
hw/intc/arm_gicv3_cpuif.c | 2 +-
hw/intc/s390_flic.c | 18 ++--
hw/mips/mips_int.c | 2 +-
hw/misc/edu.c | 4 +-
hw/misc/imx6_src.c | 2 +-
hw/misc/imx7_src.c | 2 +-
hw/net/xen_nic.c | 8 +-
hw/ppc/pegasos2.c | 2 +-
hw/ppc/ppc.c | 6 +-
hw/ppc/spapr.c | 2 +-
hw/ppc/spapr_events.c | 2 +-
hw/ppc/spapr_rng.c | 4 +-
hw/ppc/spapr_softmmu.c | 4 +-
hw/remote/mpqemu-link.c | 22 ++---
hw/remote/vfio-user-obj.c | 2 +-
hw/s390x/s390-skeys.c | 2 +-
hw/scsi/virtio-scsi-dataplane.c | 6 +-
migration/block-dirty-bitmap.c | 14 ++--
migration/block.c | 40 ++++-----
migration/colo.c | 62 +++++++-------
migration/dirtyrate.c | 12 +--
migration/migration.c | 54 ++++++------
migration/ram.c | 16 ++--
net/tap.c | 2 +-
replay/replay-internal.c | 2 +-
semihosting/console.c | 8 +-
stubs/iothread-lock.c | 6 +-
system/cpu-throttle.c | 6 +-
system/cpus.c | 55 +++++++------
system/dirtylimit.c | 4 +-
system/memory.c | 2 +-
system/physmem.c | 14 ++--
system/runstate.c | 2 +-
system/watchpoint.c | 4 +-
target/arm/arm-powerctl.c | 14 ++--
target/arm/helper.c | 6 +-
target/arm/hvf/hvf.c | 8 +-
target/arm/kvm.c | 4 +-
target/arm/kvm64.c | 4 +-
target/arm/ptw.c | 6 +-
target/arm/tcg/helper-a64.c | 8 +-
target/arm/tcg/m_helper.c | 6 +-
target/arm/tcg/op_helper.c | 24 +++---
target/arm/tcg/psci.c | 2 +-
target/hppa/int_helper.c | 8 +-
target/i386/hvf/hvf.c | 6 +-
target/i386/kvm/hyperv.c | 4 +-
target/i386/kvm/kvm.c | 28 +++----
target/i386/kvm/xen-emu.c | 16 ++--
target/i386/nvmm/nvmm-accel-ops.c | 6 +-
target/i386/nvmm/nvmm-all.c | 20 ++---
target/i386/tcg/sysemu/fpu_helper.c | 6 +-
target/i386/tcg/sysemu/misc_helper.c | 4 +-
target/i386/whpx/whpx-accel-ops.c | 6 +-
target/i386/whpx/whpx-all.c | 24 +++---
target/loongarch/csr_helper.c | 4 +-
target/mips/kvm.c | 4 +-
target/mips/tcg/sysemu/cp0_helper.c | 4 +-
target/openrisc/sys_helper.c | 16 ++--
target/ppc/excp_helper.c | 14 ++--
target/ppc/helper_regs.c | 2 +-
target/ppc/kvm.c | 4 +-
target/ppc/misc_helper.c | 8 +-
target/ppc/timebase_helper.c | 8 +-
target/riscv/cpu_helper.c | 4 +-
target/s390x/kvm/kvm.c | 4 +-
target/s390x/tcg/misc_helper.c | 118 +++++++++++++--------------
target/sparc/int32_helper.c | 2 +-
target/sparc/int64_helper.c | 6 +-
target/sparc/win_helper.c | 20 ++---
target/xtensa/exc_helper.c | 8 +-
ui/spice-core.c | 6 +-
util/async.c | 2 +-
util/main-loop.c | 8 +-
util/qsp.c | 6 +-
util/rcu.c | 16 ++--
audio/coreaudio.m | 8 +-
memory_ldst.c.inc | 18 ++--
target/i386/hvf/README.md | 2 +-
ui/cocoa.m | 56 ++++++-------
121 files changed, 644 insertions(+), 645 deletions(-)
--
2.43.0
next reply other threads:[~2023-12-12 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 15:38 Stefan Hajnoczi [this message]
2023-12-12 15:39 ` [PATCH v2 1/5] system/cpus: rename qemu_mutex_lock_iothread() to bql_lock() Stefan Hajnoczi
2023-12-13 1:34 ` Yong Huang
2023-12-13 6:37 ` Akihiko Odaki
2024-01-02 15:33 ` Stefan Hajnoczi
2024-01-02 21:37 ` Bernhard Beschow
2023-12-12 15:39 ` [PATCH v2 2/5] qemu/main-loop: rename QEMU_IOTHREAD_LOCK_GUARD to BQL_LOCK_GUARD Stefan Hajnoczi
2023-12-12 15:39 ` [PATCH v2 3/5] qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql() Stefan Hajnoczi
2023-12-12 15:39 ` [PATCH v2 4/5] Replace "iothread lock" with "BQL" in comments Stefan Hajnoczi
2023-12-12 15:39 ` [PATCH v2 5/5] Rename "QEMU global mutex" to "BQL" in comments and docs Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212153905.631119-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=agraf@csgraf.de \
--cc=akihiko.odaki@daynix.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=andrew.smirnov@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dirty@apple.com \
--cc=dwmw2@infradead.org \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=gaosong@loongson.cn \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jag.raman@oracle.com \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jslaby@suse.cz \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=liwei1518@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=rbolshakov@ddn.com \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=shorne@gmail.com \
--cc=sstabellini@kernel.org \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=xen-devel@lists.xenproject.org \
--cc=yong.huang@smartx.com \
--cc=zhanghailiang@xfusion.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).