From: Thomas Huth <huth@tuxfamily.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 02/12] next-cube.c: don't pulse SCSI DMA IRQ upon reception of FLUSH command
Date: Sat, 16 Dec 2023 10:07:42 +0100 [thread overview]
Message-ID: <20231216100742.0de18a1d@fedora> (raw)
In-Reply-To: <20231215200009.346212-3-mark.cave-ayland@ilande.co.uk>
Am Fri, 15 Dec 2023 19:59:59 +0000
schrieb Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>:
> Normally a DMA FLUSH command is used to ensure that data is completely written
> to the device and/or memory, so remove the pulse of the SCSI DMA IRQ if a DMA
> FLUSH command is received. This enables the NeXT ROM monitor to start to load
> from a SCSI disk.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/m68k/next-cube.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
> index feeda23475..87ddaf4329 100644
> --- a/hw/m68k/next-cube.c
> +++ b/hw/m68k/next-cube.c
> @@ -473,7 +473,6 @@ static void scr_writeb(NeXTPC *s, hwaddr addr, uint32_t value)
> DPRINTF("SCSICSR FIFO Flush\n");
> /* will have to add another irq to the esp if this is needed */
> /* esp_puflush_fifo(esp_g); */
> - qemu_irq_pulse(s->scsi_dma);
> }
>
> if (value & SCSICSR_ENABLE) {
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
next prev parent reply other threads:[~2023-12-16 9:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 19:59 [PATCH 00/12] next-cube: various tidy-ups and improvements Mark Cave-Ayland
2023-12-15 19:59 ` [PATCH 01/12] next-cube.c: add dummy Ethernet register to allow diagnostic to timeout Mark Cave-Ayland
2023-12-16 9:00 ` Thomas Huth
2023-12-15 19:59 ` [PATCH 02/12] next-cube.c: don't pulse SCSI DMA IRQ upon reception of FLUSH command Mark Cave-Ayland
2023-12-16 9:07 ` Thomas Huth [this message]
2023-12-15 20:00 ` [PATCH 03/12] next-cube.c: update mmio_ops to properly use modern memory API Mark Cave-Ayland
2023-12-16 19:25 ` Thomas Huth
2023-12-15 20:00 ` [PATCH 04/12] next-cube.c: update scr_ops " Mark Cave-Ayland
2023-12-16 19:51 ` Thomas Huth
2023-12-15 20:00 ` [PATCH 05/12] next-cube.c: update and improve dma_ops Mark Cave-Ayland
2023-12-16 19:55 ` Thomas Huth
2023-12-15 20:00 ` [PATCH 06/12] next-cube.c: move static led variable to NeXTPC Mark Cave-Ayland
2023-12-16 19:57 ` Thomas Huth
2023-12-15 20:00 ` [PATCH 07/12] next-cube.c: move static phase variable to NextRtc Mark Cave-Ayland
2023-12-16 20:08 ` Thomas Huth
2023-12-15 20:00 ` [PATCH 08/12] next-cube.c: move LED logic to new next_scr2_led_update() function Mark Cave-Ayland
2023-12-16 20:13 ` Thomas Huth
2023-12-19 21:40 ` Mark Cave-Ayland
2023-12-15 20:00 ` [PATCH 09/12] next-cube.c: move static old_scr2 variable to NeXTPC Mark Cave-Ayland
2023-12-16 20:18 ` Thomas Huth
2023-12-19 21:41 ` Mark Cave-Ayland
2023-12-15 20:00 ` [PATCH 10/12] next-cube.c: remove val and size arguments from nextscr2_write() Mark Cave-Ayland
2023-12-15 20:00 ` [PATCH 11/12] next-cube.c: replace sysmem with get_system_memory() in next_cube_init() Mark Cave-Ayland
2023-12-16 20:20 ` Thomas Huth
2023-12-16 21:31 ` BALATON Zoltan
2023-12-19 22:02 ` Mark Cave-Ayland
2023-12-19 21:43 ` Mark Cave-Ayland
2023-12-15 20:00 ` [PATCH 12/12] next-cube.c: move machine MemoryRegions into NeXTState Mark Cave-Ayland
2023-12-16 20:21 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231216100742.0de18a1d@fedora \
--to=huth@tuxfamily.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).