From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "John Snow" <jsnow@redhat.com>,
qemu-block@nongnu.org, "Thomas Huth" <huth@tuxfamily.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"David Hildenbrand" <david@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Kevin Wolf" <kwolf@redhat.com>, "Peter Xu" <peterx@redhat.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Sergio Lopez" <slp@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Hanna Reitz" <hreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Juan Quintela" <quintela@redhat.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>,
qemu-ppc@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH 02/12] hw/i386/pc: No need to include hw/block/fdc.h in header
Date: Sun, 17 Dec 2023 15:41:38 +0100 [thread overview]
Message-ID: <20231217144148.15511-3-shentey@gmail.com> (raw)
In-Reply-To: <20231217144148.15511-1-shentey@gmail.com>
Only the source file uses fdc.h but not the header, so remove it from the public
interface.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
include/hw/i386/pc.h | 1 -
hw/i386/pc.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index a10ceeabbf..48097c9124 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -5,7 +5,6 @@
#include "qapi/qapi-types-common.h"
#include "qemu/uuid.h"
#include "hw/boards.h"
-#include "hw/block/fdc.h"
#include "hw/block/flash.h"
#include "hw/i386/x86.h"
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 29b9964733..0d732b7530 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -25,6 +25,7 @@
#include "qemu/osdep.h"
#include "qemu/units.h"
#include "hw/i386/pc.h"
+#include "hw/block/fdc.h"
#include "hw/char/serial.h"
#include "hw/char/parallel.h"
#include "hw/hyperv/hv-balloon.h"
--
2.43.0
next prev parent reply other threads:[~2023-12-17 14:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 14:41 [PATCH 00/12] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions Bernhard Beschow
2023-12-17 14:41 ` [PATCH 01/12] hw: Remove unused includes of hw/block/fdc.h Bernhard Beschow
2023-12-17 14:41 ` Bernhard Beschow [this message]
2023-12-17 14:41 ` [PATCH 03/12] hw/block/fdc-isa: Rename header to match source file Bernhard Beschow
2023-12-17 14:41 ` [PATCH 04/12] hw/block/fdc: Expose internal header Bernhard Beschow
2023-12-17 15:47 ` BALATON Zoltan
2023-12-17 23:39 ` Bernhard Beschow
2023-12-18 10:54 ` BALATON Zoltan
2023-12-18 18:53 ` Bernhard Beschow
2023-12-18 23:44 ` BALATON Zoltan
2023-12-17 14:41 ` [PATCH 05/12] hw/block/fdc: Move constant #define to where it is imposed Bernhard Beschow
2023-12-17 14:41 ` [PATCH 06/12] hw/block/fdc-isa: Expose struct FDCtrlISABus Bernhard Beschow
2023-12-17 14:41 ` [PATCH 07/12] MAINTAINERS: Add include/hw/char/serial*.h to the "PC Chipset" section Bernhard Beschow
2023-12-17 14:41 ` [PATCH 08/12] hw/char/serial-isa: Export struct ISASerialState Bernhard Beschow
2023-12-17 14:41 ` [PATCH 09/12] exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio Bernhard Beschow
2023-12-17 14:41 ` [PATCH 10/12] exec/ioport: Add portio_list_set_address() Bernhard Beschow
2023-12-17 14:41 ` [PATCH 11/12] exec/ioport: Add portio_list_set_enabled() Bernhard Beschow
2023-12-17 14:41 ` [PATCH 12/12] hw/isa/vt82c686: Implement relocation of SuperI/O functions Bernhard Beschow
2023-12-17 15:40 ` BALATON Zoltan
2023-12-17 23:47 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217144148.15511-3-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=atar4qemu@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=fbarrat@linux.ibm.com \
--cc=hpoussin@reactos.org \
--cc=hreitz@redhat.com \
--cc=huth@tuxfamily.org \
--cc=jiaxun.yang@flygoat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).