From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: [PULL 17/19] tests/unit/test-qmp-event: Drop superfluous mutex
Date: Wed, 20 Dec 2023 10:41:03 +0100	[thread overview]
Message-ID: <20231220094105.6588-18-thuth@redhat.com> (raw)
In-Reply-To: <20231220094105.6588-1-thuth@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Mutex @test_event_lock is held from fixture setup to teardown,
protecting global variable @test_event_data.  But tests always run one
after the other, so this is superfluous.  It also confuses Coverity.
Drop the mutex.
Fixes: CID 1527425
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231122072456.2518816-2-armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/unit/test-qmp-event.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/tests/unit/test-qmp-event.c b/tests/unit/test-qmp-event.c
index 3626d2372f..c2c44687d5 100644
--- a/tests/unit/test-qmp-event.c
+++ b/tests/unit/test-qmp-event.c
@@ -30,7 +30,6 @@ typedef struct TestEventData {
 } TestEventData;
 
 TestEventData *test_event_data;
-static GMutex test_event_lock;
 
 void test_qapi_event_emit(test_QAPIEvent event, QDict *d)
 {
@@ -59,9 +58,6 @@ void test_qapi_event_emit(test_QAPIEvent event, QDict *d)
 static void event_prepare(TestEventData *data,
                           const void *unused)
 {
-    /* Global variable test_event_data was used to pass the expectation, so
-       test cases can't be executed at same time. */
-    g_mutex_lock(&test_event_lock);
     test_event_data = data;
 }
 
@@ -69,7 +65,6 @@ static void event_teardown(TestEventData *data,
                            const void *unused)
 {
     test_event_data = NULL;
-    g_mutex_unlock(&test_event_lock);
 }
 
 static void event_test_add(const char *testpath,
-- 
2.43.0
next prev parent reply	other threads:[~2023-12-20  9:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20  9:40 [PULL 00/19] First batch of misc patches for QEMU 9.0 Thomas Huth
2023-12-20  9:40 ` [PULL 01/19] hw: Add compat machines for 9.0 Thomas Huth
2023-12-20  9:40 ` [PULL 02/19] MAINTAINERS: Add some more vmware-related files to the corresponding section Thomas Huth
2023-12-20  9:40 ` [PULL 03/19] system/qtest: Include missing 'hw/core/cpu.h' header Thomas Huth
2023-12-20  9:40 ` [PULL 04/19] system/qtest: Restrict QTest API to system emulation Thomas Huth
2023-12-20  9:40 ` [PULL 05/19] hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header Thomas Huth
2023-12-20  9:40 ` [PULL 06/19] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header Thomas Huth
2023-12-20  9:40 ` [PULL 07/19] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header Thomas Huth
2023-12-20  9:40 ` [PULL 08/19] target: Restrict 'sysemu/reset.h' to system emulation Thomas Huth
2023-12-20  9:40 ` [PULL 09/19] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl" Thomas Huth
2023-12-20  9:40 ` [PULL 10/19] hw: Replace anti-social QOM type names (again) Thomas Huth
2023-12-20  9:40 ` [PULL 11/19] memory: Remove "qemu:" prefix from the "qemu:ram-discard-manager" type name Thomas Huth
2023-12-20  9:40 ` [PULL 12/19] tests/unit/test-io-task: Rename "qemu:dummy" to avoid colon in the name Thomas Huth
2023-12-20  9:40 ` [PULL 13/19] qom/object: Limit type names to alphanumerical and some few special characters Thomas Huth
2023-12-20  9:41 ` [PULL 14/19] tests/qtest/migration-test: Fix analyze-migration.py for s390x Thomas Huth
2023-12-20  9:41 ` [PULL 15/19] qemu-options: Clarify handling of commas in options parameters Thomas Huth
2023-12-20  9:41 ` [PULL 16/19] tests/qtest/npcm7xx_pwm-test: Only do full testing in slow mode Thomas Huth
2023-12-20  9:41 ` Thomas Huth [this message]
2023-12-20  9:41 ` [PULL 18/19] tests/unit/test-qmp-event: Simplify event emission check Thomas Huth
2023-12-20  9:41 ` [PULL 19/19] tests/unit/test-qmp-event: Replace fixture by global variables Thomas Huth
2023-12-20 16:03 ` [PULL 00/19] First batch of misc patches for QEMU 9.0 Stefan Hajnoczi
2023-12-20 23:11   ` Alex Bennée
2023-12-21  0:09     ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20231220094105.6588-18-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).