From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Leonardo Bras <leobras@redhat.com>,
qemu-block@nongnu.org, Fam Zheng <fam@euphon.net>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Fabiano Rosas <farosas@suse.de>, Eric Blake <eblake@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 6/6] nbd/server: introduce NBDClient->lock to protect fields
Date: Thu, 21 Dec 2023 06:56:11 -0500 [thread overview]
Message-ID: <20231221115611.GA1578764@fedora> (raw)
In-Reply-To: <da5f4630-b09b-49d0-9457-4fc71d43a682@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Thu, Dec 21, 2023 at 08:26:58AM +0100, Paolo Bonzini wrote:
> On 12/21/23 02:49, Stefan Hajnoczi wrote:
> > nbd_client_receive_next_request(client);
> > +
> > + qemu_mutex_unlock(&client->lock);
> > +
> > if (ret == -EIO) {
> > goto disconnect;
> > }
>
> I think I slightly prefer if disconnect is reached with lock taken, for
> consistency with the "done" label. It does not complicate the code,
> because you can just move qio_channel_set_cork() and replace:
Yes, that makes the code easier to follow. Will fix in v2.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-12-21 11:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 1:48 [PATCH 0/6] qemu-iotests fixes for Kevin's block tree Stefan Hajnoczi
2023-12-21 1:48 ` [PATCH 1/6] fixup block-coroutine-wrapper: use qemu_get_current_aio_context() Stefan Hajnoczi
2023-12-21 1:48 ` [PATCH 2/6] fixup block: remove AioContext locking Stefan Hajnoczi
2023-12-21 1:49 ` [PATCH 3/6] fixup scsi: only access SCSIDevice->requests from one thread Stefan Hajnoczi
2023-12-21 7:29 ` Paolo Bonzini
2023-12-21 1:49 ` [PATCH 4/6] nbd/server: avoid per-NBDRequest nbd_client_get/put() Stefan Hajnoczi
2023-12-21 7:27 ` Paolo Bonzini
2023-12-21 1:49 ` [PATCH 5/6] nbd/server: only traverse NBDExport->clients from main loop thread Stefan Hajnoczi
2023-12-21 7:23 ` Paolo Bonzini
2023-12-21 14:27 ` Stefan Hajnoczi
2024-01-02 15:32 ` Eric Blake
2023-12-21 1:49 ` [PATCH 6/6] nbd/server: introduce NBDClient->lock to protect fields Stefan Hajnoczi
2023-12-21 7:26 ` Paolo Bonzini
2023-12-21 11:56 ` Stefan Hajnoczi [this message]
2023-12-21 10:45 ` Kevin Wolf
2023-12-21 14:14 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221115611.GA1578764@fedora \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).