From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD7A3C35274 for ; Thu, 21 Dec 2023 15:48:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGLHD-0004XV-Oq; Thu, 21 Dec 2023 10:47:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGLH7-0004X5-5y for qemu-devel@nongnu.org; Thu, 21 Dec 2023 10:47:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGLH4-00013g-PP for qemu-devel@nongnu.org; Thu, 21 Dec 2023 10:47:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703173669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AWMPIrR/6nIccvBOle12qEJfCLazPZquf9BKJkqWcxc=; b=KJaXIvjgYENl5LFddd03VF+uTbQOV2T2wp8iFqwrftaUfUpkP2ELApLoXByELhLpPDUr2P ceWsuVGlTd2LS7kfcEbzImrFP2x00LjwPH1AU6/danxNEYnB+cFwLOQm136VaSA2wS8Q91 UZkbU0ArgaYEjmuTQHRGbf1nnWN815U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-Smngvow7MnWVticM9hNBIQ-1; Thu, 21 Dec 2023 10:47:46 -0500 X-MC-Unique: Smngvow7MnWVticM9hNBIQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC5DF83BA86; Thu, 21 Dec 2023 15:47:45 +0000 (UTC) Received: from localhost (unknown [10.39.194.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F67C40C6EB9; Thu, 21 Dec 2023 15:47:45 +0000 (UTC) Date: Thu, 21 Dec 2023 10:47:43 -0500 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-devel@nongnu.org, Michal Privoznik , Hanna Reitz , qemu-block@nongnu.org, "Michael S. Tsirkin" , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Michael Roth , Eduardo Habkost , Eric Blake , Markus Armbruster , Paolo Bonzini Subject: Re: [PATCH v4 1/4] qdev-properties: alias all object class properties Message-ID: <20231221154743.GA1754997@fedora> References: <20231220134755.814917-1-stefanha@redhat.com> <20231220134755.814917-2-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SQsE9g+xhDgz8VZu" Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.061, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --SQsE9g+xhDgz8VZu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 21, 2023 at 01:39:48PM +0100, Kevin Wolf wrote: > Am 20.12.2023 um 14:47 hat Stefan Hajnoczi geschrieben: > > qdev_alias_all_properties() aliases a DeviceState's qdev properties onto > > an Object. This is used for VirtioPCIProxy types so that --device > > virtio-blk-pci has properties of its embedded --device virtio-blk-device > > object. > >=20 > > Currently this function is implemented using qdev properties. Change the > > function to use QOM object class properties instead. This works because > > qdev properties create QOM object class properties, but it also catches > > any QOM object class-only properties that have no qdev properties. > >=20 > > This change ensures that properties of devices are shown with --device > > foo,\? even if they are QOM object class properties. > >=20 > > Signed-off-by: Stefan Hajnoczi >=20 > Reviewed-by: Kevin Wolf >=20 > We should also update the comment to refer to properties in general > rather than just qdev properties. I can squash in the following hunk. Please go ahead. Thank you! Stefan > diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h > index 25743a29a0..09aa04ca1e 100644 > --- a/include/hw/qdev-properties.h > +++ b/include/hw/qdev-properties.h > @@ -230,8 +230,8 @@ void qdev_property_add_static(DeviceState *dev, Prope= rty *prop); > * @target: Device which has properties to be aliased > * @source: Object to add alias properties to > * > - * Add alias properties to the @source object for all qdev properties on > - * the @target DeviceState. > + * Add alias properties to the @source object for all properties on the = @target > + * DeviceState. > * > * This is useful when @target is an internal implementation object > * owned by @source, and you want to expose all the properties of that >=20 --SQsE9g+xhDgz8VZu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmWEXh8ACgkQnKSrs4Gr c8jLVggAsf77uJ0b94YoH0EDMmsQMh89dMISXHs7ZGw13plTELDOTCXeonbVXxE1 GpwVwsxQwa+U1SwnOrzr207Ttxw4yxEAJDl5TSNUa/fFx3IhVynR2bltNEp5h874 8rJJfQTGqGM+zR1TJYHxyyQm3XKM331i0SimGIVltvbg5L16JsvToQDPLQLNGbWR AzaD/lCsW+yeKF0dLkC67W52iitO5vJRb0/Ho6pGfp4c+6YPorgfTHbfwoIcj4sR BNaNBpIkFWZoHNXtepH9y1hkLevLtFktkh32jfi9+8SBwBn90LO56lg0tkRMKTVd e8RqMNeuNyZYIFTqzDW3U9muoeuuCA== =bKTf -----END PGP SIGNATURE----- --SQsE9g+xhDgz8VZu--