From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3613BC35274 for ; Thu, 21 Dec 2023 17:43:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGN56-0001zC-6Q; Thu, 21 Dec 2023 12:43:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGN51-0001yS-CQ for qemu-devel@nongnu.org; Thu, 21 Dec 2023 12:43:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGN4z-0004Ll-JB for qemu-devel@nongnu.org; Thu, 21 Dec 2023 12:43:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703180608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wq93ywKzzt9qHkacvkFoeQJ+KNnlOUGXehbS0CEIyLo=; b=EchdVcx0BYPGtXonY7D2W6P1cAnQ4IR6mPRHh48klGNdwL22C5ahBAA407MzWhOGcSK7Yj vkanJDW4p+UTuQdsKykmPP368jCRoXHSNLBz9qSHJvJa3RpDiyUqUc8GnBaWegDuQ0sYAd AKoRIKl+9Bcq/gOjnYz85Cgrix4K7Sk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-iREC8SG9PCyVZNETmfWKyg-1; Thu, 21 Dec 2023 12:43:26 -0500 X-MC-Unique: iREC8SG9PCyVZNETmfWKyg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A56F85A58A; Thu, 21 Dec 2023 17:43:26 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89C8C492BC6; Thu, 21 Dec 2023 17:43:24 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Cc: Dragos Tatulea , Zhu Lingshan , Parav Pandit , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , si-wei.liu@oracle.com, Laurent Vivier , Lei Yang Subject: [PATCH v4 00/13] Consolidate common vdpa members in VhostVDPAShared Date: Thu, 21 Dec 2023 18:43:09 +0100 Message-Id: <20231221174322.3130442-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.061, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Current memory operations like pinning may take a lot of time at the=0D destination. Currently they are done after the source of the migration is= =0D stopped, and before the workload is resumed at the destination. This is a= =0D period where neigher traffic can flow, nor the VM workload can continue=0D (downtime).=0D =0D We can do better as we know the memory layout of the guest RAM at the=0D destination from the moment the migration starts. Moving that operation al= lows=0D QEMU to communicate the kernel the maps while the workload is still running= in=0D the source, so Linux can start mapping them. Ideally, all IOMMU is configu= red,=0D but if the vDPA parent driver uses on-chip IOMMU and .set_map we're still=0D saving all the pinning time.=0D =0D This is a first required step to consolidate all the members in a common=0D struct. This is needed because the destination does not know what vhost_vd= pa=0D struct will have the registered listener member, so it is easier to place t= hem=0D in a shared struct rather to keep them in vhost_vdpa struct.=0D =0D v4:=0D * Actually fix the SIGSEGV, unregistering shared->listener in devices=0D with vq_index > 1 while shared has been freed in net/vhost-vdpa.c=0D freeing the device with vq_index =3D=3D 0. Keeping the free in 0 as fd is= =0D closed at index 0.=0D =0D v3:=0D * Cherry-pick Si-Wei's fixes.=0D * Only memory_listener_unregister at vhost_vdpa_cleanup in the last dev.=0D SIGSEGV detected by both Lei Yang [1] and Si-Wei [2].=0D =0D v2:=0D * Avoid repeated setting shared->shadow_data by squashing Si-Wei's patch=0D [2].=0D =0D v1 from RFC:=0D * Fix vhost_vdpa_net_cvq_start checking for always_svq instead of=0D shadow_data. This could cause CVQ not being shadowed if=0D vhost_vdpa_net_cvq_start was called in the middle of a migration.=0D =0D [1] https://patchwork.kernel.org/project/qemu-devel/cover/20231124171430.29= 64464-1-eperezma@redhat.com/=0D [2] https://patchwork.kernel.org/project/qemu-devel/patch/1701970793-6865-1= 0-git-send-email-si-wei.liu@oracle.com/=0D =0D Eugenio P=C3=A9rez (13):=0D vdpa: add VhostVDPAShared=0D vdpa: move iova tree to the shared struct=0D vdpa: move iova_range to vhost_vdpa_shared=0D vdpa: move shadow_data to vhost_vdpa_shared=0D vdpa: use vdpa shared for tracing=0D vdpa: move file descriptor to vhost_vdpa_shared=0D vdpa: move iotlb_batch_begin_sent to vhost_vdpa_shared=0D vdpa: move backend_cap to vhost_vdpa_shared=0D vdpa: remove msg type of vhost_vdpa=0D vdpa: move iommu_list to vhost_vdpa_shared=0D vdpa: use VhostVDPAShared in vdpa_dma_map and unmap=0D vdpa: use dev_shared in vdpa_iommu=0D vdpa: move memory listener to vhost_vdpa_shared=0D =0D include/hw/virtio/vhost-vdpa.h | 36 +++++---=0D hw/virtio/vdpa-dev.c | 7 +-=0D hw/virtio/vhost-vdpa.c | 160 +++++++++++++++++----------------=0D net/vhost-vdpa.c | 116 ++++++++++++------------=0D hw/virtio/trace-events | 14 +--=0D 5 files changed, 173 insertions(+), 160 deletions(-)=0D =0D -- =0D 2.39.3=0D =0D