From: "Michael S. Tsirkin" <mst@redhat.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v3 0/4] virtio: Refactor vhost input stub
Date: Mon, 25 Dec 2023 11:06:35 -0500 [thread overview]
Message-ID: <20231225110608-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20231120043721.50555-1-leo.yan@linaro.org>
On Mon, Nov 20, 2023 at 12:37:17PM +0800, Leo Yan wrote:
> This series is to refactor vhost stub vhost-user-input.
>
> Since vhost input stub requires set_config() callback for communication
> event configurations between the backend and the guest, patch 01 is a
> preparison for support set_config() callback in vhost-user-base.
>
> The patch 02 is to add documentation for vhost-user-input.
>
> The patch 03 is to move virtio input stub from the input folder to the
> virtio folder.
Thanks!
Now the release is out I'd like to apply this - can you please rebase on latest master and
repost?
> The patch 04 derives vhost-user-input from vhost-user-base. We reuse
> the common code from vhhost-user-base as possible and the input stub is
> simplized significantly.
>
> This patch set has been tested with the backend daemon:
>
> # ./build/contrib/vhost-user-input/vhost-user-input \
> -p /dev/input/event20 -s /tmp/input.sock
>
> The series is based on "[PATCH v8 0/7] virtio: cleanup
> vhost-user-generic and reduce c&p" which introduces vhost-user-base.
> Based-on: <20231107180752.3458672-1-alex.bennee@linaro.org>
>
> Changes from v2:
> - Created reference for shared memory object and updated
> vhost-user-input.rst respectively. (Marc-André)
>
> Changes from v1:
> - Fixed typo in vhost-user-input.rst.
> - Updated MAINTAINERS for new added input document and
> changing folder for vhost-user-input.c. (Manos)
>
>
> Leo Yan (4):
> hw/virtio: Support set_config() callback in vhost-user-base
> docs/system: Add vhost-user-input documentation
> hw/virtio: Move vhost-user-input into virtio folder
> hw/virtio: derive vhost-user-input from vhost-user-base
>
> MAINTAINERS | 3 +-
> docs/system/device-emulation.rst | 1 +
> docs/system/devices/vhost-user-input.rst | 45 ++++++++
> docs/system/devices/vhost-user.rst | 4 +-
> hw/input/meson.build | 1 -
> hw/input/vhost-user-input.c | 136 -----------------------
> hw/virtio/meson.build | 4 +-
> hw/virtio/vhost-user-base.c | 17 +++
> hw/virtio/vhost-user-input-pci.c | 3 -
> hw/virtio/vhost-user-input.c | 58 ++++++++++
> include/hw/virtio/virtio-input.h | 6 +-
> 11 files changed, 132 insertions(+), 146 deletions(-)
> create mode 100644 docs/system/devices/vhost-user-input.rst
> delete mode 100644 hw/input/vhost-user-input.c
> create mode 100644 hw/virtio/vhost-user-input.c
>
> --
> 2.39.2
next prev parent reply other threads:[~2023-12-25 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 4:37 [PATCH v3 0/4] virtio: Refactor vhost input stub Leo Yan
2023-11-20 4:37 ` [PATCH v3 1/4] hw/virtio: Support set_config() callback in vhost-user-base Leo Yan
2023-11-20 4:37 ` [PATCH v3 2/4] docs/system: Add vhost-user-input documentation Leo Yan
2023-11-20 4:37 ` [PATCH v3 3/4] hw/virtio: Move vhost-user-input into virtio folder Leo Yan
2023-11-20 5:17 ` Manos Pitsidianakis
2023-11-20 4:37 ` [PATCH v3 4/4] hw/virtio: derive vhost-user-input from vhost-user-base Leo Yan
2023-11-20 5:20 ` Manos Pitsidianakis
2023-11-20 9:20 ` [PATCH v3 0/4] virtio: Refactor vhost input stub Michael S. Tsirkin
2023-12-25 16:06 ` Michael S. Tsirkin [this message]
2023-12-29 9:01 ` Leo Yan
2024-01-03 13:25 ` Alex Bennée
2024-01-04 12:34 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231225110608-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kraxel@redhat.com \
--cc=leo.yan@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).