qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH v4 10/21] parallels: Create used bitmap even if checks needed
Date: Thu, 28 Dec 2023 11:12:21 +0100	[thread overview]
Message-ID: <20231228101232.372142-11-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20231228101232.372142-1-alexander.ivanov@virtuozzo.com>

All the checks were fixed to work with used bitmap. Create used bitmap in
parallels_open() even if need_check is true.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 block/parallels.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index 0ae06ec0b1..f38dd2309c 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1421,13 +1421,11 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
     }
     need_check = need_check || s->data_end > file_nb_sectors;
 
-    if (!need_check) {
-        ret = parallels_fill_used_bitmap(bs);
-        if (ret == -ENOMEM) {
-            goto fail;
-        }
-        need_check = need_check || ret < 0; /* These are correctable errors */
+    ret = parallels_fill_used_bitmap(bs);
+    if (ret == -ENOMEM) {
+        goto fail;
     }
+    need_check = need_check || ret < 0; /* These are correctable errors */
 
     /*
      * We don't repair the image here if it's opened for checks. Also we don't
-- 
2.40.1



  parent reply	other threads:[~2023-12-28 10:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 10:12 [PATCH v4 00/21] parallels: Add full dirty bitmap support Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 01/21] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap() Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 02/21] parallels: Move inactivation code to a separate function Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 03/21] parallels: Make mark_used() a global function Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 04/21] parallels: Limit search in parallels_mark_used to the last marked claster Alexander Ivanov
2024-01-16 13:52   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 05/21] parallels: Add parallels_mark_unused() helper Alexander Ivanov
2024-01-16 13:54   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 06/21] parallels: Move host clusters allocation to a separate function Alexander Ivanov
2024-01-16 14:19   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 07/21] parallels: Set data_end value in parallels_check_leak() Alexander Ivanov
2024-01-16 14:21   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 08/21] parallels: Recreate used bitmap " Alexander Ivanov
2024-01-16 14:24   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 09/21] parallels: Add a note about used bitmap in parallels_check_duplicate() Alexander Ivanov
2024-01-16 14:30   ` Denis V. Lunev
2023-12-28 10:12 ` Alexander Ivanov [this message]
2024-01-16 14:37   ` [PATCH v4 10/21] parallels: Create used bitmap even if checks needed Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 11/21] parallels: Add dirty bitmaps saving Alexander Ivanov
2024-01-18 13:27   ` Denis V. Lunev
2024-02-07 12:42     ` Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 12/21] parallels: Let image extensions work in RW mode Alexander Ivanov
2024-01-16 14:45   ` Denis V. Lunev
2024-01-18 13:31     ` Denis V. Lunev
2024-02-28 10:25       ` Alexander Ivanov
2024-02-28 12:11         ` Denis V. Lunev
2024-01-18 13:35   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 13/21] parallels: Handle L1 entries equal to one Alexander Ivanov
2024-01-18 13:37   ` Denis V. Lunev
2024-02-29 11:57     ` Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 14/21] parallels: Make a loaded dirty bitmap persistent Alexander Ivanov
2024-01-18 13:59   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 15/21] parallels: Reverse a conditional in parallels_check_leak() to reduce indents Alexander Ivanov
2024-01-18 14:49   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 16/21] parallels: Truncate images on the last used cluster Alexander Ivanov
2024-01-18 14:52   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 17/21] parallels: Check unused clusters in parallels_check_leak() Alexander Ivanov
2024-01-18 14:55   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 18/21] parallels: Remove unnecessary data_end field Alexander Ivanov
2024-01-18 15:00   ` Denis V. Lunev
2023-12-28 10:12 ` [PATCH v4 19/21] tests: Add parallels images support to test 165 Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 20/21] tests: Turned on 256, 299, 304 and block-status-cache for parallels format Alexander Ivanov
2023-12-28 10:12 ` [PATCH v4 21/21] tests: Add parallels format support to image-fleecing Alexander Ivanov
2023-12-29 15:59   ` Vladimir Sementsov-Ogievskiy
2024-01-18 15:01 ` [PATCH v4 00/21] parallels: Add full dirty bitmap support Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231228101232.372142-11-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).