qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v3 29/33] linux-user: Allow TARGET_PAGE_BITS_VARY
Date: Tue,  2 Jan 2024 12:58:04 +1100	[thread overview]
Message-ID: <20240102015808.132373-30-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240102015808.132373-1-richard.henderson@linaro.org>

If set, match the host and guest page sizes.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/main.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/linux-user/main.c b/linux-user/main.c
index 9ba4dc5872..d00a0d7d1f 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -55,6 +55,7 @@
 #include "loader.h"
 #include "user-mmap.h"
 #include "accel/tcg/perf.h"
+#include "exec/page-vary.h"
 
 #ifdef CONFIG_SEMIHOSTING
 #include "semihosting/semihost.h"
@@ -683,6 +684,7 @@ int main(int argc, char **argv, char **envp)
     int i;
     int ret;
     int execfd;
+    int host_page_size;
     unsigned long max_reserved_va;
     bool preserve_argv0;
 
@@ -794,6 +796,16 @@ int main(int argc, char **argv, char **envp)
                                  opt_one_insn_per_tb, &error_abort);
         ac->init_machine(NULL);
     }
+
+    /*
+     * Finalize page size before creating CPUs.
+     * This will do nothing if !TARGET_PAGE_BITS_VARY.
+     * The most efficient setting is to match the host.
+     */
+    host_page_size = qemu_real_host_page_size();
+    set_preferred_target_page_bits(ctz32(host_page_size));
+    finalize_target_page_bits();
+
     cpu = cpu_create(cpu_type);
     env = cpu_env(cpu);
     cpu_reset(cpu);
@@ -807,8 +819,6 @@ int main(int argc, char **argv, char **envp)
      */
     max_reserved_va = MAX_RESERVED_VA(cpu);
     if (reserved_va != 0) {
-        int host_page_size = qemu_real_host_page_size();
-
         if ((reserved_va + 1) % host_page_size) {
             char *s = size_to_str(host_page_size);
             fprintf(stderr, "Reserved virtual address not aligned mod %s\n", s);
@@ -907,7 +917,7 @@ int main(int argc, char **argv, char **envp)
      * If we're in a chroot with no /proc, fall back to 1 page.
      */
     if (mmap_min_addr == 0) {
-        mmap_min_addr = qemu_real_host_page_size();
+        mmap_min_addr = host_page_size;
         qemu_log_mask(CPU_LOG_PAGE,
                       "host mmap_min_addr=0x%lx (fallback)\n",
                       mmap_min_addr);
-- 
2.34.1



  parent reply	other threads:[~2024-01-02  1:59 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02  1:57 [PATCH v3 00/33] linux-user: Improve host and guest page size handling Richard Henderson
2024-01-02  1:57 ` [PATCH v3 01/33] accel/tcg: Remove qemu_host_page_size from page_protect/page_unprotect Richard Henderson
2024-01-03 15:28   ` Philippe Mathieu-Daudé
2024-01-29  9:59   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 02/33] linux-user: Adjust SVr4 NULL page mapping Richard Henderson
2024-01-08  8:54   ` Pierrick Bouvier
2024-01-29 10:03   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 03/33] linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base Richard Henderson
2024-01-08  9:35   ` Pierrick Bouvier
2024-01-29 10:15   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 04/33] linux-user: Remove qemu_host_page_size from create_elf_tables Richard Henderson
2024-01-08  8:55   ` Pierrick Bouvier
2024-01-29 10:18   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 05/33] linux-user/hppa: Simplify init_guest_commpage Richard Henderson
2024-01-08  8:56   ` Pierrick Bouvier
2024-01-29 10:28   ` Ilya Leoshkevich
2024-01-29 10:45     ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 06/33] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage Richard Henderson
2024-01-08  9:11   ` Pierrick Bouvier
2024-01-02  1:57 ` [PATCH v3 07/33] linux-user/arm: " Richard Henderson
2024-01-08  9:38   ` Pierrick Bouvier
2024-01-10 22:12     ` Richard Henderson
2024-01-02  1:57 ` [PATCH v3 08/33] linux-user: Remove qemu_host_page_{size, mask} from mmap.c Richard Henderson
2024-01-08  9:47   ` Pierrick Bouvier
2024-01-08 13:25     ` Philippe Mathieu-Daudé
2024-01-29 10:53   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 09/33] linux-user: Remove REAL_HOST_PAGE_ALIGN " Richard Henderson
2024-01-29 10:55   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 10/33] linux-user: Remove HOST_PAGE_ALIGN " Richard Henderson
2024-01-08 10:47   ` Pierrick Bouvier
2024-01-29 10:58   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 11/33] migration: Remove qemu_host_page_size Richard Henderson
2024-01-08 10:48   ` Pierrick Bouvier
2024-01-29 10:58   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 12/33] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init Richard Henderson
2024-01-02 19:12   ` Philippe Mathieu-Daudé
2024-01-29 11:04   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 13/33] softmmu/physmem: Remove qemu_host_page_size Richard Henderson
2024-01-03 15:30   ` Philippe Mathieu-Daudé
2024-01-29 14:28   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 14/33] softmmu/physmem: Remove HOST_PAGE_ALIGN Richard Henderson
2024-01-08 11:08   ` Pierrick Bouvier
2024-01-29 14:31   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 15/33] linux-user: Remove qemu_host_page_size from main Richard Henderson
2024-01-03 15:31   ` Philippe Mathieu-Daudé
2024-01-29 14:44   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 16/33] linux-user: Split out target_mmap__locked Richard Henderson
2024-01-08 10:50   ` Pierrick Bouvier
2024-01-29 14:45   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 17/33] linux-user: Move some mmap checks outside the lock Richard Henderson
2024-01-29 14:52   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 18/33] linux-user: Fix sub-host-page mmap Richard Henderson
2024-01-08 10:54   ` Pierrick Bouvier
2024-01-29 14:57   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 19/33] linux-user: Split out mmap_end Richard Henderson
2024-01-29 14:59   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 20/33] linux-user: Do early mmap placement only for reserved_va Richard Henderson
2024-01-08 11:05   ` Pierrick Bouvier
2024-01-29 15:06   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 21/33] linux-user: Split out mmap_h_eq_g Richard Henderson
2024-01-08 11:13   ` Pierrick Bouvier
2024-01-29 15:12   ` Ilya Leoshkevich
2024-02-13 19:52     ` Richard Henderson
2024-01-02  1:57 ` [PATCH v3 22/33] linux-user: Split out mmap_h_lt_g Richard Henderson
2024-01-08 12:16   ` Pierrick Bouvier
2024-01-29 15:26   ` Ilya Leoshkevich
2024-02-13 19:54     ` Richard Henderson
2024-02-14 14:24       ` Ilya Leoshkevich
2024-02-13 19:59     ` Richard Henderson
2024-01-02  1:57 ` [PATCH v3 23/33] linux-user: Split out mmap_h_gt_g Richard Henderson
2024-01-08 11:21   ` Pierrick Bouvier
2024-01-30 10:45   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 24/33] tests/tcg: Remove run-test-mmap-* Richard Henderson
2024-01-08 11:07   ` Pierrick Bouvier
2024-01-30 10:46   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 25/33] tests/tcg: Extend file in linux-madvise.c Richard Henderson
2024-01-30 13:13   ` Ilya Leoshkevich
2024-02-03 22:58     ` Richard Henderson
2024-01-02  1:58 ` [PATCH v3 26/33] *-user: Deprecate and disable -p pagesize Richard Henderson
2024-01-02 19:13   ` Philippe Mathieu-Daudé
2024-01-30 13:16   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 27/33] cpu: Remove page_size_init Richard Henderson
2024-01-30 13:17   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 28/33] accel/tcg: Disconnect TargetPageDataNode from page size Richard Henderson
2024-01-30 13:22   ` Ilya Leoshkevich
2024-01-02  1:58 ` Richard Henderson [this message]
2024-01-30 13:47   ` [PATCH v3 29/33] linux-user: Allow TARGET_PAGE_BITS_VARY Ilya Leoshkevich
2024-02-14  0:38     ` Richard Henderson
2024-01-02  1:58 ` [PATCH v3 30/33] target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only Richard Henderson
2024-01-08 11:02   ` Pierrick Bouvier
2024-01-02  1:58 ` [PATCH v3 31/33] linux-user: Bound mmap_min_addr by host page size Richard Henderson
2024-01-03 15:32   ` Philippe Mathieu-Daudé
2024-01-30 13:48   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 32/33] target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only Richard Henderson
2024-01-30 13:51   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 33/33] target/alpha: " Richard Henderson
2024-01-08 11:03   ` Pierrick Bouvier
2024-01-30 13:52   ` Ilya Leoshkevich
2024-01-05 10:17 ` [PATCH v3 00/33] linux-user: Improve host and guest page size handling Helge Deller
2024-01-05 13:55 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102015808.132373-30-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).