qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v3 05/33] linux-user/hppa: Simplify init_guest_commpage
Date: Tue,  2 Jan 2024 12:57:40 +1100	[thread overview]
Message-ID: <20240102015808.132373-6-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240102015808.132373-1-richard.henderson@linaro.org>

If reserved_va, then we have already reserved the entire
guest virtual address space; no need to remap page.
If !reserved_va, then use MAP_FIXED_NOREPLACE.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/elfload.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index c166faabab..96d8d4f84c 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1969,16 +1969,21 @@ static inline void init_thread(struct target_pt_regs *regs,
 
 static bool init_guest_commpage(void)
 {
-    void *want = g2h_untagged(LO_COMMPAGE);
-    void *addr = mmap(want, qemu_host_page_size, PROT_NONE,
-                      MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED, -1, 0);
+    /* If reserved_va, then we have already mapped 0 page on the host. */
+    if (!reserved_va) {
+        int host_page_size = qemu_real_host_page_size();
+        void *want, *addr;
 
-    if (addr == MAP_FAILED) {
-        perror("Allocating guest commpage");
-        exit(EXIT_FAILURE);
-    }
-    if (addr != want) {
-        return false;
+        want = g2h_untagged(LO_COMMPAGE);
+        addr = mmap(want, host_page_size, PROT_NONE,
+                    MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED_NOREPLACE, -1, 0);
+        if (addr == MAP_FAILED) {
+            perror("Allocating guest commpage");
+            exit(EXIT_FAILURE);
+        }
+        if (addr != want) {
+            return false;
+        }
     }
 
     /*
-- 
2.34.1



  parent reply	other threads:[~2024-01-02  1:58 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02  1:57 [PATCH v3 00/33] linux-user: Improve host and guest page size handling Richard Henderson
2024-01-02  1:57 ` [PATCH v3 01/33] accel/tcg: Remove qemu_host_page_size from page_protect/page_unprotect Richard Henderson
2024-01-03 15:28   ` Philippe Mathieu-Daudé
2024-01-29  9:59   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 02/33] linux-user: Adjust SVr4 NULL page mapping Richard Henderson
2024-01-08  8:54   ` Pierrick Bouvier
2024-01-29 10:03   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 03/33] linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base Richard Henderson
2024-01-08  9:35   ` Pierrick Bouvier
2024-01-29 10:15   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 04/33] linux-user: Remove qemu_host_page_size from create_elf_tables Richard Henderson
2024-01-08  8:55   ` Pierrick Bouvier
2024-01-29 10:18   ` Ilya Leoshkevich
2024-01-02  1:57 ` Richard Henderson [this message]
2024-01-08  8:56   ` [PATCH v3 05/33] linux-user/hppa: Simplify init_guest_commpage Pierrick Bouvier
2024-01-29 10:28   ` Ilya Leoshkevich
2024-01-29 10:45     ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 06/33] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage Richard Henderson
2024-01-08  9:11   ` Pierrick Bouvier
2024-01-02  1:57 ` [PATCH v3 07/33] linux-user/arm: " Richard Henderson
2024-01-08  9:38   ` Pierrick Bouvier
2024-01-10 22:12     ` Richard Henderson
2024-01-02  1:57 ` [PATCH v3 08/33] linux-user: Remove qemu_host_page_{size, mask} from mmap.c Richard Henderson
2024-01-08  9:47   ` Pierrick Bouvier
2024-01-08 13:25     ` Philippe Mathieu-Daudé
2024-01-29 10:53   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 09/33] linux-user: Remove REAL_HOST_PAGE_ALIGN " Richard Henderson
2024-01-29 10:55   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 10/33] linux-user: Remove HOST_PAGE_ALIGN " Richard Henderson
2024-01-08 10:47   ` Pierrick Bouvier
2024-01-29 10:58   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 11/33] migration: Remove qemu_host_page_size Richard Henderson
2024-01-08 10:48   ` Pierrick Bouvier
2024-01-29 10:58   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 12/33] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init Richard Henderson
2024-01-02 19:12   ` Philippe Mathieu-Daudé
2024-01-29 11:04   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 13/33] softmmu/physmem: Remove qemu_host_page_size Richard Henderson
2024-01-03 15:30   ` Philippe Mathieu-Daudé
2024-01-29 14:28   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 14/33] softmmu/physmem: Remove HOST_PAGE_ALIGN Richard Henderson
2024-01-08 11:08   ` Pierrick Bouvier
2024-01-29 14:31   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 15/33] linux-user: Remove qemu_host_page_size from main Richard Henderson
2024-01-03 15:31   ` Philippe Mathieu-Daudé
2024-01-29 14:44   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 16/33] linux-user: Split out target_mmap__locked Richard Henderson
2024-01-08 10:50   ` Pierrick Bouvier
2024-01-29 14:45   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 17/33] linux-user: Move some mmap checks outside the lock Richard Henderson
2024-01-29 14:52   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 18/33] linux-user: Fix sub-host-page mmap Richard Henderson
2024-01-08 10:54   ` Pierrick Bouvier
2024-01-29 14:57   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 19/33] linux-user: Split out mmap_end Richard Henderson
2024-01-29 14:59   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 20/33] linux-user: Do early mmap placement only for reserved_va Richard Henderson
2024-01-08 11:05   ` Pierrick Bouvier
2024-01-29 15:06   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 21/33] linux-user: Split out mmap_h_eq_g Richard Henderson
2024-01-08 11:13   ` Pierrick Bouvier
2024-01-29 15:12   ` Ilya Leoshkevich
2024-02-13 19:52     ` Richard Henderson
2024-01-02  1:57 ` [PATCH v3 22/33] linux-user: Split out mmap_h_lt_g Richard Henderson
2024-01-08 12:16   ` Pierrick Bouvier
2024-01-29 15:26   ` Ilya Leoshkevich
2024-02-13 19:54     ` Richard Henderson
2024-02-14 14:24       ` Ilya Leoshkevich
2024-02-13 19:59     ` Richard Henderson
2024-01-02  1:57 ` [PATCH v3 23/33] linux-user: Split out mmap_h_gt_g Richard Henderson
2024-01-08 11:21   ` Pierrick Bouvier
2024-01-30 10:45   ` Ilya Leoshkevich
2024-01-02  1:57 ` [PATCH v3 24/33] tests/tcg: Remove run-test-mmap-* Richard Henderson
2024-01-08 11:07   ` Pierrick Bouvier
2024-01-30 10:46   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 25/33] tests/tcg: Extend file in linux-madvise.c Richard Henderson
2024-01-30 13:13   ` Ilya Leoshkevich
2024-02-03 22:58     ` Richard Henderson
2024-01-02  1:58 ` [PATCH v3 26/33] *-user: Deprecate and disable -p pagesize Richard Henderson
2024-01-02 19:13   ` Philippe Mathieu-Daudé
2024-01-30 13:16   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 27/33] cpu: Remove page_size_init Richard Henderson
2024-01-30 13:17   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 28/33] accel/tcg: Disconnect TargetPageDataNode from page size Richard Henderson
2024-01-30 13:22   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 29/33] linux-user: Allow TARGET_PAGE_BITS_VARY Richard Henderson
2024-01-30 13:47   ` Ilya Leoshkevich
2024-02-14  0:38     ` Richard Henderson
2024-01-02  1:58 ` [PATCH v3 30/33] target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only Richard Henderson
2024-01-08 11:02   ` Pierrick Bouvier
2024-01-02  1:58 ` [PATCH v3 31/33] linux-user: Bound mmap_min_addr by host page size Richard Henderson
2024-01-03 15:32   ` Philippe Mathieu-Daudé
2024-01-30 13:48   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 32/33] target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only Richard Henderson
2024-01-30 13:51   ` Ilya Leoshkevich
2024-01-02  1:58 ` [PATCH v3 33/33] target/alpha: " Richard Henderson
2024-01-08 11:03   ` Pierrick Bouvier
2024-01-30 13:52   ` Ilya Leoshkevich
2024-01-05 10:17 ` [PATCH v3 00/33] linux-user: Improve host and guest page size handling Helge Deller
2024-01-05 13:55 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240102015808.132373-6-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).