From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH] softmmu: remove obsolete comment about libvirt timeouts
Date: Wed, 3 Jan 2024 12:30:42 +0000 [thread overview]
Message-ID: <20240103123042.2400677-1-berrange@redhat.com> (raw)
For a long time now, libvirt has pre-created the monitor connection
socket and passed the pre-opened FD into QEMU during startup. Thus
libvirt does not have any timeouts waiting for the monitor socket
to appear, it is immediately connected.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
system/vl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/system/vl.c b/system/vl.c
index 6b87bfa32c..1d1508e28f 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -1911,7 +1911,6 @@ static bool object_create_early(const char *type)
* Allocation of large amounts of memory may delay
* chardev initialization for too long, and trigger timeouts
* on software that waits for a monitor socket to be created
- * (e.g. libvirt).
*/
if (g_str_has_prefix(type, "memory-backend-")) {
return false;
--
2.43.0
next reply other threads:[~2024-01-03 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 12:30 Daniel P. Berrangé [this message]
2024-01-03 14:49 ` [PATCH] softmmu: remove obsolete comment about libvirt timeouts Zhao Liu
2024-01-08 18:34 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103123042.2400677-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).