From: peterx@redhat.com
To: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fabiano Rosas <farosas@suse.de>,
Steve Sistare <steven.sistare@oracle.com>,
Juan Quintela <quintela@trasno.org>,
peterx@redhat.com,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
Avihai Horon <avihaih@nvidia.com>
Subject: [PULL 14/26] tests/qtest: postcopy migration with suspend
Date: Thu, 4 Jan 2024 12:31:59 +0800 [thread overview]
Message-ID: <20240104043213.431566-15-peterx@redhat.com> (raw)
In-Reply-To: <20240104043213.431566-1-peterx@redhat.com>
From: Steve Sistare <steven.sistare@oracle.com>
Add a test case to verify that the suspended state is handled correctly by
live migration postcopy. The test suspends the src, migrates, then wakes
the dest.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/1704312341-66640-13-git-send-email-steven.sistare@oracle.com
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration-test.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index a3bfbf2654..136e5df06c 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1347,6 +1347,7 @@ static int migrate_postcopy_prepare(QTestState **from_ptr,
/* Wait for the first serial output from the source */
wait_for_serial("src_serial");
+ wait_for_suspend(from, &src_state);
g_autofree char *uri = migrate_get_socket_address(to, "socket-address");
migrate_qmp(from, uri, "{}");
@@ -1364,6 +1365,11 @@ static void migrate_postcopy_complete(QTestState *from, QTestState *to,
{
wait_for_migration_complete(from);
+ if (args->start.suspend_me) {
+ /* wakeup succeeds only if guest is suspended */
+ qtest_qmp_assert_success(to, "{'execute': 'system_wakeup'}");
+ }
+
/* Make sure we get at least one "B" on destination */
wait_for_serial("dest_serial");
@@ -1397,6 +1403,15 @@ static void test_postcopy(void)
test_postcopy_common(&args);
}
+static void test_postcopy_suspend(void)
+{
+ MigrateCommon args = {
+ .start.suspend_me = true,
+ };
+
+ test_postcopy_common(&args);
+}
+
static void test_postcopy_compress(void)
{
MigrateCommon args = {
@@ -3412,7 +3427,10 @@ int main(int argc, char **argv)
qtest_add_func("/migration/postcopy/recovery/double-failures",
test_postcopy_recovery_double_fail);
#endif /* _WIN32 */
-
+ if (is_x86) {
+ qtest_add_func("/migration/postcopy/suspend",
+ test_postcopy_suspend);
+ }
}
qtest_add_func("/migration/bad_dest", test_baddest);
--
2.41.0
next prev parent reply other threads:[~2024-01-04 4:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 4:31 [PULL 00/26] Migration 20240104 patches peterx
2024-01-04 4:31 ` [PULL 01/26] MAINTAINERS: Leaving Migration peterx
2024-01-04 4:31 ` [PULL 02/26] MAINTAINERS: Remove myself as reviewer from Live Migration peterx
2024-01-04 4:31 ` [PULL 03/26] cpus: vm_was_suspended peterx
2024-01-04 4:31 ` [PULL 04/26] cpus: stop vm in suspended runstate peterx
2024-01-04 4:31 ` [PULL 05/26] cpus: check running not RUN_STATE_RUNNING peterx
2024-01-04 4:31 ` [PULL 06/26] cpus: vm_resume peterx
2024-01-04 4:31 ` [PULL 07/26] migration: propagate suspended runstate peterx
2024-01-04 4:31 ` [PULL 08/26] migration: preserve " peterx
2024-01-04 4:31 ` [PULL 09/26] migration: preserve suspended for snapshot peterx
2024-01-04 4:31 ` [PULL 10/26] migration: preserve suspended for bg_migration peterx
2024-01-04 4:31 ` [PULL 11/26] tests/qtest: migration events peterx
2024-01-04 4:31 ` [PULL 12/26] tests/qtest: option to suspend during migration peterx
2024-01-04 4:31 ` [PULL 13/26] tests/qtest: precopy migration with suspend peterx
2024-01-04 4:31 ` peterx [this message]
2024-01-04 4:32 ` [PULL 15/26] migration: Remove migrate_max_downtime() declaration peterx
2024-01-04 4:32 ` [PULL 16/26] migration: Remove nulling of hostname in migrate_init() peterx
2024-01-04 4:32 ` [PULL 17/26] migration: Refactor migration_incoming_setup() peterx
2024-01-04 4:32 ` [PULL 18/26] migration: Remove errp parameter in migration_fd_process_incoming() peterx
2024-01-04 4:32 ` [PULL 19/26] migration/multifd: Fix error message in multifd_recv_initial_packet() peterx
2024-01-04 4:32 ` [PULL 20/26] migration/multifd: Simplify multifd_channel_connect() if else statement peterx
2024-01-04 4:32 ` [PULL 21/26] migration/multifd: Fix leaking of Error in TLS error flow peterx
2024-01-04 4:32 ` [PULL 22/26] migration/multifd: Remove error_setg() in migration_ioc_process_incoming() peterx
2024-01-04 4:32 ` [PULL 23/26] migration: Fix migration_channel_read_peek() error path peterx
2024-01-04 4:32 ` [PULL 24/26] migration: Remove unnecessary usage of local Error peterx
2024-01-04 4:32 ` [PULL 25/26] migration/multifd: " peterx
2024-01-04 4:32 ` [PULL 26/26] migration: fix coverity migrate_mode finding peterx
2024-01-05 16:08 ` [PULL 00/26] Migration 20240104 patches Peter Maydell
2024-01-07 12:33 ` Peter Xu
2024-01-07 12:41 ` Stefan Hajnoczi
2024-01-07 15:23 ` Peter Maydell
2024-01-07 16:28 ` Stefan Hajnoczi
2024-01-08 2:10 ` Peter Xu
2024-01-08 2:34 ` Peter Xu
2024-01-08 15:22 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104043213.431566-15-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=avihaih@nvidia.com \
--cc=farosas@suse.de \
--cc=lsoaresp@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@trasno.org \
--cc=stefanha@redhat.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).