qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Hanna Reitz" <hreitz@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-block@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH 0/2] hw/pflash: implement update buffer for block writes
Date: Fri,  5 Jan 2024 14:58:52 +0100	[thread overview]
Message-ID: <20240105135855.268064-1-kraxel@redhat.com> (raw)

When running qemu with edk2 efi firmware on aarch64 the efi
variable store in pflash can get corrupted.  qemu not doing
proper block writes -- flush all or nothing to storage -- is
a hot candidate for being the root cause.

This little series tries to fix that with an update buffer
where block writes are staged, so we can commit or discard
the changes when the block write is completed or canceled.

Gerd Hoffmann (2):
  hw/pflash: refactor pflash_data_write()
  hw/pflash: implement update buffer for block writes

 hw/block/pflash_cfi01.c | 132 ++++++++++++++++++++++++++++------------
 1 file changed, 93 insertions(+), 39 deletions(-)

-- 
2.43.0



             reply	other threads:[~2024-01-05 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 13:58 Gerd Hoffmann [this message]
2024-01-05 13:58 ` [PATCH 1/2] hw/pflash: refactor pflash_data_write() Gerd Hoffmann
2024-01-05 14:08   ` Philippe Mathieu-Daudé
2024-01-05 13:58 ` [PATCH 2/2] hw/pflash: implement update buffer for block writes Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105135855.268064-1-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).