From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2BA4C4707B for ; Sun, 7 Jan 2024 14:03:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMTjg-00030R-E3; Sun, 07 Jan 2024 09:02:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMTjb-000305-Bs for qemu-devel@nongnu.org; Sun, 07 Jan 2024 09:02:39 -0500 Received: from todd.t-8ch.de ([2a01:4f8:c010:41de::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMTjY-0006Ro-VP for qemu-devel@nongnu.org; Sun, 07 Jan 2024 09:02:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=t-8ch.de; s=mail; t=1704636150; bh=4McxHWHha+YyA5MTOk3Ks69ExxK0HgbCWA1yVUkjl7o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NAMlcXx2NoRvxY45Tx+bivU8wLmmBKXtQ5sjOEjNI1vBtZspRUdiDYnRWhGAvmzCU 0DIIlRclp8dNPYu7HK0Pukcd2o3nKiQbuAH1NrYHTMRi6rvCaT1vVnpMxGogujYpQ5 mNIH2cAVzIa0buBPiLSWJNr8h0M83P6U730Cx2dk= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sun, 07 Jan 2024 15:01:53 +0100 Subject: [PATCH v2 1/2] linux-user/elfload: test return value of getrlimit MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20240107-qemu-user-dumpable-v2-1-54e3bcfc00c9@t-8ch.de> References: <20240107-qemu-user-dumpable-v2-0-54e3bcfc00c9@t-8ch.de> In-Reply-To: <20240107-qemu-user-dumpable-v2-0-54e3bcfc00c9@t-8ch.de> To: Laurent Vivier Cc: qemu-devel@nongnu.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704636150; l=813; i=thomas@t-8ch.de; s=20221212; h=from:subject:message-id; bh=4McxHWHha+YyA5MTOk3Ks69ExxK0HgbCWA1yVUkjl7o=; b=gFhAk68ulSTEJIPYM0Z9sr1jRUwKZLQLNWatRcU9BwTDp+agWuWWF6nC1dmCE/lEftysBK9Tu dXeLPyOzwcnCiXPLOc6Gsyw85mmHZTm/9KtEfa8nGCriEVA5XzC4I9i X-Developer-Key: i=thomas@t-8ch.de; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Received-SPF: pass client-ip=2a01:4f8:c010:41de::1; envelope-from=thomas@t-8ch.de; helo=todd.t-8ch.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Should getrlimit() fail the value of dumpsize.rlimit_cur may not be initialized. Avoid reading garbage data by checking the return value of getrlimit. Signed-off-by: Thomas Weißschuh --- linux-user/elfload.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index cf9e74468b11..74c9ecda1806 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -4667,8 +4667,7 @@ static int elf_core_dump(int signr, const CPUArchState *env) init_note_info(&info); errno = 0; - getrlimit(RLIMIT_CORE, &dumpsize); - if (dumpsize.rlim_cur == 0) + if (getrlimit(RLIMIT_CORE, &dumpsize) == 0 && dumpsize.rlim_cur == 0) return 0; corefile = core_dump_filename(ts); -- 2.43.0