From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
qemu-ppc@nongnu.org
Subject: [PATCH 3/9] tests/avocado: Mark x86-64 boot_linux.py TCG tests as long runtime
Date: Mon, 8 Jan 2024 03:01:13 +1000 [thread overview]
Message-ID: <20240107170119.82222-4-npiggin@gmail.com> (raw)
In-Reply-To: <20240107170119.82222-1-npiggin@gmail.com>
Re-testing gitlab CI shows the x86-64 TCG tests take ~100s each, are
the longest-running tests. They are close to the ~150s taken by the
disabled ppc64 and s390x tests. From avocado-system-centos:
boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg: PASS (112.34 s)
boot_linux.py:BootLinuxX8664.test_pc_q35_tcg: PASS (97.05 s)
boot_linux.py:BootLinuxPPC64.test_pseries_tcg: PASS (148.86 s)
boot_linux.py:BootLinuxS390X.test_s390_ccw_virtio_tcg: PASS (149.83 s)
So disable the x86-64 tests as well.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
The other way we could go is enabling them all since ppc64 and s390s are
now much faster than when they were originally disabled; or to only
enable q35, giving at least one boot_linux.py test.
[Test time results from here https://gitlab.com/npiggin/qemu/-/jobs/5842257510]
Thanks,
Nick
---
tests/avocado/boot_linux.py | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py
index 6df0fc0489..a4a78122ac 100644
--- a/tests/avocado/boot_linux.py
+++ b/tests/avocado/boot_linux.py
@@ -14,6 +14,9 @@
from avocado import skipUnless
+# We don't run TCG tests in CI, as booting the current Fedora OS in TCG tests
+# is very heavyweight (~100s per test). There are lighter weight distros which
+# we use in the machine_aarch64_virt.py, tux_baseline.py, etc.
class BootLinuxX8664(LinuxTest):
"""
@@ -21,6 +24,7 @@ class BootLinuxX8664(LinuxTest):
"""
timeout = 480
+ @skipUnless(os.getenv('AVOCADO_ALLOW_LONG_RUNTIME'), 'runtime limited')
def test_pc_i440fx_tcg(self):
"""
:avocado: tags=machine:pc
@@ -39,6 +43,7 @@ def test_pc_i440fx_kvm(self):
self.vm.add_args("-accel", "kvm")
self.launch_and_wait(set_up_ssh_connection=False)
+ @skipUnless(os.getenv('AVOCADO_ALLOW_LONG_RUNTIME'), 'runtime limited')
def test_pc_q35_tcg(self):
"""
:avocado: tags=machine:q35
@@ -58,9 +63,6 @@ def test_pc_q35_kvm(self):
self.launch_and_wait(set_up_ssh_connection=False)
-# For Aarch64 we only boot KVM tests in CI as booting the current
-# Fedora OS in TCG tests is very heavyweight. There are lighter weight
-# distros which we use in the machine_aarch64_virt.py tests.
class BootLinuxAarch64(LinuxTest):
"""
:avocado: tags=arch:aarch64
@@ -84,14 +86,11 @@ def test_virt_kvm(self):
self.launch_and_wait(set_up_ssh_connection=False)
-# See the tux_baseline.py tests for almost the same coverage in a lot
-# less time.
class BootLinuxPPC64(LinuxTest):
"""
:avocado: tags=arch:ppc64
"""
-
- timeout = 360
+ timeout = 480
@skipUnless(os.getenv('AVOCADO_ALLOW_LONG_RUNTIME'), 'runtime limited')
def test_pseries_tcg(self):
@@ -108,8 +107,7 @@ class BootLinuxS390X(LinuxTest):
"""
:avocado: tags=arch:s390x
"""
-
- timeout = 240
+ timeout = 480
@skipUnless(os.getenv('AVOCADO_ALLOW_LONG_RUNTIME'), 'runtime limited')
def test_s390_ccw_virtio_tcg(self):
--
2.42.0
next prev parent reply other threads:[~2024-01-07 17:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 17:01 [PATCH 0/9] tests/avocado: ppc additions and other fixes Nicholas Piggin
2024-01-07 17:01 ` [PATCH 1/9] gitlab: fix s390x tag for avocado-system-centos Nicholas Piggin
2024-01-08 9:45 ` Cédric Le Goater
2024-01-08 11:35 ` Philippe Mathieu-Daudé
2024-01-24 13:11 ` Philippe Mathieu-Daudé
2024-01-07 17:01 ` [PATCH 2/9] tests/avocado: mark boot_linux.py long runtime instead of flaky Nicholas Piggin
2024-01-08 10:12 ` Cédric Le Goater
2024-01-08 11:56 ` Thomas Huth
2024-01-07 17:01 ` Nicholas Piggin [this message]
2024-01-07 17:01 ` [PATCH 4/9] tests/avocado: Enable replay_linux.py on ppc64 pseries Nicholas Piggin
2024-01-07 17:01 ` [PATCH 5/9] tests/avocado: ppc add powernv10 boot_linux_console test Nicholas Piggin
2024-01-08 10:53 ` Cédric Le Goater
2024-01-07 17:01 ` [PATCH 6/9] tests/avocado: Add ppc pseries and powernv hash MMU tests Nicholas Piggin
2024-01-07 17:01 ` [PATCH 7/9] tests/avocado: Add pseries KVM boot_linux test Nicholas Piggin
2024-01-08 10:53 ` Cédric Le Goater
2024-01-07 17:01 ` [PATCH 8/9] tests/avocado: ppc add hypervisor tests Nicholas Piggin
2024-01-08 14:37 ` Cédric Le Goater
2024-01-07 17:01 ` [PATCH 9/9] tests/avocado: Add FreeBSD distro boot tests for ppc Nicholas Piggin
2024-01-08 12:16 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240107170119.82222-4-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=danielhb413@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).