From: Andrew Jones <ajones@ventanamicro.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Conor Dooley <conor@kernel.org>,
qemu-riscv@nongnu.org, Conor Dooley <conor.dooley@microchip.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Weiwei Li <liwei1518@gmail.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
qemu-devel@nongnu.org
Subject: Re: Re: [PATCH v2] riscv: support new isa extension detection devicetree properties
Date: Mon, 8 Jan 2024 14:27:06 +0100 [thread overview]
Message-ID: <20240108-efa3f83dcd3997dc0af458d7@orel> (raw)
In-Reply-To: <CAKmqyKNmepRv7i43U-2V2LYzkQB1bG9WWvS1PUJdrF3ynX5NmQ@mail.gmail.com>
On Mon, Dec 18, 2023 at 02:37:55PM +1000, Alistair Francis wrote:
...
> > +void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
> > +{
> > + const size_t maxlen = sizeof("rv128i");
> > + g_autofree char *isa_base = g_new(char, maxlen);
> > + g_autofree char *riscv_isa;
> > + char **isa_extensions;
> > + int count = 0;
> > +
> > + riscv_isa = riscv_isa_string(cpu);
> > + qemu_fdt_setprop_string(fdt, nodename, "riscv,isa", riscv_isa);
> > +
> > + snprintf(isa_base, maxlen, "rv%di", TARGET_LONG_BITS);
>
> This should dynamically come from misa_mxl_max not the compile time target
>
Need to also fix riscv_isa_string()
Thanks,
drew
next prev parent reply other threads:[~2024-01-08 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 12:07 [PATCH v2] riscv: support new isa extension detection devicetree properties Conor Dooley
2023-12-08 20:26 ` Daniel Henrique Barboza
2023-12-18 4:37 ` Alistair Francis
2024-01-08 13:27 ` Andrew Jones [this message]
2024-01-08 13:26 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108-efa3f83dcd3997dc0af458d7@orel \
--to=ajones@ventanamicro.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bin.meng@windriver.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).