From: deller@kernel.org
To: qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>
Subject: [PULL 4/9] target/hppa: Fix PDC address translation on PA2.0 with PSW.W=0
Date: Mon, 8 Jan 2024 15:37:57 +0100 [thread overview]
Message-ID: <20240108143802.50256-5-deller@kernel.org> (raw)
In-Reply-To: <20240108143802.50256-1-deller@kernel.org>
From: Helge Deller <deller@gmx.de>
Fix the address translation for PDC space on PA2.0 if PSW.W=0.
Basically, for any address in the 32-bit PDC range from 0xf0000000 to
0xf1000000 keep the lower 32-bits and just set the upper 32-bits to
0xfffffff0.
This mapping fixes the emulated power button in PDC space for 32- and
64-bit machines and is how the physical C3700 machine seems to map
PDC.
Signed-off-by: Helge Deller <deller@gmx.de>
---
target/hppa/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index 08abd1a9f9..011b192406 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -56,7 +56,7 @@ hwaddr hppa_abs_to_phys_pa2_w0(vaddr addr)
addr = (int32_t)addr;
} else {
/* PDC address space */
- addr &= MAKE_64BIT_MASK(0, 24);
+ addr = (uint32_t)addr;
addr |= -1ull << (TARGET_PHYS_ADDR_SPACE_BITS - 4);
}
return addr;
--
2.43.0
next prev parent reply other threads:[~2024-01-08 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 14:37 [PULL 0/9] Hppa fixes 8.2 patches deller
2024-01-08 14:37 ` [PULL 1/9] hw/hppa/machine: Allow up to 3840 MB total memory deller
2024-01-08 14:37 ` [PULL 2/9] hw/hppa/machine: Disable default devices with --nodefaults option deller
2024-01-08 14:37 ` [PULL 3/9] hw/pci-host/astro: Add missing astro & elroy registers for NetBSD deller
2024-01-08 14:37 ` deller [this message]
2024-01-08 14:37 ` [PULL 5/9] target/hppa: Strip upper 32-bits of IOR on error in probe deller
2024-01-08 14:37 ` [PULL 6/9] target/hppa: Strip upper 32-bits of IOR on unaligned access error deller
2024-01-08 14:38 ` [PULL 7/9] hw/hppa: Move software power button address back into PDC deller
2024-01-08 14:38 ` [PULL 8/9] target/hppa: Avoid accessing %gr0 when raising exception deller
2024-01-08 14:38 ` [PULL 9/9] target/hppa: Update SeaBIOS-hppa to version 15 deller
2024-01-09 9:17 ` [PULL 0/9] Hppa fixes 8.2 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108143802.50256-5-deller@kernel.org \
--to=deller@kernel.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).