qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: deller@kernel.org
To: qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>
Subject: [PULL 8/9] target/hppa: Avoid accessing %gr0 when raising exception
Date: Mon,  8 Jan 2024 15:38:01 +0100	[thread overview]
Message-ID: <20240108143802.50256-9-deller@kernel.org> (raw)
In-Reply-To: <20240108143802.50256-1-deller@kernel.org>

From: Helge Deller <deller@gmx.de>

The value of unwind_breg may reference register %r0, but we need to avoid
accessing gr0 directly and use the value 0 instead.

At runtime I've seen unwind_breg being zero with the Linux kernel when
rfi is used to jump to smp_callin().

Signed-off-by: Helge Deller <deller@gmx.de>
---
 target/hppa/mem_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index 011b192406..42bd0063c0 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -335,7 +335,7 @@ raise_exception_with_ior(CPUHPPAState *env, int excp, uintptr_t retaddr,
 
                 cpu_restore_state(cs, retaddr);
 
-                b = env->gr[env->unwind_breg];
+                b = env->unwind_breg ? env->gr[env->unwind_breg] : 0;
                 b >>= (env->psw & PSW_W ? 62 : 30);
                 env->cr[CR_IOR] |= b << 62;
 
-- 
2.43.0



  parent reply	other threads:[~2024-01-08 14:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 14:37 [PULL 0/9] Hppa fixes 8.2 patches deller
2024-01-08 14:37 ` [PULL 1/9] hw/hppa/machine: Allow up to 3840 MB total memory deller
2024-01-08 14:37 ` [PULL 2/9] hw/hppa/machine: Disable default devices with --nodefaults option deller
2024-01-08 14:37 ` [PULL 3/9] hw/pci-host/astro: Add missing astro & elroy registers for NetBSD deller
2024-01-08 14:37 ` [PULL 4/9] target/hppa: Fix PDC address translation on PA2.0 with PSW.W=0 deller
2024-01-08 14:37 ` [PULL 5/9] target/hppa: Strip upper 32-bits of IOR on error in probe deller
2024-01-08 14:37 ` [PULL 6/9] target/hppa: Strip upper 32-bits of IOR on unaligned access error deller
2024-01-08 14:38 ` [PULL 7/9] hw/hppa: Move software power button address back into PDC deller
2024-01-08 14:38 ` deller [this message]
2024-01-08 14:38 ` [PULL 9/9] target/hppa: Update SeaBIOS-hppa to version 15 deller
2024-01-09  9:17 ` [PULL 0/9] Hppa fixes 8.2 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240108143802.50256-9-deller@kernel.org \
    --to=deller@kernel.org \
    --cc=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).