qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Pavel Dovgalyuk" <Pavel.Dovgalyuk@ispras.ru>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 07/13] replay: add proper kdoc for ReplayState
Date: Mon,  8 Jan 2024 15:13:46 +0000	[thread overview]
Message-ID: <20240108151352.2199097-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240108151352.2199097-1-alex.bennee@linaro.org>

Remove the non-standard comment formatting and move the descriptions
into a proper kdoc comment.

Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231211091346.14616-8-alex.bennee@linaro.org>

diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index 516147ddbca..98ca3748edb 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -63,24 +63,31 @@ enum ReplayEvents {
     EVENT_COUNT
 };
 
+/**
+ * typedef ReplayState - global tracking Replay state
+ *
+ * This structure tracks where we are in the current ReplayState
+ * including the logged events from the recorded replay stream. Some
+ * of the data is also stored/restored from VMStateDescription when VM
+ * save/restore events take place.
+ *
+ * @cached_clock: Cached clocks values
+ * @current_icount: number of processed instructions
+ * @instruction_count: number of instructions until next event
+ * @data_kind: current event
+ * @has_unread_data: 1 if event not yet processed
+ * @file_offset: offset into replay log at replay snapshot
+ * @block_request_id: current serialised block request id
+ * @read_event_id: current async read event id
+ */
 typedef struct ReplayState {
-    /*! Cached clock values. */
     int64_t cached_clock[REPLAY_CLOCK_COUNT];
-    /*! Current icount - number of processed instructions. */
     uint64_t current_icount;
-    /*! Number of instructions to be executed before other events happen. */
     int instruction_count;
-    /*! Type of the currently executed event. */
     unsigned int data_kind;
-    /*! Flag which indicates that event is not processed yet. */
     unsigned int has_unread_data;
-    /*! Temporary variable for saving current log offset. */
     uint64_t file_offset;
-    /*! Next block operation id.
-        This counter is global, because requests from different
-        block devices should not get overlapping ids. */
     uint64_t block_request_id;
-    /*! Asynchronous event id read from the log */
     uint64_t read_event_id;
 } ReplayState;
 extern ReplayState replay_state;
-- 
2.39.2



  parent reply	other threads:[~2024-01-08 15:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 15:13 [PULL 00/13] replay fixes for replay_kernel Alex Bennée
2024-01-08 15:13 ` [PULL 01/13] tests/avocado: add a simple i386 replay kernel test Alex Bennée
2024-01-08 15:13 ` [PULL 02/13] tests/avocado: fix typo in replay_linux Alex Bennée
2024-01-08 15:13 ` [PULL 03/13] tests/avocado: modernise the drive args for replay_linux Alex Bennée
2024-01-08 15:13 ` [PULL 04/13] scripts/replay-dump: update to latest format Alex Bennée
2024-01-08 15:13 ` [PULL 05/13] scripts/replay_dump: track total number of instructions Alex Bennée
2024-01-08 15:13 ` [PULL 06/13] replay: remove host_clock_last Alex Bennée
2024-01-08 15:13 ` Alex Bennée [this message]
2024-01-08 15:13 ` [PULL 08/13] replay: make has_unread_data a bool Alex Bennée
2024-01-08 15:13 ` [PULL 09/13] replay: introduce a central report point for sync errors Alex Bennée
2024-01-08 15:13 ` [PULL 10/13] replay/replay-char: use report_sync_error Alex Bennée
2024-01-08 15:13 ` [PULL 11/13] replay: stop us hanging in rr_wait_io_event Alex Bennée
2024-01-08 15:13 ` [PULL 12/13] chardev: force write all when recording replay logs Alex Bennée
2024-01-08 15:13 ` [PULL 13/13] tests/avocado: remove skips from replay_kernel Alex Bennée
2024-01-11 17:19   ` Thomas Huth
2024-01-12  9:35     ` Alex Bennée
2024-01-12 13:27     ` Alex Bennée
2024-01-09 14:23 ` [PULL 00/13] replay fixes for replay_kernel Peter Maydell
2024-01-09 14:24   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240108151352.2199097-8-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Pavel.Dovgalyuk@ispras.ru \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).