From: Nabih Estefan <nabihestefan@google.com>
To: peter.maydell@linaro.org
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kfting@nuvoton.com,
wuhaotsh@google.com, jasowang@redhat.com,
avi.fishman@nuvoton.com, nabihestefan@google.com,
kwliu@nuvoton.com, tomer.maimon@nuvoton.com,
Hila.Miranda-Kuzi@nuvoton.com
Subject: [PATCH v11 07/10] include/hw/net: GMAC IRQ Implementation
Date: Tue, 9 Jan 2024 00:02:31 +0000 [thread overview]
Message-ID: <20240109000234.2799153-8-nabihestefan@google.com> (raw)
In-Reply-To: <20240109000234.2799153-1-nabihestefan@google.com>
From: Nabih Estefan Diaz <nabihestefan@google.com>
Implement Update IRQ Method for GMAC functionality.
Added relevant trace-events
Change-Id: I7a2d3cd3f493278bcd0cf483233c1e05c37488b7
Signed-off-by: Nabih Estefan <nabihestefan@google.com>
Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
---
hw/net/npcm_gmac.c | 40 ++++++++++++++++++++++++++++++++++++++++
hw/net/trace-events | 1 +
2 files changed, 41 insertions(+)
diff --git a/hw/net/npcm_gmac.c b/hw/net/npcm_gmac.c
index 98b3c33c94..44c4ffaff4 100644
--- a/hw/net/npcm_gmac.c
+++ b/hw/net/npcm_gmac.c
@@ -149,6 +149,46 @@ static bool gmac_can_receive(NetClientState *nc)
return true;
}
+/*
+ * Function that updates the GMAC IRQ
+ * It find the logical OR of the enabled bits for NIS (if enabled)
+ * It find the logical OR of the enabled bits for AIS (if enabled)
+ */
+static void gmac_update_irq(NPCMGMACState *gmac)
+{
+ /*
+ * Check if the normal interrupts summary is enabled
+ * if so, add the bits for the summary that are enabled
+ */
+ if (gmac->regs[R_NPCM_DMA_INTR_ENA] & gmac->regs[R_NPCM_DMA_STATUS] &
+ (NPCM_DMA_INTR_ENAB_NIE_BITS)) {
+ gmac->regs[R_NPCM_DMA_STATUS] |= NPCM_DMA_STATUS_NIS;
+ }
+ /*
+ * Check if the abnormal interrupts summary is enabled
+ * if so, add the bits for the summary that are enabled
+ */
+ if (gmac->regs[R_NPCM_DMA_INTR_ENA] & gmac->regs[R_NPCM_DMA_STATUS] &
+ (NPCM_DMA_INTR_ENAB_AIE_BITS)) {
+ gmac->regs[R_NPCM_DMA_STATUS] |= NPCM_DMA_STATUS_AIS;
+ }
+
+ /* Get the logical OR of both normal and abnormal interrupts */
+ int level = !!((gmac->regs[R_NPCM_DMA_STATUS] &
+ gmac->regs[R_NPCM_DMA_INTR_ENA] &
+ NPCM_DMA_STATUS_NIS) |
+ (gmac->regs[R_NPCM_DMA_STATUS] &
+ gmac->regs[R_NPCM_DMA_INTR_ENA] &
+ NPCM_DMA_STATUS_AIS));
+
+ /* Set the IRQ */
+ trace_npcm_gmac_update_irq(DEVICE(gmac)->canonical_path,
+ gmac->regs[R_NPCM_DMA_STATUS],
+ gmac->regs[R_NPCM_DMA_INTR_ENA],
+ level);
+ qemu_set_irq(gmac->irq, level);
+}
+
static ssize_t gmac_receive(NetClientState *nc, const uint8_t *buf, size_t len)
{
/* Placeholder. Function will be filled in following patches */
diff --git a/hw/net/trace-events b/hw/net/trace-events
index 33514548b8..56057de47f 100644
--- a/hw/net/trace-events
+++ b/hw/net/trace-events
@@ -473,6 +473,7 @@ npcm_gmac_reg_write(const char *name, uint64_t offset, uint32_t value) "%s: offs
npcm_gmac_mdio_access(const char *name, uint8_t is_write, uint8_t pa, uint8_t gr, uint16_t val) "%s: is_write: %" PRIu8 " pa: %" PRIu8 " gr: %" PRIu8 " val: 0x%04" PRIx16
npcm_gmac_reset(const char *name, uint16_t value) "%s: phy_regs[0][1]: 0x%04" PRIx16
npcm_gmac_set_link(bool active) "Set link: active=%u"
+npcm_gmac_update_irq(const char *name, uint32_t status, uint32_t intr_en, int level) "%s: Status Reg: 0x%04" PRIX32 " Interrupt Enable Reg: 0x%04" PRIX32 " IRQ Set: %d"
# npcm_pcs.c
npcm_pcs_reg_read(const char *name, uint16_t indirect_access_baes, uint64_t offset, uint16_t value) "%s: IND: 0x%02" PRIx16 " offset: 0x%04" PRIx64 " value: 0x%04" PRIx16
--
2.43.0.472.g3155946c3a-goog
next prev parent reply other threads:[~2024-01-09 0:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 0:02 [PATCH v11 00/10] Implementation of NPI Mailbox and GMAC Networking Module Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 01/10] hw/misc: Add Nuvoton's PCI Mailbox Module Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 02/10] hw/arm: Add PCI mailbox module to Nuvoton SoC Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 03/10] hw/misc: Add qtest for NPCM7xx PCI Mailbox Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 04/10] hw/net: Add NPCMXXX GMAC device Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 05/10] hw/arm: Add GMAC devices to NPCM7XX SoC Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 06/10] tests/qtest: Creating qtest for GMAC Module Nabih Estefan
2024-01-09 0:02 ` Nabih Estefan [this message]
2024-01-09 0:02 ` [PATCH v11 08/10] hw/net: GMAC Rx Implementation Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 09/10] hw/net: GMAC Tx Implementation Nabih Estefan
2024-01-09 0:02 ` [PATCH v11 10/10] tests/qtest: Adding PCS Module test to GMAC Qtest Nabih Estefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109000234.2799153-8-nabihestefan@google.com \
--to=nabihestefan@google.com \
--cc=Hila.Miranda-Kuzi@nuvoton.com \
--cc=avi.fishman@nuvoton.com \
--cc=jasowang@redhat.com \
--cc=kfting@nuvoton.com \
--cc=kwliu@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tomer.maimon@nuvoton.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).