* [PATCH 2/3] hw/scsi: add mode sense support for zbc device
[not found] ` <CGME20231208060902epcms2p3810b29fefbddaf16a7f3f2758cf218ba@epcms2p4>
@ 2023-12-08 6:20 ` Daejun Park
0 siblings, 0 replies; 2+ messages in thread
From: Daejun Park @ 2023-12-08 6:20 UTC (permalink / raw)
To: pbonzini@redhat.com, fam@euphon.net, Jeuk Kim,
qemu-devel@nongnu.org, Daejun Park
Cc: Seokhwan Kim, Yonggil Song, JinHwan Park
This patch enables mode sense for zbc devices.
Signed-off-by: Daejun Park <daejun7.park@samsung.com>
---
hw/scsi/scsi-disk.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 6691f5edb8..f1ecb77317 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -1083,11 +1083,14 @@ static int mode_sense_page(SCSIDiskState *s, int page, uint8_t **p_outbuf,
int page_control)
{
static const int mode_sense_valid[0x3f] = {
- [MODE_PAGE_VENDOR_SPECIFIC] = (1 << TYPE_DISK) | (1 << TYPE_ROM),
- [MODE_PAGE_HD_GEOMETRY] = (1 << TYPE_DISK),
- [MODE_PAGE_FLEXIBLE_DISK_GEOMETRY] = (1 << TYPE_DISK),
- [MODE_PAGE_CACHING] = (1 << TYPE_DISK) | (1 << TYPE_ROM),
- [MODE_PAGE_R_W_ERROR] = (1 << TYPE_DISK) | (1 << TYPE_ROM),
+ [MODE_PAGE_VENDOR_SPECIFIC] = (1 << TYPE_DISK) | (1 << TYPE_ROM)
+ | (1 << TYPE_ZBC),
+ [MODE_PAGE_HD_GEOMETRY] = (1 << TYPE_DISK) | (1 << TYPE_ZBC),
+ [MODE_PAGE_FLEXIBLE_DISK_GEOMETRY] = (1 << TYPE_DISK) | (1 << TYPE_ZBC),
+ [MODE_PAGE_CACHING] = (1 << TYPE_DISK) | (1 << TYPE_ROM)
+ | (1 << TYPE_ZBC),
+ [MODE_PAGE_R_W_ERROR] = (1 << TYPE_DISK) | (1 << TYPE_ROM)
+ | (1 << TYPE_ZBC),
[MODE_PAGE_AUDIO_CTL] = (1 << TYPE_ROM),
[MODE_PAGE_CAPABILITIES] = (1 << TYPE_ROM),
[MODE_PAGE_APPLE_VENDOR] = (1 << TYPE_ROM),
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 2/3] hw/scsi: add mode sense support for zbc device
[not found] <CGME20240109084052epcms2p2895e6b6bbd84880df6dac43166491f14@epcms2p2>
@ 2024-01-09 8:40 ` Daejun Park
0 siblings, 0 replies; 2+ messages in thread
From: Daejun Park @ 2024-01-09 8:40 UTC (permalink / raw)
To: pbonzini@redhat.com, fam@euphon.net, Jeuk Kim,
qemu-devel@nongnu.org
Cc: Seokhwan Kim, Yonggil Song
Gentle ping.
Would you mind review this patch for zbc devices?
Thanks,
Daejun
> This patch enables mode sense for zbc devices.
>
> Signed-off-by: Daejun Park
> ---
> hw/scsi/scsi-disk.c 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 6691f5edb8..f1ecb77317 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -1083,11 +1083,14 @@ static int mode_sense_page(SCSIDiskState *s, int page, uint8_t **p_outbuf,
> int page_control)
> {
> static const int mode_sense_valid[0x3f] = {
> - [MODE_PAGE_VENDOR_SPECIFIC] = (1 << TYPE_DISK) (1 << TYPE_ROM),
> - [MODE_PAGE_HD_GEOMETRY] = (1 << TYPE_DISK),
> - [MODE_PAGE_FLEXIBLE_DISK_GEOMETRY] = (1 << TYPE_DISK),
> - [MODE_PAGE_CACHING] = (1 << TYPE_DISK) (1 << TYPE_ROM),
> - [MODE_PAGE_R_W_ERROR] = (1 << TYPE_DISK) (1 << TYPE_ROM),
> + [MODE_PAGE_VENDOR_SPECIFIC] = (1 << TYPE_DISK) (1 << TYPE_ROM)
> + (1 << TYPE_ZBC),
> + [MODE_PAGE_HD_GEOMETRY] = (1 << TYPE_DISK) (1 << TYPE_ZBC),
> + [MODE_PAGE_FLEXIBLE_DISK_GEOMETRY] = (1 << TYPE_DISK) (1 << TYPE_ZBC),
> + [MODE_PAGE_CACHING] = (1 << TYPE_DISK) (1 << TYPE_ROM)
> + (1 << TYPE_ZBC),
> + [MODE_PAGE_R_W_ERROR] = (1 << TYPE_DISK) (1 << TYPE_ROM)
> + (1 << TYPE_ZBC),
> [MODE_PAGE_AUDIO_CTL] = (1 << TYPE_ROM),
> [MODE_PAGE_CAPABILITIES] = (1 << TYPE_ROM),
> [MODE_PAGE_APPLE_VENDOR] = (1 << TYPE_ROM),
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-09 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20240109084052epcms2p2895e6b6bbd84880df6dac43166491f14@epcms2p2>
2024-01-09 8:40 ` [PATCH 2/3] hw/scsi: add mode sense support for zbc device Daejun Park
2023-12-08 6:09 [PATCH 0/3] Support for Zoned UFS Daejun Park
[not found] ` <CGME20231208060902epcms2p3810b29fefbddaf16a7f3f2758cf218ba@epcms2p4>
2023-12-08 6:20 ` [PATCH 2/3] hw/scsi: add mode sense support for zbc device Daejun Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).