qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
To: Philippe Mathieu-Daud? <philmd@linaro.org>
Cc: <peter.maydell@linaro.org>, <alex.bennee@linaro.org>,
	<qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>,
	<quic_tsoni@quicinc.com>, <quic_pheragu@quicinc.com>,
	<quic_eberman@quicinc.com>, <quic_yvasi@quicinc.com>,
	<quic_cvanscha@quicinc.com>, <quic_mnalajal@quicinc.com>
Subject: Re: [RFC/PATCH v1 07/11] gunyah: Specify device-tree location
Date: Wed, 10 Jan 2024 14:06:16 +0530	[thread overview]
Message-ID: <20240110083616.GC1649721@quicinc.com> (raw)
In-Reply-To: <282dc91e-0f56-4a74-9110-ea4824e6d61d@linaro.org>

* Philippe Mathieu-Daud? <philmd@linaro.org> [2024-01-09 14:36:12]:

> > +#include "qemu/osdep.h"
> > +#include "qemu/error-report.h"
> > +#include "sysemu/gunyah.h"
> > +#include "sysemu/gunyah_int.h"
> > +#include "linux-headers/linux/gunyah.h"
> I'm getting on macOS:
> 
> In file included from ../../target/arm/gunyah.c:13:
> linux-headers/linux/gunyah.h:13:10: fatal error: 'linux/types.h' file not
> found
> #include <linux/types.h>
>          ^~~~~~~~~~~~~~~
> 1 error generated.
> 
> Maybe we need the following change?
> 
> -- >8 --
> diff --git a/meson.build b/meson.build
> index 6ded60063e..fb20ca04d1 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -712,5 +712,5 @@ endif
> 
>  gunyah = not_found
> -if get_option('gunyah').allowed()
> +if get_option('gunyah').allowed() and host_os == 'linux'
>      accelerators += 'CONFIG_GUNYAH'
>  endif

Ok sure will include that change in my next version.

- vatsa


  reply	other threads:[~2024-01-10  8:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  9:00 [RFC/PATCH v1 00/11] Gunyah hypervisor support Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 01/11] gunyah: UAPI header (NOT FOR MERGE) Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 02/11] gunyah: Basic support Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 03/11] gunyah: Add VM properties Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 04/11] gunyah: Support memory assignment Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 05/11] gunyah: Add IRQFD and IOEVENTFD functions Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 06/11] gunyah: Add gicv3 interrupt controller Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 07/11] gunyah: Specify device-tree location Srivatsa Vaddagiri
2024-01-09 13:31   ` Philippe Mathieu-Daudé
2024-01-10  8:34     ` Srivatsa Vaddagiri
2024-01-10 23:07       ` Alex Bennée
2024-01-09 13:36   ` Philippe Mathieu-Daudé
2024-01-10  8:36     ` Srivatsa Vaddagiri [this message]
2024-01-09  9:00 ` [RFC/PATCH v1 08/11] gunyah: Customize device-tree Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 09/11] gunyah: CPU execution loop Srivatsa Vaddagiri
2024-01-10 15:49   ` Philippe Mathieu-Daudé
2024-01-10 15:53   ` Philippe Mathieu-Daudé
2024-01-09  9:00 ` [RFC/PATCH v1 10/11] gunyah: Workarounds (NOT FOR MERGE) Srivatsa Vaddagiri
2024-01-09  9:00 ` [RFC/PATCH v1 11/11] gunyah: Documentation Srivatsa Vaddagiri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110083616.GC1649721@quicinc.com \
    --to=quic_svaddagi@quicinc.com \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_cvanscha@quicinc.com \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_mnalajal@quicinc.com \
    --cc=quic_pheragu@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=quic_yvasi@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).