* [PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h'
@ 2024-01-11 16:24 Philippe Mathieu-Daudé
2024-01-11 21:50 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-11 16:24 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Richard Henderson, Philippe Mathieu-Daudé
Due to missing headers, when including "tb-jmp-cache.h" we might get:
accel/tcg/tb-jmp-cache.h:21:21: error: field ‘rcu’ has incomplete type
21 | struct rcu_head rcu;
| ^~~
accel/tcg/tb-jmp-cache.h:24:9: error: unknown type name ‘vaddr’
24 | vaddr pc;
| ^~~~~
Add the missing "qemu/rcu.h" and "exec/cpu-common.h" headers.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
accel/tcg/tb-jmp-cache.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/accel/tcg/tb-jmp-cache.h b/accel/tcg/tb-jmp-cache.h
index bb424c8a05..b13a02e45d 100644
--- a/accel/tcg/tb-jmp-cache.h
+++ b/accel/tcg/tb-jmp-cache.h
@@ -9,6 +9,9 @@
#ifndef ACCEL_TCG_TB_JMP_CACHE_H
#define ACCEL_TCG_TB_JMP_CACHE_H
+#include "qemu/rcu.h"
+#include "exec/cpu-common.h"
+
#define TB_JMP_CACHE_BITS 12
#define TB_JMP_CACHE_SIZE (1 << TB_JMP_CACHE_BITS)
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h'
2024-01-11 16:24 [PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h' Philippe Mathieu-Daudé
@ 2024-01-11 21:50 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2024-01-11 21:50 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Paolo Bonzini
On 1/12/24 03:24, Philippe Mathieu-Daudé wrote:
> Due to missing headers, when including "tb-jmp-cache.h" we might get:
>
> accel/tcg/tb-jmp-cache.h:21:21: error: field ‘rcu’ has incomplete type
> 21 | struct rcu_head rcu;
> | ^~~
> accel/tcg/tb-jmp-cache.h:24:9: error: unknown type name ‘vaddr’
> 24 | vaddr pc;
> | ^~~~~
>
> Add the missing "qemu/rcu.h" and "exec/cpu-common.h" headers.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
> ---
> accel/tcg/tb-jmp-cache.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/accel/tcg/tb-jmp-cache.h b/accel/tcg/tb-jmp-cache.h
> index bb424c8a05..b13a02e45d 100644
> --- a/accel/tcg/tb-jmp-cache.h
> +++ b/accel/tcg/tb-jmp-cache.h
> @@ -9,6 +9,9 @@
> #ifndef ACCEL_TCG_TB_JMP_CACHE_H
> #define ACCEL_TCG_TB_JMP_CACHE_H
>
> +#include "qemu/rcu.h"
> +#include "exec/cpu-common.h"
> +
> #define TB_JMP_CACHE_BITS 12
> #define TB_JMP_CACHE_SIZE (1 << TB_JMP_CACHE_BITS)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-11 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-11 16:24 [PATCH] accel/tcg: Include missing headers to 'tb-jmp-cache.h' Philippe Mathieu-Daudé
2024-01-11 21:50 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).