From: deller@kernel.org
To: qemu-devel@nongnu.org
Cc: Helge Deller <deller@gmx.de>,
Richard Henderson <richard.henderson@linaro.org>,
Bruno Haible <bruno@clisp.org>
Subject: [PULL 06/10] target/hppa: Avoid accessing %gr0 when raising exception
Date: Sat, 13 Jan 2024 06:57:24 +0100 [thread overview]
Message-ID: <20240113055729.4480-7-deller@kernel.org> (raw)
In-Reply-To: <20240113055729.4480-1-deller@kernel.org>
From: Helge Deller <deller@gmx.de>
The value of unwind_breg may reference register %r0, but we need to avoid
accessing gr0 directly and use the value 0 instead.
At runtime I've seen unwind_breg being zero with the Linux kernel when
rfi is used to jump to smp_callin().
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Bruno Haible <bruno@clisp.org>
---
target/hppa/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c
index 4c28c58ee9..1387f4a64b 100644
--- a/target/hppa/mem_helper.c
+++ b/target/hppa/mem_helper.c
@@ -341,7 +341,7 @@ raise_exception_with_ior(CPUHPPAState *env, int excp, uintptr_t retaddr,
cpu_restore_state(cs, retaddr);
- b = env->gr[env->unwind_breg];
+ b = env->unwind_breg ? env->gr[env->unwind_breg] : 0;
b >>= (env->psw & PSW_W ? 62 : 30);
env->cr[CR_IOR] |= b << 62;
--
2.43.0
next prev parent reply other threads:[~2024-01-13 5:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 5:57 [PULL 00/10] Hppa fixes 8.2 patches deller
2024-01-13 5:57 ` [PULL 01/10] hw/hppa/machine: Allow up to 3840 MB total memory deller
2024-01-13 5:57 ` [PULL 02/10] hw/hppa/machine: Disable default devices with --nodefaults option deller
2024-02-02 4:22 ` Guenter Roeck
2024-02-02 9:54 ` Helge Deller
2024-02-02 18:04 ` Guenter Roeck
2024-02-02 19:26 ` Helge Deller
2024-02-04 19:26 ` Guenter Roeck
2024-01-13 5:57 ` [PULL 03/10] hw/pci-host/astro: Add missing astro & elroy registers for NetBSD deller
2024-01-13 5:57 ` [PULL 04/10] target/hppa: Fix PDC address translation on PA2.0 with PSW.W=0 deller
2024-01-13 5:57 ` [PULL 05/10] hw/hppa: Move software power button address back into PDC deller
2024-01-13 5:57 ` deller [this message]
2024-01-13 5:57 ` [PULL 07/10] target/hppa: Export function hppa_set_ior_and_isr() deller
2024-01-13 5:57 ` [PULL 08/10] target/hppa: Fix IOR and ISR on unaligned access trap deller
2024-01-13 5:57 ` [PULL 09/10] target/hppa: Fix IOR and ISR on error in probe deller
2024-01-13 5:57 ` [PULL 10/10] target/hppa: Update SeaBIOS-hppa to version 15 deller
2024-01-16 16:33 ` [PULL 00/10] Hppa fixes 8.2 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240113055729.4480-7-deller@kernel.org \
--to=deller@kernel.org \
--cc=bruno@clisp.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).