qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: peterx@redhat.com
To: qemu-devel@nongnu.org
Cc: Prasad Pandit <ppandit@redhat.com>,
	peterx@redhat.com, Fabiano Rosas <farosas@suse.de>,
	Bandan Das <bdas@redhat.com>, Julia Suvorova <jusual@redhat.com>
Subject: [PATCH 3/3] analyze-migration.py: Remove trick on parsing ramblocks
Date: Wed, 17 Jan 2024 15:58:48 +0800	[thread overview]
Message-ID: <20240117075848.139045-4-peterx@redhat.com> (raw)
In-Reply-To: <20240117075848.139045-1-peterx@redhat.com>

From: Peter Xu <peterx@redhat.com>

RAM_SAVE_FLAG_MEM_SIZE contains the total length of ramblock idstr to know
whether scanning of ramblocks is complete.  Drop the trick.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 scripts/analyze-migration.py | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/scripts/analyze-migration.py b/scripts/analyze-migration.py
index a39dfb8766..8a254a5b6a 100755
--- a/scripts/analyze-migration.py
+++ b/scripts/analyze-migration.py
@@ -151,17 +151,12 @@ def read(self):
             addr &= ~(self.TARGET_PAGE_SIZE - 1)
 
             if flags & self.RAM_SAVE_FLAG_MEM_SIZE:
-                while True:
+                total_length = addr
+                while total_length > 0:
                     namelen = self.file.read8()
-                    # We assume that no RAM chunk is big enough to ever
-                    # hit the first byte of the address, so when we see
-                    # a zero here we know it has to be an address, not the
-                    # length of the next block.
-                    if namelen == 0:
-                        self.file.file.seek(-1, 1)
-                        break
                     self.name = self.file.readstr(len = namelen)
                     len = self.file.read64()
+                    total_length -= len
                     self.sizeinfo[self.name] = '0x%016x' % len
                     if self.write_memory:
                         print(self.name)
-- 
2.43.0



  parent reply	other threads:[~2024-01-17  8:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  7:58 [PATCH 0/3] migration: some small cleanups peterx
2024-01-17  7:58 ` [PATCH 1/3] migration: Make threshold_size an uint64_t peterx
2024-01-17  8:09   ` Philippe Mathieu-Daudé
2024-01-19 13:26   ` Fabiano Rosas
2024-01-17  7:58 ` [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact() peterx
2024-01-19 13:25   ` Fabiano Rosas
2024-03-20 17:51   ` Nina Schoetterl-Glausch
2024-03-20 18:05     ` Nina Schoetterl-Glausch
2024-03-20 18:57     ` Peter Xu
2024-03-20 19:21       ` Nina Schoetterl-Glausch
2024-03-20 19:46         ` Peter Xu
2024-03-20 20:45           ` Peter Xu
2024-01-17  7:58 ` peterx [this message]
2024-01-19 13:23   ` [PATCH 3/3] analyze-migration.py: Remove trick on parsing ramblocks Fabiano Rosas
2024-01-20  2:36 ` [PATCH 0/3] migration: some small cleanups Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240117075848.139045-4-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=bdas@redhat.com \
    --cc=farosas@suse.de \
    --cc=jusual@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).