From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
jean-philippe@linaro.org, alex.williamson@redhat.com,
peter.maydell@linaro.org, zhenzhong.duan@intel.com,
peterx@redhat.com, yanghliu@redhat.com, pbonzini@redhat.com
Cc: mst@redhat.com, clg@redhat.com
Subject: [RFC 1/7] hw/pci: Introduce PCIIOMMUOps::set_host_iova_regions
Date: Wed, 17 Jan 2024 09:02:05 +0100 [thread overview]
Message-ID: <20240117080414.316890-2-eric.auger@redhat.com> (raw)
In-Reply-To: <20240117080414.316890-1-eric.auger@redhat.com>
This new callback will be used to convey usable IOVA regions
from VFIO-PCI devices to vIOMMUS (esp. virtio-iommu). The advantage
is that this callback can be called very early, once the device has
is known to be protected by a vIOMMU, after the get_address_space()
has been called by the parent device. Current solution to convey
IOVA regions relies on IOMMU MR callbacks but this requires an
IOMMU MR to be connected with the VFIO-PCI device which generally
comes with the enablement of the IOMMU MR (vIOMMU protection activated).
The downside is that is comes pretty late and in case of virtio-iommu,
after the probe.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
include/hw/pci/pci.h | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index fa6313aabc..63c018b35a 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -385,6 +385,21 @@ typedef struct PCIIOMMUOps {
* @devfn: device and function number
*/
AddressSpace * (*get_address_space)(PCIBus *bus, void *opaque, int devfn);
+
+ /**
+ * @set_host_iova_ranges: convey the usable iova ranges for a given device
+ *
+ * Optional callback which returns 0 on success or an error value if any
+ * should be called after @get_address_space()
+ *
+ * @bus: the #PCIBus being accessed.
+ * @opaque: the data passed to pci_setup_iommu().
+ * @devfn: device and function number
+ * @iova_ranges: list of IOVA ranges usable by the device
+ * @errp: error handle
+ */
+ int (*set_host_iova_ranges)(PCIBus *bus, void *opaque, int devfn,
+ GList *iova_ranges, Error **errp);
} PCIIOMMUOps;
AddressSpace *pci_device_iommu_address_space(PCIDevice *dev);
--
2.41.0
next prev parent reply other threads:[~2024-01-17 8:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 8:02 [RFC 0/7] VIRTIO-IOMMU/VFIO: Fix host iommu geometry handling for hotplugged devices Eric Auger
2024-01-17 8:02 ` Eric Auger [this message]
2024-01-17 8:02 ` [RFC 2/7] hw/pci: Introduce pci_device_iommu_bus Eric Auger
2024-01-18 7:32 ` Duan, Zhenzhong
2024-01-17 8:02 ` [RFC 3/7] vfio/pci: Pass the usable IOVA ranges through PCIIOMMUOps Eric Auger
2024-01-17 8:02 ` [RFC 4/7] virtio-iommu: Implement PCIIOMMUOps set_host_resv_regions Eric Auger
2024-01-18 7:43 ` Duan, Zhenzhong
2024-01-18 12:25 ` Eric Auger
2024-01-19 7:00 ` Duan, Zhenzhong
2024-01-22 7:17 ` Duan, Zhenzhong
2024-01-17 8:02 ` [RFC 5/7] virtio-iommu: Remove the implementation of iommu_set_iova_ranges Eric Auger
2024-01-17 8:02 ` [RFC 6/7] hw/vfio: Remove memory_region_iommu_set_iova_ranges() call Eric Auger
2024-01-17 8:02 ` [RFC 7/7] memory: Remove IOMMU MR iommu_set_iova_range API Eric Auger
2024-01-18 7:10 ` [RFC 0/7] VIRTIO-IOMMU/VFIO: Fix host iommu geometry handling for hotplugged devices Duan, Zhenzhong
2024-01-18 9:43 ` Eric Auger
2024-01-19 6:46 ` Duan, Zhenzhong
2024-01-25 18:48 ` Jean-Philippe Brucker
2024-01-29 16:38 ` Eric Auger
2024-01-30 18:22 ` Jean-Philippe Brucker
2024-01-31 11:22 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117080414.316890-2-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yanghliu@redhat.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).