qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	jean-philippe@linaro.org, alex.williamson@redhat.com,
	peter.maydell@linaro.org, zhenzhong.duan@intel.com,
	peterx@redhat.com, yanghliu@redhat.com, pbonzini@redhat.com
Cc: mst@redhat.com, clg@redhat.com
Subject: [RFC 7/7] memory: Remove IOMMU MR iommu_set_iova_range API
Date: Wed, 17 Jan 2024 09:02:11 +0100	[thread overview]
Message-ID: <20240117080414.316890-8-eric.auger@redhat.com> (raw)
In-Reply-To: <20240117080414.316890-1-eric.auger@redhat.com>

Since the host IOVA ranges are now passed through the
PCIIOMMUOps set_host_resv_regions and we have removed
the only implementation of iommu_set_iova_range() in
the virtio-iommu and the only call site in vfio/common,
let's retire the IOMMU MR API and its memory wrapper.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 include/exec/memory.h | 32 --------------------------------
 system/memory.c       | 13 -------------
 2 files changed, 45 deletions(-)

diff --git a/include/exec/memory.h b/include/exec/memory.h
index 177be23db7..7677b572c5 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -527,26 +527,6 @@ struct IOMMUMemoryRegionClass {
      int (*iommu_set_page_size_mask)(IOMMUMemoryRegion *iommu,
                                      uint64_t page_size_mask,
                                      Error **errp);
-    /**
-     * @iommu_set_iova_ranges:
-     *
-     * Propagate information about the usable IOVA ranges for a given IOMMU
-     * memory region. Used for example to propagate host physical device
-     * reserved memory region constraints to the virtual IOMMU.
-     *
-     * Optional method: if this method is not provided, then the default IOVA
-     * aperture is used.
-     *
-     * @iommu: the IOMMUMemoryRegion
-     *
-     * @iova_ranges: list of ordered IOVA ranges (at least one range)
-     *
-     * Returns 0 on success, or a negative error. In case of failure, the error
-     * object must be created.
-     */
-     int (*iommu_set_iova_ranges)(IOMMUMemoryRegion *iommu,
-                                  GList *iova_ranges,
-                                  Error **errp);
 };
 
 typedef struct RamDiscardListener RamDiscardListener;
@@ -1896,18 +1876,6 @@ int memory_region_iommu_set_page_size_mask(IOMMUMemoryRegion *iommu_mr,
                                            uint64_t page_size_mask,
                                            Error **errp);
 
-/**
- * memory_region_iommu_set_iova_ranges - Set the usable IOVA ranges
- * for a given IOMMU MR region
- *
- * @iommu: IOMMU memory region
- * @iova_ranges: list of ordered IOVA ranges (at least one range)
- * @errp: pointer to Error*, to store an error if it happens.
- */
-int memory_region_iommu_set_iova_ranges(IOMMUMemoryRegion *iommu,
-                                        GList *iova_ranges,
-                                        Error **errp);
-
 /**
  * memory_region_name: get a memory region's name
  *
diff --git a/system/memory.c b/system/memory.c
index a229a79988..b2fb12f87f 100644
--- a/system/memory.c
+++ b/system/memory.c
@@ -1909,19 +1909,6 @@ int memory_region_iommu_set_page_size_mask(IOMMUMemoryRegion *iommu_mr,
     return ret;
 }
 
-int memory_region_iommu_set_iova_ranges(IOMMUMemoryRegion *iommu_mr,
-                                        GList *iova_ranges,
-                                        Error **errp)
-{
-    IOMMUMemoryRegionClass *imrc = IOMMU_MEMORY_REGION_GET_CLASS(iommu_mr);
-    int ret = 0;
-
-    if (imrc->iommu_set_iova_ranges) {
-        ret = imrc->iommu_set_iova_ranges(iommu_mr, iova_ranges, errp);
-    }
-    return ret;
-}
-
 int memory_region_register_iommu_notifier(MemoryRegion *mr,
                                           IOMMUNotifier *n, Error **errp)
 {
-- 
2.41.0



  parent reply	other threads:[~2024-01-17  8:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17  8:02 [RFC 0/7] VIRTIO-IOMMU/VFIO: Fix host iommu geometry handling for hotplugged devices Eric Auger
2024-01-17  8:02 ` [RFC 1/7] hw/pci: Introduce PCIIOMMUOps::set_host_iova_regions Eric Auger
2024-01-17  8:02 ` [RFC 2/7] hw/pci: Introduce pci_device_iommu_bus Eric Auger
2024-01-18  7:32   ` Duan, Zhenzhong
2024-01-17  8:02 ` [RFC 3/7] vfio/pci: Pass the usable IOVA ranges through PCIIOMMUOps Eric Auger
2024-01-17  8:02 ` [RFC 4/7] virtio-iommu: Implement PCIIOMMUOps set_host_resv_regions Eric Auger
2024-01-18  7:43   ` Duan, Zhenzhong
2024-01-18 12:25     ` Eric Auger
2024-01-19  7:00       ` Duan, Zhenzhong
2024-01-22  7:17         ` Duan, Zhenzhong
2024-01-17  8:02 ` [RFC 5/7] virtio-iommu: Remove the implementation of iommu_set_iova_ranges Eric Auger
2024-01-17  8:02 ` [RFC 6/7] hw/vfio: Remove memory_region_iommu_set_iova_ranges() call Eric Auger
2024-01-17  8:02 ` Eric Auger [this message]
2024-01-18  7:10 ` [RFC 0/7] VIRTIO-IOMMU/VFIO: Fix host iommu geometry handling for hotplugged devices Duan, Zhenzhong
2024-01-18  9:43   ` Eric Auger
2024-01-19  6:46     ` Duan, Zhenzhong
2024-01-25 18:48     ` Jean-Philippe Brucker
2024-01-29 16:38       ` Eric Auger
2024-01-30 18:22         ` Jean-Philippe Brucker
2024-01-31 11:22           ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240117080414.316890-8-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=jean-philippe@linaro.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yanghliu@redhat.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).