From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B2B2C47422 for ; Wed, 17 Jan 2024 08:40:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQ1Rx-0006e8-Fi; Wed, 17 Jan 2024 03:39:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ1Rp-0006bb-Oc for qemu-devel@nongnu.org; Wed, 17 Jan 2024 03:38:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ1Rm-0000V2-Df for qemu-devel@nongnu.org; Wed, 17 Jan 2024 03:38:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705480732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Af2rR5ZJLoauR5bWUoT60gMoi3cfXo5P5ZHhPEaQHTs=; b=TVUypnF62BULsEakdaxObCTWK29Iw+8V/2LNi4FAxiNGrunrE+Rh8e6TfjNXP0n/pq11wF QR4xQtcxPeY8AWC0JJRCJW1pcI850B8rXQxHPu/knMy6z7jG7wr7jf1oK/GWGmDHsi68mB N2YknB7VBnfSv5Qi3ep6x+4FMkHFnm0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-c76ZXjiyOyC33SFNQSUYgQ-1; Wed, 17 Jan 2024 03:38:49 -0500 X-MC-Unique: c76ZXjiyOyC33SFNQSUYgQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e417aa684so79234255e9.3 for ; Wed, 17 Jan 2024 00:38:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705480729; x=1706085529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Af2rR5ZJLoauR5bWUoT60gMoi3cfXo5P5ZHhPEaQHTs=; b=UDSToR5eW6mmD7F4Zqi06w6Y13IuxBeaGM9qJA+7nqmMcxOSt58CpGzxeYqwiAmvYD hnSqSNO0OjuR+wAOTizzjwoF/aW4fukDeNfMLuzG4ZCUKKz/zl6HS5VThIp+NnWB54B0 nMGSV4FoebFEZ3jwDa53Np1/+B4+TYnnk6QmJXAN99v0Ftow9kylowt8NuArm27NTnvu lz24UUZnwUXNH8TijwJv+5Y/ap2040WfCuOHY/pL6H6zh0N0RnIRD3rAVXmoqVlUM6qD tBTX8jJJVoBwl7H/gx5kreBn92xJbVelk2J6Gkjv/w2NL2rElxrT/s7O5HCpCAljQKrA A01Q== X-Gm-Message-State: AOJu0Yz4dzF6a7kGZBkMLNSuTQboisGeywvzXacUuzkcBB1I2lcN1cjb 8ZbU1MkEvRFcTX6uonlg7hPRWk7UqU1tpdrzZnLkRidlKhsWORXE3ZjagHPPGUfaMqhboJNJmW3 BJ+PCic4nO2e1YjqSP9QdN3g= X-Received: by 2002:a05:600c:2295:b0:40d:5fc7:7a74 with SMTP id 21-20020a05600c229500b0040d5fc77a74mr4173438wmf.188.1705480728831; Wed, 17 Jan 2024 00:38:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQMRJID9F4DpMj3FPFgPCQZ2xG6DkPgu1J8erQzLI839t8dzYiQaanPIX946cIbXzTnQGnCw== X-Received: by 2002:a05:600c:2295:b0:40d:5fc7:7a74 with SMTP id 21-20020a05600c229500b0040d5fc77a74mr4173429wmf.188.1705480728508; Wed, 17 Jan 2024 00:38:48 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id fm23-20020a05600c0c1700b0040e612aa673sm21607653wmb.17.2024.01.17.00.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 00:38:48 -0800 (PST) Date: Wed, 17 Jan 2024 09:38:47 +0100 From: Igor Mammedov To: Felix Wu Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH 1/1] SMBIOS type 8 should use T8_BASE. Message-ID: <20240117093847.5dc92824@imammedo.users.ipa.redhat.com> In-Reply-To: <20240111192522.2795498-2-flwu@google.com> References: <20240111192522.2795498-1-flwu@google.com> <20240111192522.2795498-2-flwu@google.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.39; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.806, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 11 Jan 2024 19:25:22 +0000 Felix Wu wrote: it is missing Signed-off tag a minimum, and also commit message should describe in more detail what's wrong and what's breaks and how it's being fixed with references to spec preferably. please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html for requirements to commit message of the patch. > --- > hw/smbios/smbios.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c > index 2a90601ac5..7dda84b284 100644 > --- a/hw/smbios/smbios.c > +++ b/hw/smbios/smbios.c > @@ -591,6 +591,7 @@ bool smbios_skip_table(uint8_t type, bool required_table) > #define T2_BASE 0x200 > #define T3_BASE 0x300 > #define T4_BASE 0x400 > +#define T8_BASE 0x800 > #define T11_BASE 0xe00 > > #define T16_BASE 0x1000 > @@ -775,7 +776,7 @@ static void smbios_build_type_8_table(void) > struct type8_instance *t8; > > QTAILQ_FOREACH(t8, &type8, next) { > - SMBIOS_BUILD_TABLE_PRE(8, T0_BASE + instance, true); > + SMBIOS_BUILD_TABLE_PRE(8, T8_BASE + instance, true); we can't do that unconditionally as it will break live migration where firmware reading this might get part of broken tables (on source host) and 2nd part of fixed ones (from target host). So we need to use T0_base for old machine types and T8_BASE for default/new machine types. for example see how 'pcmc->smbios_uuid_encoded' is used. unless it's x86 specific, this should be done for affected machine types. > SMBIOS_TABLE_SET_STR(8, internal_reference_str, t8->internal_reference); > SMBIOS_TABLE_SET_STR(8, external_reference_str, t8->external_reference);