qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ppc: really change defaults
@ 2024-01-18 14:14 Nicholas Piggin
  2024-01-18 14:14 ` [PATCH 1/2] ppc/spapr: change pseries machine default to POWER10 CPU Nicholas Piggin
  2024-01-18 14:14 ` [PATCH 2/2] ppc/pnv: Change powernv default to powernv10 Nicholas Piggin
  0 siblings, 2 replies; 5+ messages in thread
From: Nicholas Piggin @ 2024-01-18 14:14 UTC (permalink / raw)
  To: qemu-ppc
  Cc: Nicholas Piggin, Cédric Le Goater, Frédéric Barrat,
	Daniel Henrique Barboza, David Gibson, Harsh Prateek Bora,
	qemu-devel

Oops, these two should be with the previous series too.

Thanks,
Nick

Nicholas Piggin (2):
  ppc/spapr: change pseries machine default to POWER10 CPU
  ppc/pnv: Change powernv default to powernv10

 hw/ppc/pnv.c   | 4 ++--
 hw/ppc/spapr.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.42.0



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ppc/spapr: change pseries machine default to POWER10 CPU
  2024-01-18 14:14 [PATCH 0/2] ppc: really change defaults Nicholas Piggin
@ 2024-01-18 14:14 ` Nicholas Piggin
  2024-01-19  5:46   ` Harsh Prateek Bora
  2024-01-18 14:14 ` [PATCH 2/2] ppc/pnv: Change powernv default to powernv10 Nicholas Piggin
  1 sibling, 1 reply; 5+ messages in thread
From: Nicholas Piggin @ 2024-01-18 14:14 UTC (permalink / raw)
  To: qemu-ppc
  Cc: Nicholas Piggin, Cédric Le Goater, Frédéric Barrat,
	Daniel Henrique Barboza, David Gibson, Harsh Prateek Bora,
	qemu-devel

POWER10 is the latest pseries CPU.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/ppc/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index e8dabc8614..021b1a00e1 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4675,7 +4675,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data)
 
     smc->dr_lmb_enabled = true;
     smc->update_dt_enabled = true;
-    mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power9_v2.2");
+    mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
     mc->has_hotpluggable_cpus = true;
     mc->nvdimm_supported = true;
     smc->resize_hpt_default = SPAPR_RESIZE_HPT_ENABLED;
-- 
2.42.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ppc/pnv: Change powernv default to powernv10
  2024-01-18 14:14 [PATCH 0/2] ppc: really change defaults Nicholas Piggin
  2024-01-18 14:14 ` [PATCH 1/2] ppc/spapr: change pseries machine default to POWER10 CPU Nicholas Piggin
@ 2024-01-18 14:14 ` Nicholas Piggin
  2024-01-19  9:01   ` Cédric Le Goater
  1 sibling, 1 reply; 5+ messages in thread
From: Nicholas Piggin @ 2024-01-18 14:14 UTC (permalink / raw)
  To: qemu-ppc
  Cc: Nicholas Piggin, Cédric Le Goater, Frédéric Barrat,
	Daniel Henrique Barboza, David Gibson, Harsh Prateek Bora,
	qemu-devel

POWER10 is the latest IBM Power machine. Although it is not offered in
"OPAL mode" (i.e., powernv configuration), so there is a case that it
should remain at powernv9, most of the development work is going into
powernv10 at the moment.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 hw/ppc/pnv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 0297871bdd..b949398689 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -2242,8 +2242,6 @@ static void pnv_machine_power9_class_init(ObjectClass *oc, void *data)
 
     xfc->match_nvt = pnv_match_nvt;
 
-    mc->alias = "powernv";
-
     pmc->compat = compat;
     pmc->compat_size = sizeof(compat);
     pmc->dt_power_mgt = pnv_dt_power_mgt;
@@ -2267,6 +2265,8 @@ static void pnv_machine_power10_class_init(ObjectClass *oc, void *data)
     mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
     compat_props_add(mc->compat_props, phb_compat, G_N_ELEMENTS(phb_compat));
 
+    mc->alias = "powernv";
+
     pmc->compat = compat;
     pmc->compat_size = sizeof(compat);
     pmc->dt_power_mgt = pnv_dt_power_mgt;
-- 
2.42.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ppc/spapr: change pseries machine default to POWER10 CPU
  2024-01-18 14:14 ` [PATCH 1/2] ppc/spapr: change pseries machine default to POWER10 CPU Nicholas Piggin
@ 2024-01-19  5:46   ` Harsh Prateek Bora
  0 siblings, 0 replies; 5+ messages in thread
From: Harsh Prateek Bora @ 2024-01-19  5:46 UTC (permalink / raw)
  To: Nicholas Piggin, qemu-ppc
  Cc: Cédric Le Goater, Frédéric Barrat,
	Daniel Henrique Barboza, David Gibson, qemu-devel



On 1/18/24 19:44, Nicholas Piggin wrote:
> POWER10 is the latest pseries CPU.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   hw/ppc/spapr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index e8dabc8614..021b1a00e1 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -4675,7 +4675,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data)
>   
>       smc->dr_lmb_enabled = true;
>       smc->update_dt_enabled = true;
> -    mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power9_v2.2");
> +    mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
>       mc->has_hotpluggable_cpus = true;
>       mc->nvdimm_supported = true;
>       smc->resize_hpt_default = SPAPR_RESIZE_HPT_ENABLED;


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ppc/pnv: Change powernv default to powernv10
  2024-01-18 14:14 ` [PATCH 2/2] ppc/pnv: Change powernv default to powernv10 Nicholas Piggin
@ 2024-01-19  9:01   ` Cédric Le Goater
  0 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2024-01-19  9:01 UTC (permalink / raw)
  To: Nicholas Piggin, qemu-ppc
  Cc: Frédéric Barrat, Daniel Henrique Barboza, David Gibson,
	Harsh Prateek Bora, qemu-devel

On 1/18/24 15:14, Nicholas Piggin wrote:
> POWER10 is the latest IBM Power machine. Although it is not offered in
> "OPAL mode" (i.e., powernv configuration), so there is a case that it
> should remain at powernv9, most of the development work is going into
> powernv10 at the moment.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

May be we could drop support for power10_v1.0 and power9_v1.0 ? These
were bringup CPUs.

Anyhow,

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   hw/ppc/pnv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 0297871bdd..b949398689 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -2242,8 +2242,6 @@ static void pnv_machine_power9_class_init(ObjectClass *oc, void *data)
>   
>       xfc->match_nvt = pnv_match_nvt;
>   
> -    mc->alias = "powernv";
> -
>       pmc->compat = compat;
>       pmc->compat_size = sizeof(compat);
>       pmc->dt_power_mgt = pnv_dt_power_mgt;
> @@ -2267,6 +2265,8 @@ static void pnv_machine_power10_class_init(ObjectClass *oc, void *data)
>       mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power10_v2.0");
>       compat_props_add(mc->compat_props, phb_compat, G_N_ELEMENTS(phb_compat));
>   
> +    mc->alias = "powernv";
> +
>       pmc->compat = compat;
>       pmc->compat_size = sizeof(compat);
>       pmc->dt_power_mgt = pnv_dt_power_mgt;



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-19  9:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-18 14:14 [PATCH 0/2] ppc: really change defaults Nicholas Piggin
2024-01-18 14:14 ` [PATCH 1/2] ppc/spapr: change pseries machine default to POWER10 CPU Nicholas Piggin
2024-01-19  5:46   ` Harsh Prateek Bora
2024-01-18 14:14 ` [PATCH 2/2] ppc/pnv: Change powernv default to powernv10 Nicholas Piggin
2024-01-19  9:01   ` Cédric Le Goater

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).