qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Kasireddy <vivek.kasireddy@intel.com>
To: qemu-devel@nongnu.org
Cc: "Vivek Kasireddy" <vivek.kasireddy@intel.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Frediano Ziglio" <freddy77@gmail.com>,
	"Dongwon Kim" <dongwon.kim@intel.com>
Subject: [PATCH v1 4/7] ui/console-gl: Add an option to override a surface's glformat
Date: Fri, 19 Jan 2024 16:30:10 -0800	[thread overview]
Message-ID: <20240120003013.1829757-5-vivek.kasireddy@intel.com> (raw)
In-Reply-To: <20240120003013.1829757-1-vivek.kasireddy@intel.com>

In some cases where a UI component (e.g, Spice) needs to choose
a particular glformat for a surface while creating a texture,
this new GLenum provides an option to do so. One situation
where this needs to be done is when the Host endianness is
causing issues such as interchanged R and B channels.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Frediano Ziglio <freddy77@gmail.com>
Cc: Dongwon Kim <dongwon.kim@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
---
 include/ui/surface.h | 1 +
 ui/console-gl.c      | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/include/ui/surface.h b/include/ui/surface.h
index 4244e0ca4a..a39fee55a2 100644
--- a/include/ui/surface.h
+++ b/include/ui/surface.h
@@ -20,6 +20,7 @@ typedef struct DisplaySurface {
     uint8_t flags;
 #ifdef CONFIG_OPENGL
     GLenum glformat;
+    GLenum target_glformat;
     GLenum gltype;
     GLuint texture;
 #endif
diff --git a/ui/console-gl.c b/ui/console-gl.c
index 103b954017..dee317f42c 100644
--- a/ui/console-gl.c
+++ b/ui/console-gl.c
@@ -72,6 +72,12 @@ void surface_gl_create_texture(QemuGLShader *gls,
         g_assert_not_reached();
     }
 
+    /* The caller wants to override the glformat in some specific cases */
+    if (surface->target_glformat &&
+        surface->target_glformat != surface->glformat) {
+        surface->glformat = surface->target_glformat;
+    }
+
     glGenTextures(1, &surface->texture);
     glEnable(GL_TEXTURE_2D);
     glBindTexture(GL_TEXTURE_2D, surface->texture);
-- 
2.39.2



  parent reply	other threads:[~2024-01-20  0:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20  0:30 [PATCH v1 0/7] ui/spice: Enable gl=on option for non-local or remote clients Vivek Kasireddy
2024-01-20  0:30 ` [PATCH v1 1/7] ui/spice: Add an option for users to provide a preferred codec Vivek Kasireddy
2024-01-22  8:41   ` Marc-André Lureau
2024-01-26  7:41     ` Kasireddy, Vivek
2024-01-20  0:30 ` [PATCH v1 2/7] ui/spice: Enable gl=on option for non-local or remote clients Vivek Kasireddy
2024-01-22  8:40   ` Marc-André Lureau
2024-01-26  7:38     ` Kasireddy, Vivek
2024-01-20  0:30 ` [PATCH v1 3/7] ui/spice: Submit the gl_draw requests at 60 FPS for " Vivek Kasireddy
2024-01-22  8:40   ` Marc-André Lureau
2024-01-26  7:38     ` Kasireddy, Vivek
2024-01-20  0:30 ` Vivek Kasireddy [this message]
2024-01-20  0:30 ` [PATCH v1 5/7] ui/spice: Override the surface's glformat when gl=on is enabled Vivek Kasireddy
2024-01-20  0:30 ` [PATCH v1 6/7] ui/console-gl: Add a helper to create a texture with linear memory layout Vivek Kasireddy
2024-01-20  0:30 ` [PATCH v1 7/7] ui/spice: Create another texture with linear layout when gl=on is enabled Vivek Kasireddy
2024-01-22  8:40   ` Marc-André Lureau
2024-01-26  7:36     ` Kasireddy, Vivek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240120003013.1829757-5-vivek.kasireddy@intel.com \
    --to=vivek.kasireddy@intel.com \
    --cc=dongwon.kim@intel.com \
    --cc=freddy77@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).