From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10A55C47DAF for ; Mon, 22 Jan 2024 10:01:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRr7F-0003Es-0c; Mon, 22 Jan 2024 05:01:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRr6v-00033t-H8 for qemu-devel@nongnu.org; Mon, 22 Jan 2024 05:01:03 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRr6s-0005iG-8V for qemu-devel@nongnu.org; Mon, 22 Jan 2024 05:00:55 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-40e9d4ab5f3so32707375e9.2 for ; Mon, 22 Jan 2024 02:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1705917653; x=1706522453; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=giTntrrGnwZ3RFDTTXhjHj52B7+z6MrLK0FEOOPyD7o=; b=CcK1jQN1XMRopn7PTNgIO3TkmKL2MhAQ4STeMzrO7f1hxT4vqSDyZb4+CdZt+GBXl3 d4Fo4tMYdWd1El0a8qukIMaKVd9uHcmjnVbPzlMVIO+pX8v6gp2rbsfROr40J95ZqrL7 Rb5sM/pEJbnfEVkSMpwDPVQlH71NdGBoqsnEU7R+V0tAjwLFyikNDL9nRL8KGNwizvKt yUte2k0pZEg7U6IG+lUTWWZlqhynH0YH7xgajYA7SV5CKf0KkjHqzY1ZvBVEUkjua98j K6afiQ1K+rogMGt6aTBdVCc1iUGoCBU0JdVkeeO1uGsBkdj0esQB/gHPbtd87LBfd80d jFyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705917653; x=1706522453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=giTntrrGnwZ3RFDTTXhjHj52B7+z6MrLK0FEOOPyD7o=; b=Anau+imW1m46PbhhYeBokuuizgJlEy0EtfbyUo5Rg6dsrNJ/7q/X3Yc6dsG80g0zU+ JNIHqeEHkw6pV1WBow0gbrS0N9jo1/bBHDw2gjf9biDspZxRRCeQvBQOlem9SsdyvdyK /h8qTqwRF47o978t8MkRxz7R3fs9jkxeVpQ0yfu2ySM7NxlLVJIchm4Vg6s8cMX/icou aA/k/D8hNkSZ7BDZ1lw5kAFL9gsXfnvHMFcsxAlv4RoNAwOYqUldNg6g5VyRjubUTOIc 5eV9cBUin93dZ/StzETt9UIoZG2ykPuLCgg89M482EPSq5orCyg46PHqUcj9GsPB+NB2 7hnQ== X-Gm-Message-State: AOJu0YzcPBHPXx0PRWXwv2WNTvMypJN+SWV+V+ttXWBKyp505OMMxyGw /Ybx4mrCGc1WwJz0DKiWyZSiWXYQiKWp4m3p9HGOAAhi2898o64oX3XawdK2nUk= X-Google-Smtp-Source: AGHT+IHqOgBlQrjJjux94ZxjhHGfFpsl1Ia0wzNgTLlX9kcWKYdnda01RVzn/TCBGBrdYi3cP9MBeQ== X-Received: by 2002:a05:600c:1f86:b0:40e:5118:5046 with SMTP id je6-20020a05600c1f8600b0040e51185046mr2163839wmb.21.1705917652574; Mon, 22 Jan 2024 02:00:52 -0800 (PST) Received: from localhost (2001-1ae9-1c2-4c00-20f-c6b4-1e57-7965.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:20f:c6b4:1e57:7965]) by smtp.gmail.com with ESMTPSA id bg23-20020a05600c3c9700b0040d91fa270fsm38770353wmb.36.2024.01.22.02.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 02:00:52 -0800 (PST) Date: Mon, 22 Jan 2024 11:00:51 +0100 From: Andrew Jones To: Heinrich Schuchardt Cc: Palmer Dabbelt , Alistair Francis , Paolo Bonzini , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , "Michael S . Tsirkin" , Igor Mammedov , Ani Sinha , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH v2 4/4] qemu-options: enable -smbios option on RISC-V Message-ID: <20240122-14abf335500d65fcf11422b6@orel> References: <20231229120724.41383-1-heinrich.schuchardt@canonical.com> <20231229120724.41383-5-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231229120724.41383-5-heinrich.schuchardt@canonical.com> Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=ajones@ventanamicro.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Dec 29, 2023 at 01:07:24PM +0100, Heinrich Schuchardt wrote: > With SMBIOS support added for RISC-V we also should enable the command line > option. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 7bdb414345..5ed82df11f 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2705,7 +2705,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios, > " specify SMBIOS type 17 fields\n" > "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n" > " specify SMBIOS type 41 fields\n", > - QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH) > + QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH | QEMU_ARCH_RISCV) > SRST > ``-smbios file=binary`` > Load SMBIOS entry from binary file. > -- > 2.43.0 > > Reviewed-by: Andrew Jones