qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test
@ 2024-01-24  6:01 Nicholas Piggin
  2024-01-25  9:23 ` Cédric Le Goater
  0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Piggin @ 2024-01-24  6:01 UTC (permalink / raw)
  To: qemu-ppc
  Cc: Nicholas Piggin, Cédric Le Goater, Frédéric Barrat,
	Daniel Henrique Barboza, David Gibson, Harsh Prateek Bora,
	Cleber Rosa, Philippe Mathieu-Daudé,
	Wainer dos Santos Moschetta, Beraldo Leal, qemu-devel

The expected MTD partition detection output does not always appear on
the console, despite the test reaching the boot loader and the string
appearing in dmesg. Possibly due to an init script that quietens the
console output. Using an earlier log message improves reliability.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 tests/avocado/boot_linux_console.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
index 3f0180e1f8..922a9e7b79 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -1368,7 +1368,9 @@ def do_test_ppc64_powernv(self, proc):
         self.wait_for_console_pattern("CPU: " + proc + " generation processor")
         self.wait_for_console_pattern("zImage starting: loaded")
         self.wait_for_console_pattern("Run /init as init process")
-        self.wait_for_console_pattern("Creating 1 MTD partitions")
+        self.wait_for_console_pattern("rtc-opal opal-rtc: setting system clock")
+        # MTD partition detection output is sometimes cut off from console
+        # output, suspect S14silence-console init script.
 
     def test_ppc_powernv8(self):
         """
-- 
2.42.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test
  2024-01-24  6:01 [PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test Nicholas Piggin
@ 2024-01-25  9:23 ` Cédric Le Goater
  0 siblings, 0 replies; 2+ messages in thread
From: Cédric Le Goater @ 2024-01-25  9:23 UTC (permalink / raw)
  To: Nicholas Piggin, qemu-ppc
  Cc: Frédéric Barrat, Daniel Henrique Barboza, David Gibson,
	Harsh Prateek Bora, Cleber Rosa, Philippe Mathieu-Daudé,
	Wainer dos Santos Moschetta, Beraldo Leal, qemu-devel

On 1/24/24 07:01, Nicholas Piggin wrote:
> The expected MTD partition detection output does not always appear on
> the console, despite the test reaching the boot loader and the string
> appearing in dmesg. Possibly due to an init script that quietens the
> console output. Using an earlier log message improves reliability.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>   tests/avocado/boot_linux_console.py | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
> index 3f0180e1f8..922a9e7b79 100644
> --- a/tests/avocado/boot_linux_console.py
> +++ b/tests/avocado/boot_linux_console.py
> @@ -1368,7 +1368,9 @@ def do_test_ppc64_powernv(self, proc):
>           self.wait_for_console_pattern("CPU: " + proc + " generation processor")
>           self.wait_for_console_pattern("zImage starting: loaded")
>           self.wait_for_console_pattern("Run /init as init process")
> -        self.wait_for_console_pattern("Creating 1 MTD partitions")
> +        self.wait_for_console_pattern("rtc-opal opal-rtc: setting system clock")
> +        # MTD partition detection output is sometimes cut off from console
> +        # output, suspect S14silence-console init script.
>   
>       def test_ppc_powernv8(self):
>           """



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-25  9:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24  6:01 [PATCH] tests/avocado: improve flaky ppc/pnv boot_linux_console.py test Nicholas Piggin
2024-01-25  9:23 ` Cédric Le Goater

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).