From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3911FC46CD2 for ; Wed, 24 Jan 2024 13:37:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSdRI-0006jg-L9; Wed, 24 Jan 2024 08:37:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSdRE-0006g2-PR for qemu-devel@nongnu.org; Wed, 24 Jan 2024 08:37:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSdRC-0001jT-Od for qemu-devel@nongnu.org; Wed, 24 Jan 2024 08:37:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706103424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=od6VM9/RvmIKeJ6TC2wZtgEazuqsbs4NThCk6V91RLo=; b=F94BhItXjN9GEOGrYK8936QaA2VKWkboY96ttnHvKPSCZOqr5rzf56PIYQ3QMfykpUCka+ KxYPZh4cvIRRXouEfuGVTYdt0PKI5JrWEm/qXalZ6i4NdVTsgS5VUCT6Jp/00gqvU+qu6P qAbeDjFiqMwW51yK5qy2wIBCc+YRmBA= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-llUm2zo8Np20QXcCIu1ChA-1; Wed, 24 Jan 2024 08:37:03 -0500 X-MC-Unique: llUm2zo8Np20QXcCIu1ChA-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-7bf356bdc2fso585398239f.0 for ; Wed, 24 Jan 2024 05:37:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706103422; x=1706708222; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=od6VM9/RvmIKeJ6TC2wZtgEazuqsbs4NThCk6V91RLo=; b=BBZPURlQ6d5tcfoyX86y9sgqDTAsOAWX9dnVCzeBpTbFw+6KpMxcGX0uIsecoXwcR/ +meNS+15JKUfv0rAYkdm8UcxFXsD8IksthGOK+dJF5ZR6NFBjsw3L2YRHsIgSW34/Ito 5E0WnKW8iBwi6XZVZEMCY6btWCZVNGJSGqnm8QFR5Nec6UlFzrTPe9e1ZXEArQG9+Xmp g9Rbqy8zg0zdBt/PeAoTgov6WwZjMfc7ucQKPmF3LLj9roNsoOC856AbkpO1B4HU9Xyk e/5+4AbQ5zhK/JTnkvIRyVqh0nwwo3b17GA8RDq7XKxXJ6E7NZD3Bmj/9fBYgY35InNF YBeA== X-Gm-Message-State: AOJu0YzR5VzNqbmc/P1P0uneRNpPnvo2Mq2Jxzuyppu6zzgOtdx/Hhzf ZZ/Qjerpd36nb4+Dt30WCjbBFETZO2mUgaGzIs4JUEDaAUzm9vUtRxyELZmDkzGhyuE5J6Xlm6a pqYzS3U9dqbbomiX9Tq2GNoe6yRblw1uqcVqi8vCuRPxBoTUfUymi X-Received: by 2002:a6b:6302:0:b0:7bf:928d:3149 with SMTP id p2-20020a6b6302000000b007bf928d3149mr1671061iog.26.1706103422341; Wed, 24 Jan 2024 05:37:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBqlY+1h4C1Blc8cuiKUmfzB+aJ61OzPF5/3K6MNdRZ+rcpdGf8xvZIjpusC02Nz7jzI53ew== X-Received: by 2002:a6b:6302:0:b0:7bf:928d:3149 with SMTP id p2-20020a6b6302000000b007bf928d3149mr1671050iog.26.1706103422121; Wed, 24 Jan 2024 05:37:02 -0800 (PST) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id z15-20020a6bc90f000000b007bf05f618f3sm7778526iof.55.2024.01.24.05.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 05:37:01 -0800 (PST) Date: Wed, 24 Jan 2024 06:37:00 -0700 From: Alex Williamson To: Eric Auger Cc: eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, jean-philippe@linaro.org, peter.maydell@linaro.org, zhenzhong.duan@intel.com, peterx@redhat.com, yanghliu@redhat.com, mst@redhat.com, clg@redhat.com, jasowang@redhat.com Subject: Re: [PATCH 1/3] virtio-iommu: Add an option to define the input range width Message-ID: <20240124063700.67c8c32c.alex.williamson@redhat.com> In-Reply-To: References: <20240123181753.413961-1-eric.auger@redhat.com> <20240123181753.413961-2-eric.auger@redhat.com> <20240123165141.7a79de34.alex.williamson@redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=alex.williamson@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 24 Jan 2024 14:14:19 +0100 Eric Auger wrote: > Hi Alex, > > On 1/24/24 00:51, Alex Williamson wrote: > > On Tue, 23 Jan 2024 19:15:55 +0100 > > Eric Auger wrote: > > > >> aw-bits is a new option that allows to set the bit width of > >> the input address range. This value will be used as a default for > >> the device config input_range.end. By default it is set to 64 bits > >> which is the current value. > >> > >> Signed-off-by: Eric Auger > >> --- > >> include/hw/virtio/virtio-iommu.h | 1 + > >> hw/virtio/virtio-iommu.c | 4 +++- > >> 2 files changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/include/hw/virtio/virtio-iommu.h b/include/hw/virtio/virtio-iommu.h > >> index 781ebaea8f..5fbe4677c2 100644 > >> --- a/include/hw/virtio/virtio-iommu.h > >> +++ b/include/hw/virtio/virtio-iommu.h > >> @@ -66,6 +66,7 @@ struct VirtIOIOMMU { > >> bool boot_bypass; > >> Notifier machine_done; > >> bool granule_frozen; > >> + uint8_t aw_bits; > >> }; > >> > >> #endif > >> diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c > >> index ec2ba11d1d..e7f299e0c6 100644 > >> --- a/hw/virtio/virtio-iommu.c > >> +++ b/hw/virtio/virtio-iommu.c > >> @@ -1314,7 +1314,8 @@ static void virtio_iommu_device_realize(DeviceState *dev, Error **errp) > >> */ > >> s->config.bypass = s->boot_bypass; > >> s->config.page_size_mask = qemu_real_host_page_mask(); > >> - s->config.input_range.end = UINT64_MAX; > >> + s->config.input_range.end = > >> + s->aw_bits == 64 ? UINT64_MAX : BIT_ULL(s->aw_bits) - 1; > > What happens when someone sets aw_bits = 1? There are a whole bunch of > > impractical values here ripe for annoying bug reports. vtd_realize() > > returns an Error for any values other than 39 or 48. We might pick an > > arbitrary lower bound (39?) or some other more creative solution here > > to avoid those silly issues in our future. Thanks, > You're right. I can check the input value. This needs to be dependent on > the machine though but this should be feasable. > Then I would allow 39 and 48 for q35 and 64 only on ARM. AFAIK AMD-Vi supports 64-bit address space. Without querying the host there's no way to place an accurate limit below 64-bit. Thanks, Alex > >> s->config.domain_range.end = UINT32_MAX; > >> s->config.probe_size = VIOMMU_PROBE_SIZE; > >> > >> @@ -1525,6 +1526,7 @@ static Property virtio_iommu_properties[] = { > >> DEFINE_PROP_LINK("primary-bus", VirtIOIOMMU, primary_bus, > >> TYPE_PCI_BUS, PCIBus *), > >> DEFINE_PROP_BOOL("boot-bypass", VirtIOIOMMU, boot_bypass, true), > >> + DEFINE_PROP_UINT8("aw-bits", VirtIOIOMMU, aw_bits, 64), > >> DEFINE_PROP_END_OF_LIST(), > >> }; > >> >