qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	"Fam Zheng" <fam@euphon.net>, "Greg Kurz" <groug@kaod.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 1/6] accel/tcg/cpu-exec: Use RCU_READ macro
Date: Wed, 24 Jan 2024 08:41:56 +0100	[thread overview]
Message-ID: <20240124074201.8239-2-philmd@linaro.org> (raw)
In-Reply-To: <20240124074201.8239-1-philmd@linaro.org>

Replace the manual rcu_read_(un)lock calls by the
WITH_RCU_READ_LOCK_GUARD macro (See commit ef46ae67ba
"docs/style: call out the use of GUARD macros").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 accel/tcg/cpu-exec.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 67eda9865e..6b3f66930e 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -1070,21 +1070,21 @@ int cpu_exec(CPUState *cpu)
         return EXCP_HALTED;
     }
 
-    rcu_read_lock();
-    cpu_exec_enter(cpu);
+    WITH_RCU_READ_LOCK_GUARD() {
+        cpu_exec_enter(cpu);
 
-    /*
-     * Calculate difference between guest clock and host clock.
-     * This delay includes the delay of the last cycle, so
-     * what we have to do is sleep until it is 0. As for the
-     * advance/delay we gain here, we try to fix it next time.
-     */
-    init_delay_params(&sc, cpu);
+        /*
+         * Calculate difference between guest clock and host clock.
+         * This delay includes the delay of the last cycle, so
+         * what we have to do is sleep until it is 0. As for the
+         * advance/delay we gain here, we try to fix it next time.
+         */
+        init_delay_params(&sc, cpu);
 
-    ret = cpu_exec_setjmp(cpu, &sc);
+        ret = cpu_exec_setjmp(cpu, &sc);
 
-    cpu_exec_exit(cpu);
-    rcu_read_unlock();
+        cpu_exec_exit(cpu);
+    };
 
     return ret;
 }
-- 
2.41.0



  reply	other threads:[~2024-01-24  7:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  7:41 [PATCH 0/6] hw/accel: Use RCU_READ macros Philippe Mathieu-Daudé
2024-01-24  7:41 ` Philippe Mathieu-Daudé [this message]
2024-01-24  9:34   ` [PATCH 1/6] accel/tcg/cpu-exec: Use RCU_READ macro Manos Pitsidianakis
2024-01-24 21:14   ` Richard Henderson
2024-01-28  1:07   ` Richard Henderson
2024-01-24  7:41 ` [PATCH 2/6] hw/9pfs/9p-synth: " Philippe Mathieu-Daudé
2024-01-24  7:49   ` Greg Kurz
2024-01-24 13:15   ` Christian Schoenebeck
2024-01-24  7:41 ` [PATCH 3/6] hw/display/virtio-gpu-udmabuf: " Philippe Mathieu-Daudé
2024-01-24  9:13   ` Manos Pitsidianakis
2024-01-24  7:41 ` [PATCH 4/6] hw/scsi/virtio-scsi: " Philippe Mathieu-Daudé
2024-01-24  9:17   ` Manos Pitsidianakis
2024-01-24 10:26     ` Philippe Mathieu-Daudé
2024-01-24  7:42 ` [PATCH 5/6] hw/vfio/common: Use RCU_READ macros Philippe Mathieu-Daudé
2024-01-24  9:25   ` Manos Pitsidianakis
2024-01-24 14:09     ` Philippe Mathieu-Daudé
2024-02-16  8:49       ` Philippe Mathieu-Daudé
2024-02-16  9:13         ` Cédric Le Goater
2024-01-24  7:42 ` [PATCH 6/6] hw/virtio/vhost: Use RCU_READ macro Philippe Mathieu-Daudé
2024-01-24  9:15   ` Manos Pitsidianakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124074201.8239-2-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=fam@euphon.net \
    --cc=groug@kaod.org \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).